[jbosstools-dev] Re: A few questions

[Snjezana Peco]

Slava already removed unnecessary code.
I didn't mark the issue as resolved because I couldn't and still cannot 
reproduce it.
The initializeDefault{Plugin}Preferences() method is used in some more 
places in the code (using reflection) what can cause similar issues. For 
instance:
org.jboss.tools.common.text.xml/XmlEditorPlugin.initializeDefaultPluginPreferences() 
- initializes preferences of the org.eclipse.jdt.ui plugin
org.jboss.tools.common.text.xml/XmlPreferenceConstants.initializeTextEditorValues() 
- initializes preferences of the org.eclipse.ui.editors plugin

Snjeza

Max Rydahl Andersen wrote:
> cool - Snjezana can make her fix then ;)
>
>> Hi Max,
>>
>> Yes, methods
>> initializeDefaultPluginPreferences()
>> and
>> initializeDefaultPreferences(IPreferenceStore store)
>> can be removed from ModelUIPlugin.
>>
>> Slava
>>
>> ----- Original Message -----
>> From: "Max Rydahl Andersen" <max.andersen at redhat.com>
>> To: "Snjezana Peco" <snjezana.peco at redhat.com>
>> Cc: <jbosstools-dev at lists.jboss.org>
>> Sent: Wednesday, September 10, 2008 12:32 PM
>> Subject: [jbosstools-dev] Re: A few questions
>>
>>
>>> Hi Snjezana,
>>>
>>> Lets have this on the jbosstools-dev list.
>>>
>>> > Can I remove the initializeDefaultPreferences(IPreferenceStore store)
>>> > method described at
>>> > 
>>> https://jira.jboss.org/jira/browse/JBIDE-2025?focusedCommentId=12410121#action_12410121 
>>>
>>> > ?
>>>
>>> If it has no purpose then sure. Alexey/Slava, do you know if it has any
>>> purpose ? It looks very wrong.
>>>
>>> > Do you agree that I fix 
>>> https://jira.jboss.org/jira/browse/JBIDE-1096 ?
>>> > I would create a fragment that would define
>>> > org.eclipse.swt.browser.XULRunnerPath as described in
>>> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=201774
>>>
>>> I thought they fixed this in Ganymede ?
>>> If we need to do something then yes, lets get it done. Would this only
>>> work for JBDS or also JBoss Tools ?
>>> -- 
>>> /max
>>> _______________________________________________
>>> jbosstools-dev mailing list
>>> jbosstools-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>
>
>