[jbosstools-dev] On the topic of useful PR title/descriptions and git commit messages

Max Rydahl Andersen max.andersen at redhat.com
Wed Nov 21 11:29:02 EST 2012


>> 
>> 1 line for title, max 50 characters and don't end with a '.'
>> 
>> JBIDE-1234 - hibernate tools 4 classloading is broken.
>> 
> 
> ;)
> 
> Anyway, thanks for the suggestions. I usually don't use '-', but that shouldn't matter, right?

No, it doesn't matter. 

> Also, I never used newlines in the long description and now I see that it's not good - git log now displays one long line :( So breaking the lines manually is a good idea.

Yes, its normal coming from svn, where looking at history is/was painful so rarely noticed.

but in git you do it all the time and the tools assumes this style and gives much better experience when using the newline.

/max




More information about the jbosstools-dev mailing list