[jbosstools-dev] Assigning JIRAs w/ patches for review

Max Rydahl Andersen max.andersen at redhat.com
Thu Oct 4 13:17:20 EDT 2012


>> But yeah, I think its probably just fine to rely on if Jira is
>> Resolved and github pull request url is set then it was fixed via
>> that pull request.
>> 
>> Anything else sounds like over-process.
> 
> I'm just providing an example of what we do on SY, not saying you should adopt that for your project.  

We actually have the same process (jira wise) - what I call over-process is if we started saying we should add "review-requested"/"review" on top of this to be able to query would be overprocess.

> I would probably prefer that review comments were in the JIRA for posterity, but you do have the link to the request, so...


Yeah, now just cross our fingers github does not get acquired and shutdown ;)

/max


More information about the jbosstools-dev mailing list