[jbosstools-dev] Proposal to change default configuration of Tycho-surefire-plugin

[Max Rydahl Andersen]

looks ok but got question about why explicit setting isn't ok - commented on the PR.

/max

On Wed, Sep 25, 2013 at 03:23:03PM +0200, Mickael Istria wrote:
>Hi all,
>
>As we are approaching for a solution to Tycho bug 386988 (allowing to 
>run test with Surefire on an existing RCP application), it seems 
>necessary to clean a little the default configuration of 
>tycho-surefire-plugin so it would work as expected in all cases.
>I suggest the following change: 
>https://github.com/jbosstools/jbosstools-build/pull/111 . It is mainly 
>about removing the forced values for product, application, and the 
>dependency to org.eclipse.platform. The default behavior of Tycho 
>should already set all those values correctly, and the upcoming change 
>for 386988 forces us to avoid setting explicitly those values to test 
>against existing applications (such as JBoss Developer Studio).
>It also removes references to jmock, since it seems to me that no-one 
>is using it.
>
>So please have a look and comment if you fear it will break something 
>in your code/tests.
>Cheers,
>-- 
>Mickael Istria
>Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
>My blog <http://mickaelistria.wordpress.com> - My Tweets 
><http://twitter.com/mickaelistria>

>_______________________________________________
>jbosstools-dev mailing list
>jbosstools-dev at lists.jboss.org
>https://lists.jboss.org/mailman/listinfo/jbosstools-dev