[jbosstools-dev] ACTION REQUIRED: making sure commits are in master, help INSIDE!!!

[Max Rydahl Andersen]

On 18 Apr 2016, at 23:09, Rob Stryker wrote:

> On 04/18/2016 05:05 AM, Max Rydahl Andersen wrote:
>>
>> great initiative - may I suggest you do a PR for your script and put 
>> it at 
>> https://github.com/jbosstools/jbosstools-build-ci/tree/jbosstools-4.3.x/util 
>> where we have other such utilities.
>>
>> Also, might be easier if you put the run info into  jira since the 
>> output is quite hard to read/use here from mail.
>>
>> btw. it looks like this tool actually is very good at finding the 
>> false positives - i.e. change in pom.xml where it just changes 
>> version seem to be something you could filter out somehow ?
>>
>
>
> First, I disagree that these are false-positives ;)   These are 
> commits that are in maintenance that aren't in master.
>
> And, in all honesty, I think it'd be a mistake to simply filter them 
> out. I think it's much better to list the false positive and let the 
> component owner use his judgment whether the patch needs further 
> inspection or not. Such simple version-changes will be very very easy 
> for a human to spot as irrelevant to master.  This may cause the 
> repository owner to waste 2-3 seconds for each commit, but it 
> guarantees that every possible unmatched commit is found.

If you consider them correct matches what is the difference between your 
script and simply running a "git diff master jbosstools-4.3.x" and 
review the differences ?

/max
http://about.me/maxandersen