[jbosstools-dev] Block PRs for merge untill the Jenkins build is successful

[Aurelien Pupier]

randomly failing tests is an horror but they reveal real issues, often in
products, sometimes in tests or CI.
Changing CI is often a great way to discover all our "concurrency issues"
as everything is not running at the same pace.

For Fuse Tooling (and in my previous company), What i try to do when it
occurs instead of just relaunching the job is to report a JIRA issue.
it will help to gather more information, imagine how to add logs or
whatever to have more information when it will happen next. Each time it
occurs again, we can add a comment it helps to know what is the frequency
and what is the urgency to fix it. it is easier to include time for
investigation in sprint if we know how much we are loosing every sprint
(and how often a user might hit this issue).

At a comparison level, I saw a great keynote from OpenStack organization.
They also had this issue and they even created an automatic reporting with
automatic relaunch of jobs when it failed for known "random failures".





On Wed, May 10, 2017 at 10:44 AM, Andre Dietisheim <adietish at redhat.com>
wrote:

> Radim, these are exactly the EGit failures that I was referring to. The
> one you pasted is among the ones that occurr. But afaik the failures are
> not consistent and they dont happen in the old jenkins.
> Am 10.05.17 um 10:41 schrieb Radim Hopp:
>
> Last time I sent PR to openshift repo I had to be really patient, because
> the build was failing on "java.io.IOException: Could not delete file
> /mnt/hudson_workspace/workspace/jbosstools-openshift-Pull-Request/tests/
> org.jboss.tools.openshift.egit.test/target/work/data/Project-1494366069560".
> I had to run the PR check job ~5 times for it to finally pass.
>
> On Wed, May 10, 2017 at 10:38 AM Andre Dietisheim <adietish at redhat.com>
> wrote:
>
>> I agree in the principle. But for the approach to be successfull we need
>> our new new jenkins to be rocksolid which it isnt for now. Our EGit tests
>> fail randomly on it while they pass on the old jenkins.
>> Am 10.05.17 um 10:17 schrieb Dmitrii Bocharov:
>>
>> Jeff, for this purpose we can think of some special comment for such PRs,
>> that would allow to merge them (like *testPR* for a new build). As far
>> as i know it's possible.
>>
>> On Wed, May 10, 2017 at 9:01 AM, Jean-Francois Maury <jmaury at redhat.com>
>> wrote:
>>
>>> I'm ok with that rule except for one case when the pr is done before the
>>> version bump has been merged then the Jenkins build will fail because of
>>> the baseline check so maybe we need to update the pr Jenkins build
>>>
>>> Jeff
>>>
>>> Le 9 mai 2017 23:10, "Mickael Istria" <mistria at redhat.com> a écrit :
>>>
>>>> FYI, not merging the broken patches is the policy followed by most
>>>> Eclipse.org projects and overall, none of this project has complained from
>>>> a reduced productivity; on the contrary, catching and fixing issues
>>>> immediately on the right context has improved quality and reduced the
>>>> necessary amount of quick fix patches (which are actually quite time
>>>> consuming and stressful for their low added-value).
>>>> So I think if it works for Eclipse.org projects, it can work for JBoss
>>>> Tools.
>>>>
>>>> Cheers,
>>>> Mickael
>>>>
>>>> _______________________________________________
>>>> jbosstools-dev mailing list
>>>> jbosstools-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>>
>>>
>>
>>
>> _______________________________________________
>> jbosstools-dev mailing listjbosstools-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>
>>
>> _______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>
> --
>
> RADIM HOPP
>
> RED HAT JBOSS DEVELOPER STUDIO QUALITY ASSURANCE
>
> Red Hat Czech s.r.o. <https://www.redhat.com/>
>
> rhopp at redhat.com    IM: rhopp
> <https://red.ht/sig>
> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
> @redhatway <https://twitter.com/redhatway>   @redhatinc
> <https://instagram.com/redhatinc>   @redhatsnaps
> <https://snapchat.com/add/redhatsnaps>
>
>
>
> _______________________________________________
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>



-- 

AURÉLIEN PUPIER

SENIOR SOFTWARE ENGINEER, FUSE TOOLING

Red Hat France <https://www.redhat.com/>

apupier at redhat.com    IM: apupier
<https://red.ht/sig>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20170510/ffe984b7/attachment-0001.html