Max:<br><br>The big bottleneck in that stacktrace is obviously the following lines:<br><br><br> ArchiveModuleFactory(JBossModuleFactory).cacheModules() line: 86<br><div style="direction: ltr;"> ArchiveModuleFactory(JBossModuleFactory).getModules() line: 66
<br> ModuleFactory.getModules() line: 133</div><br><br>The problem here is that no matter what I do, I cant get "cacheModules" to be called more than once in any session. That method should *only* be called once, at the very startup of the model, and I admit it is a decently long-running method which goes through the entire workspace looking for jars.
<br><br>(I know what you're going to say... why even go through and LOOK for jars all at once? Why not just respond with a module upon request... and the reason here is the way I understand WTP to work... the factory has a method getModules which obviously gets called at random times, so I kind of need to have all possible modules on hand all the time. But a module, the way I use it, is basically just a wrapper. Currently all I do is open the file and if it's a jar, I say poof... you're a module. )
<br><br>Anyway... as I said before... cacheModules is only called upon startup of the factory. I've tried deleting projects, adding projects, pasting in multiple jars at once (which would trigger a whole bunch of resource change events etc), and no matter what I do, I *cannot* get cacheModules to be called a second time.
<br><br><br>Some more details: <br><br>cacheModules is only called if a variable named pathToModule (a hashmap) is null. This is a field inside my ModuleFactoryDelegate (JBossModuleFactory), which is an extension point who's constructor is only called once by the wtp structure, so there's no question here about multiple factory instances being created without my knowledge, each trying to create their own cache.
<br><br>The variable itself is protected, and there's absolutely no point in my code where it is set to null. It starts as null, however once the cache is filled, it is never emptied or reset. If you dig into it you'll actually find there's two caches. My own cache in JBossModuleFactory, and the wtp cache in ModuleFactory. I do reset the wtp cache, but then it just asks me for a list of modules again, and I send it my current local cache. I *have* gotten that scenerio to occur, but I've not once been able to get cacheModules to be called more than once a session.
<br><br>Marshall suggests you send me your workspace and a list of repeatable steps I could use. <br><br>- Rob<br><br><br><br><div><span class="gmail_quote">On 7/20/06, <b class="gmail_sendername">Max Rydahl Andersen</b> <
<a href="mailto:max.andersen@jboss.com">max.andersen@jboss.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>In a decent sized workspace (basically just hibernate labs) I get to wait
<br>many times :(<br><br>The stacktrace are mostly like this:<br><br>Is this "just" WTP having fun (i see .getModules() calls) or are we doing<br>something bad ?<br><br>Thread [main] (Suspended)<br> ZipFile.open
(String, int, long) line: not available [native method]<br> JarFile(ZipFile).<init>(File, int) line: 203<br> JarFile.<init>(File, boolean, int) line: 132<br> JarFile.<init>(File) line: 97
<br> ArchiveModuleFactory.supports(IResource) line: 65<br> ArchiveModuleFactory.acceptAddition(IResource) line: 33<br> JBossModuleFactory$1.visit(IResource) line: 88<br> Resource$2.visit(IResourceProxy) line: 105
<br> Resource$1.visitElement(ElementTree, IPathRequestor, Object) line: 57<br> ElementTreeIterator.doIteration(DataTreeNode, IElementContentVisitor)<br>line: 81<br> ElementTreeIterator.doIteration(DataTreeNode, IElementContentVisitor)
<br>line: 85<br> ElementTreeIterator.doIteration(DataTreeNode, IElementContentVisitor)<br>line: 85<br> ElementTreeIterator.doIteration(DataTreeNode, IElementContentVisitor)<br>line: 85<br> ElementTreeIterator.doIteration
(DataTreeNode, IElementContentVisitor)<br>line: 85<br> ElementTreeIterator.doIteration(DataTreeNode, IElementContentVisitor)<br>line: 85<br> ElementTreeIterator.doIteration(DataTreeNode, IElementContentVisitor)
<br>line: 85<br> ElementTreeIterator.doIteration(DataTreeNode, IElementContentVisitor)<br>line: 85<br> ElementTreeIterator.doIteration(DataTreeNode, IElementContentVisitor)<br>line: 85<br> ElementTreeIterator.doIteration
(DataTreeNode, IElementContentVisitor)<br>line: 85<br> ElementTreeIterator.iterate(IElementContentVisitor) line: 126<br> Project(Resource).accept(IResourceProxyVisitor, int) line: 67<br> Project(Resource).accept(IResourceVisitor, int, int) line: 103
<br> Project(Resource).accept(IResourceVisitor) line: 87<br> ArchiveModuleFactory(JBossModuleFactory).cacheModules() line: 86<br> ArchiveModuleFactory(JBossModuleFactory).getModules() line: 66<br>
ModuleFactory.getModules() line: 133<br> ServerUtil.getModules() line: 247<br> ServerUtil.getModule(IProject) line: 47<br> ResourceManager.publishHandleProjectChange(IResourceDelta) line: 916<br> ResourceManager$1.visit(IResourceDelta) line: 110
<br> ResourceDelta.accept(IResourceDeltaVisitor, int) line: 67<br> ResourceDelta.accept(IResourceDeltaVisitor, int) line: 76<br> ResourceDelta.accept(IResourceDeltaVisitor) line: 48<br> ResourceManager$ServerResourceChangeListener.resourceChanged(IResourceChangeEvent)
<br>line: 104<br> NotificationManager$2.run() line: 280<br> SafeRunner.run(ISafeRunnable) line: 37<br> NotificationManager.notify(ResourceChangeListenerList$ListenerEntry[],<br>IResourceChangeEvent, boolean) line: 274
<br> NotificationManager.broadcastChanges(ElementTree, ResourceChangeEvent,<br>boolean) line: 148<br> Workspace.broadcastPostChange() line: 256<br> Workspace.endOperation(ISchedulingRule, boolean, IProgressMonitor) line:
<br>958<br> Workspace.run(IWorkspaceRunnable, ISchedulingRule, int, IProgressMonitor)<br>line: 1746<br> WorkspaceModifyDelegatingOperation(WorkspaceModifyOperation).run(IProgressMonitor)<br>line: 113<br>
WorkspaceOperationRunner.run(boolean, boolean, IRunnableWithProgress,<br>ISchedulingRule) line: 73<br> WorkspaceOperationRunner.run(boolean, boolean, IRunnableWithProgress)<br>line: 63<br> CompilationUnitDocumentProvider(TextFileDocumentProvider).executeOperation(TextFileDocumentProvider$DocumentProviderOperation,
<br>IProgressMonitor) line: 460<br> CompilationUnitDocumentProvider(TextFileDocumentProvider).saveDocument(IProgressMonitor,<br>Object, IDocument, boolean) line: 744<br> CompilationUnitEditor(AbstractTextEditor).performSave(boolean,
<br>IProgressMonitor) line: 3796<br> CompilationUnitEditor.performSave(boolean, IProgressMonitor) line: 1343<br> CompilationUnitEditor.doSave(IProgressMonitor) line: 1396<br> DefaultSaveable.doSave(IProgressMonitor) line: 50
<br> EditorManager$6.run(IProgressMonitor) line: 1247<br> SaveableHelper$4.run(IProgressMonitor) line: 252<br> ModalContext.runInCurrentThread(IRunnableWithProgress, IProgressMonitor)<br>line: 369<br>
ModalContext.run(IRunnableWithProgress, boolean, IProgressMonitor,<br>Display) line: 313<br> ApplicationWindow$1.run() line: 763<br> BusyIndicator.showWhile(Display, Runnable) line: 67<br> WorkbenchWindow(ApplicationWindow).run(boolean, boolean,
<br>IRunnableWithProgress) line: 760<br> WorkbenchWindow.run(boolean, boolean, IRunnableWithProgress) line: 2283<br> SaveableHelper.runProgressMonitorOperation(String, IRunnableWithProgress,<br>IWorkbenchWindow) line: 258
<br> EditorManager.saveAll(List, boolean, boolean, IWorkbenchWindow) line:<br>1260<br> EditorManager.saveAll(boolean, boolean) line: 1055<br> WorkbenchPage.saveAllEditors(boolean) line: 2968<br>
SaveAllAction.run() line: 132<br> SaveAllAction(Action).runWithEvent(Event) line: 499<br> ActionHandler.execute(ExecutionEvent) line: 119<br> Command.executeWithChecks(ExecutionEvent) line: 461<br>
ParameterizedCommand.executeWithChecks(Object, Object) line: 424<br> HandlerService.executeCommand(ParameterizedCommand, Event) line: 160<br> WorkbenchKeyboard.executeCommand(Binding, Event) line: 466<br>
WorkbenchKeyboard.press(List, Event) line: 799<br> WorkbenchKeyboard.processKeyEvent(List, Event) line: 846<br> WorkbenchKeyboard.filterKeySequenceBindings(Event) line: 564<br> WorkbenchKeyboard.access$3
(WorkbenchKeyboard, Event) line: 506<br> WorkbenchKeyboard$KeyDownFilter.handleEvent(Event) line: 122<br> EventTable.sendEvent(Event) line: 66<br> Display.filterEvent(Event) line: 982<br> StyledText(Widget).sendEvent(Event) line: 927
<br> StyledText(Widget).sendEvent(int, Event, boolean) line: 952<br> StyledText(Widget).sendEvent(int, Event) line: 937<br> StyledText(Widget).sendKeyEvent(int, int, int, int, Event) line: 965<br> StyledText(Widget).sendKeyEvent(int, int, int, int) line: 961
<br> StyledText(Widget).wmChar(int, int, int) line: 1275<br> StyledText(Control).WM_CHAR(int, int) line: 3346<br> StyledText(Control).windowProc(int, int, int, int) line: 3246<br> Display.windowProc
(int, int, int, int) line: 4025<br> OS.DispatchMessageW(MSG) line: not available [native method]<br> OS.DispatchMessage(MSG) line: 1923<br> Display.readAndDispatch() line: 2966<br> Workbench.runEventLoop
(Window$IExceptionHandler, Display) line: 1914<br> Workbench.runUI() line: 1878<br> Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 419<br> PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 149
<br> IDEApplication.run(Object) line: 95<br> PlatformActivator$1.run(Object) line: 78<br> EclipseAppLauncher.runApplication(Object) line: 92<br> EclipseAppLauncher.start(Object) line: 68<br>
EclipseStarter.run(Object) line: 400<br> EclipseStarter.run(String[], Runnable) line: 177<br> NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not<br>available [native method]<br> NativeMethodAccessorImpl.invoke
(Object, Object[]) line: 39<br> DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 25<br> Method.invoke(Object, Object...) line: 585<br> Main.invokeFramework(String[], URL[]) line: 336<br>
Main.basicRun(String[]) line: 280<br> Main.run(String[]) line: 977<br> Main.main(String[]) line: 952<br><br><br>--<br>--<br>Max Rydahl Andersen<br>callto://max.rydahl.andersen<br><br>Hibernate<br><a href="mailto:max@hibernate.org">
max@hibernate.org</a><br><a href="http://hibernate.org">http://hibernate.org</a><br><br>JBoss Inc<br><a href="mailto:max.andersen@jboss.com">max.andersen@jboss.com</a><br>_______________________________________________<br>
jbosside-dev mailing list<br><a href="mailto:jbosside-dev@lists.jboss.org">jbosside-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/jbosside-dev">https://lists.jboss.org/mailman/listinfo/jbosside-dev
</a><br></blockquote></div><br>