<div dir="ltr">Thanks Snjezana..<br><br>Is there any chance of this patch being applied in trunk? I'd rather not maintain a seperate patch build for our extension =)<br><br><div class="gmail_quote">On Tue, Jul 29, 2008 at 4:35 PM, Snjezana Peco <span dir="ltr"><<a href="mailto:snjezana.peco@redhat.com">snjezana.peco@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi,<br>
<br>
The issue has been introduced by fixing <a href="https://jira.jboss.org/jira/browse/JBIDE-2582" target="_blank">https://jira.jboss.org/jira/browse/JBIDE-2582</a> (svn commit #9402).<br>
Attached is a patch that solves this issue.<br>
<br>
Snjeza<br>
<br>
Marshall Culpepper wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="Wj3C7c">
Hey guys..<br>
<br>
Taking a look at org.jboss.tools.vpe and org.jboss.tools.jsf.vpe.richfaces, I noticed a cyclic dependency between the two (making the compilation fail). Obviously trying to remove the dependency from either side gets rid of the error, but introduces compilation problems since there are imports / code use from the dependencies.<br>
<br>
I was wondering if y'all were aware and had any plans to seperate the code.. the easiest side to fix seems to be org.jboss.tools.vpe, as the only code dependency is in org.jboss.tools.vpe.editor.util.ElService at line 275:<br>
<br>
rst = ComponentUtil.getBundleValue(pageContext, attributeNode);<br>
<br>
Any thoughts?<br></div></div>
------------------------------------------------------------------------<br>
<br>
_______________________________________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
</blockquote>
<br>
<br>Index: E:/workspace-3.4M7-JBoss/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/util/ElService.java<br>
===================================================================<br>
--- E:/workspace-3.4M7-JBoss/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/util/ElService.java (revision 9402)<br>
+++ E:/workspace-3.4M7-JBoss/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/util/ElService.java (working copy)<br>
@@ -14,7 +14,7 @@<br>
<br>
import org.eclipse.core.resources.IFile;<br>
import org.eclipse.core.runtime.Assert;<br>
-import org.jboss.tools.jsf.vpe.richfaces.ComponentUtil;<br>
+import org.eclipse.wst.xml.core.internal.provisional.document.IDOMAttr;<br>
import org.jboss.tools.vpe.editor.bundle.BundleMap;<br>
import org.jboss.tools.vpe.editor.context.VpePageContext;<br>
import org.jboss.tools.vpe.editor.css.ELReferenceList;<br>
@@ -272,7 +272,12 @@<br>
final String attribuString = attributeNode.getValue();<br>
String rst = attribuString;<br>
<br>
- rst = ComponentUtil.getBundleValue(pageContext, attributeNode);<br>
+ //rst = ComponentUtil.getBundleValue(pageContext, attributeNode);<br>
+ BundleMap bundle = pageContext.getBundle();<br>
+ String value = attributeNode.getNodeValue();<br>
+<br>
+ int offset=((IDOMAttr) attributeNode).getValueRegionStartOffset();<br>
+ rst = bundle.getBundleValue(value, offset);<br>
<br>
rst = replaceEl(file, rst);<br>
<br>
Index: E:/workspace-3.4M7-JBoss/plugins/org.jboss.tools.vpe/META-INF/MANIFEST.MF<br>
===================================================================<br>
--- E:/workspace-3.4M7-JBoss/plugins/org.jboss.tools.vpe/META-INF/MANIFEST.MF (revision 9402)<br>
+++ E:/workspace-3.4M7-JBoss/plugins/org.jboss.tools.vpe/META-INF/MANIFEST.MF (working copy)<br>
@@ -62,7 +62,6 @@<br>
org.eclipse.ui.ide,<br>
org.jboss.tools.vpe.xulrunner,<br>
org.mozilla.xpcom,<br>
- org.eclipse.draw2d,<br>
- org.jboss.tools.jsf.vpe.richfaces<br>
+ org.eclipse.draw2d<br>
Bundle-Version: 2.1.0<br>
<br>
<br></blockquote></div><br></div>