<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=ISO-8859-1">
<META content="MSHTML 6.00.6001.18294" name=GENERATOR></HEAD>
<BODY text=#000000 bgColor=#ffffff>
<DIV><FONT face=Arial size=2>Hi, Max</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>> <FONT face="Times New Roman" size=3>The
problem is that common isn't just common.</FONT></FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>I suggest to split common. "True" common will
contain only</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>org.jboss.tools.common</FONT></DIV>
<DIV>
<DIV><FONT face=Arial size=2>org.jboss.tools.common.model</FONT></DIV>
<DIV>
<DIV><FONT face=Arial size=2>org.jboss.tools.common.model.ui</FONT></DIV>
<DIV>
<DIV><FONT face=Arial size=2>org.jboss.tools.common.text.xml</FONT></DIV>
<DIV><FONT face=Arial size=2>part of <FONT face=Arial
size=2>org.jboss.tools.common.text.ext</FONT></FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Other plugins may be moved to
org.jboss.tools.jst...</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Or, may we physically leave plugins where they are,
but for build and installation purposes apply this logic separation 'virtually'
by defining other set of features?</FONT></DIV></DIV></DIV></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Next, I will clean common.model from unnecessary
references using new extension points.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>As to what we have now, installing Hibernate Tools
+ common will not add jsf, jsp, etc editors; and though common includes some
excessive knowledge of jsp, jsf, struts, it does not add any
functionality.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Slava</FONT></DIV>
<BLOCKQUOTE
style="PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="BACKGROUND: #e4e4e4; FONT: 10pt arial; font-color: black"><B>From:</B>
<A title=max.andersen@redhat.com href="mailto:max.andersen@redhat.com">Max
Rydahl Andersen</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=scabanovich@exadel.com
href="mailto:scabanovich@exadel.com">Viacheslav Kabanovich</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A title=vyemialyanchyk@exadel.com
href="mailto:vyemialyanchyk@exadel.com">vyemialyanchyk@exadel.com</A> ; <A
title=external-exadel-list@redhat.com
href="mailto:external-exadel-list@redhat.com">Exadel List</A> ; <A
title=jbosstools-dev@lists.jboss.org
href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Thursday, September 10, 2009 2:15
PM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [jbosstools-dev] "Hibernate
Configuration 3.0 XML Editor"</DIV>
<DIV><BR></DIV><BR><BR>Viacheslav Kabanovich wrote:
<BLOCKQUOTE cite=mid:B2F7D0C8CBCD4721B743C1DBA1F20F53@GLORYPC type="cite">
<META content="MSHTML 6.00.6001.18294" name=GENERATOR>
<STYLE>@font-face {
font-family: Calibri;
}
@page Section1 {size: 8.5in 11.0in; margin: 56.7pt 42.5pt 56.7pt 85.05pt; }
P.MsoNormal {
FONT-SIZE: 11pt; MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"
}
LI.MsoNormal {
FONT-SIZE: 11pt; MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"
}
DIV.MsoNormal {
FONT-SIZE: 11pt; MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"
}
A:link {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.EmailStyle17 {
COLOR: windowtext; FONT-FAMILY: "Calibri","sans-serif"; mso-style-type: personal-compose
}
.MsoChpDefault {
mso-style-type: export-only
}
DIV.Section1 {
page: Section1
}
</STYLE>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<DIV><FONT face=Arial size=2>
<P class=MsoNormal><FONT face=Arial size=2>Hi, Vitali, </FONT></P>
<P class=MsoNormal>> I want to enhance this editor ("Hibernate
Configuration 3.0 XML Editor") </P>
<P class=MsoNormal>> to make it more useful and I want to integrate it
into Hibernate Tools.<O:P></O:P></P>
<P class=MsoNormal>> For this it is necessary to separate
org.jboss.tools.hibernate.xml </P>
<P class=MsoNormal>> and org.jboss.tools.hibernate.xml.ui, make it
detached from XModel
</P>
<P class=MsoNormal> </P>
<P class=MsoNormal><FONT face=Arial size=2>In my opinion that just
means implementing new editor from scratch. In doing so, you will
develop components that you may wish to put to common. We have many xml
editors, there ui has a lot in common, so why not share new approaches
between them? And that is exactly what XModel framework does. Plugins
.hibernate.xml and .hibernate.xml.ui include just few lines of code
customizing components developed in common. Why 'integrating
editor into Hibernate Tools' should mean separating it from
common?</FONT></P></FONT></DIV></BLOCKQUOTE>The problem is that common isn't
just common. It includes ton's of jsf, xhtml, jsp and even struts references.
That is what we need separated before I'm ok having Hibernate tools feature
depend on it.<BR><BR>i.e. if I *only* install Hibernate tools feature it
should *not* result in other additional editors such as jsf, jsp, xhtml etc.
to be installed.<BR><BR>That were the case last time I tried it - if that has
changed we should look at it again.<BR><FONT size=2><FONT
face=Arial><BR>/max<BR></BLOCKQUOTE></FONT></FONT></BODY></HTML>