<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
public static boolean isBinaryObject(IModule[] moduleTree) in
PublishUtil class updated to <br>
<br>
public static boolean isBinaryObject(IModule[] moduleTree) {<br>
IJ2EEModule j2eeModule = (IJ2EEModule)
moduleTree[moduleTree.length-1].loadAdapter(IJ2EEModule.class, null);<br>
return j2eeModule != null && j2eeModule.isBinary();<br>
}<br>
<br>
since it is references from other plug-ins.<br>
<br>
Thanks<br>
Denis<br>
<br>
On 07/16/2010 04:42 PM, Denis Golovin wrote:
<blockquote cite="mid:4C40EE5E.4040105@exadel.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Haven't seen this email since was deep, deep in debugger and fixed this
issue the same way, but couple hours later :(<br>
<br>
Thanks<br>
Denis<br>
<br>
<br>
On 07/16/2010 03:02 PM, Snjezana Peco wrote:
<blockquote cite="mid:4C40D6F0.8010903@gmail.com" type="cite">Hi, <br>
<br>
<br>
Attached is a patch that works correctly for WAR and EAR projects. <br>
<br>
<br>
Andersen Max wrote: <br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">9. JBoss Tools 3.2 Issue: <br>
web.xml: All comments are stripped after project import, must restore
original web.xml from svn <br>
(not an issue with JBoss Tools 3.1). <br>
</blockquote>
This problem is related to webtools and is described in
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jira.jboss.org/browse/JBIDE-6228">https://jira.jboss.org/browse/JBIDE-6228</a>.
<br>
The problem was also existing in JBoss Tools 3.1 when the JBoss Maven
Seam Configurator was included. <br>
</blockquote>
<br>
Do we ensure we don't touch the web.xml if we don't need to ? I would
expect that this maven project is already "seamified" ? <br>
<br>
</blockquote>
<br>
The JBoss Maven Seam Configuraator doesn't change web.xml, but adds
Seam facet that changes web.xml. See
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jira.jboss.org/browse/JBIDE-6228?focusedCommentId=12529695&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12529695">https://jira.jboss.org/browse/JBIDE-6228?focusedCommentId=12529695&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12529695</a>
<br>
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">10. m2eclipse issues: <br>
</blockquote>
The version of JRE isn't important for EAR project because an EAR
project doesn't contain Java sources. <br>
The problem related to application.xml is described in
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jira.jboss.org/browse/JBIDE-4809">https://jira.jboss.org/browse/JBIDE-4809</a>
<br>
There is a patch for it. <br>
</blockquote>
<br>
Could we follow up with m2eclipse/Fred B. on these so we get this fixed
in m2eclipse ? <br>
</blockquote>
<br>
Fred B. knows about this problem. I suppose that Java was added because
the Maven classpath conatainer was necessary to deploy libraries. <br>
<br>
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">11. JBoss Tools (or m2eclipse?) issue: <br>
The EAR module's src/application folder should be source folder. <br>
</blockquote>
Since EAR projects don't contain Java source files, that is
unnecessary. JBoss Tools doesn't configure Java capabilities for any
project, so that is related to m2eclipse. <br>
</blockquote>
<br>
do they enable java on the ear project !? <br>
<br>
</blockquote>
<br>
A non-mavenized JBoss Seam EAR project has the Java nature/builder.
Seam facet enables it. <br>
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">12. JBoss Tools issue: <br>
Schema validation for some resource files fails due to use of Maven
property placeholders. The > target resource files should be
correct, so they are the files that should be validated. <br>
</blockquote>
This problem can be fixed in the following way: <br>
<br>
- add the components.properties file to the classpath which contains
all required maven properties. In the component.xml file, those
properties should be declared as "@property_name@" <br>
</blockquote>
<br>
that would only work for the component.xml I reckon..? <br>
<br>
</blockquote>
<br>
The components.xml file is the only file that contains errors. <br>
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">"Duplicate component" errors are marked
correctly because there are several same components declared in ejb and
war projects. <br>
</blockquote>
<br>
<blockquote type="cite">
<blockquote type="cite">13. EAR Deployment assembly <br>
JBoss Tools 3.2 Issues: <br>
* seam-tutorial-ejb module has wrong naming:
seam-tutorial-ejb.ejb. Should be named <br>
seam-tutorial-ejb.jar <br>
* Resource files should be published from the EAR target folder due
to filtering of <br>
resource files and generating of application.xml and jboss.app.xml
during the Maven <br>
generate-sources goal. <br>
</blockquote>
This issue is related to <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://jira.jboss.org/browse/JBIDE-4809">https://jira.jboss.org/browse/JBIDE-4809</a>.
You
can use the bundleFileName element as a workaround. The problem is an
m2eclipse problem. <br>
</blockquote>
<br>
looks like the .ejb issue is fixed in 0.10.1 ?
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://issues.sonatype.org/browse/MNGECLIPSE-2155">https://issues.sonatype.org/browse/MNGECLIPSE-2155</a>
<br>
</blockquote>
<br>
Will check. <br>
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">14. Web Deployment assembly <br>
JBoss Tools 3.2 Issue: <br>
Resource files should be published from WAR target folder due to
filtering of resource files <br>
during the Maven generate-sources goal. <br>
</blockquote>
The WTP configurator publishes war projects. It is part of m2eclipse.
Anyway, resources are published to WEB-INF/classes and exist in the
classpath of the application which is correct in my opinion. The
messages_xx.properties files have to be in the classpath, for instance.
<br>
</blockquote>
<br>
But m2eclipse doesn't put them there (i.e. WebContent/WEB-INF/classes)
does it ? <br>
</blockquote>
<br>
It does, m2eclipse puts them to WebContent/WEB-INF/classes <br>
<br>
Snjeza <br>
<br>
<br>
<blockquote type="cite">/max <br>
<blockquote type="cite">Snjeza <br>
<br>
Andersen Max wrote: <br>
<blockquote type="cite">hi, <br>
<br>
@leifoolsen posted this
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://www.glxn.net/seam-maven-refimpl/doc/tutorial/05-eclipse-3.6-worklog.html">http://www.glxn.net/seam-maven-refimpl/doc/tutorial/05-eclipse-3.6-worklog.html</a>
<br>
<br>
this is him explaining how to use JBoss Tools + Maven on a seam
project. <br>
<br>
The walkthrough illustrates how resource filtering in maven + the WTP
assembly is fighting against each other ;( <br>
<br>
it also shows that he also bumped into JBIDE-6596 with respect to
lib/jboss-seam.jar. <br>
<br>
Its an excellent read to see some of the problems we are facing.... <br>
<br>
/max <br>
_______________________________________________ <br>
jbosstools-dev mailing list <br>
<a moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a>
<br>
<br>
</blockquote>
### Eclipse Workspace Patch 1.0 <br>
#P org.jboss.ide.eclipse.as.core <br>
Index:
jbosscore/org/jboss/ide/eclipse/as/core/publishers/PublishUtil.java <br>
=================================================================== <br>
---
jbosscore/org/jboss/ide/eclipse/as/core/publishers/PublishUtil.java
(revision 23095) <br>
+++
jbosscore/org/jboss/ide/eclipse/as/core/publishers/PublishUtil.java
(working copy) <br>
@@ -22,6 +22,7 @@ <br>
import org.eclipse.core.runtime.Path; <br>
import org.eclipse.core.runtime.Status; <br>
import org.eclipse.jst.server.core.IEnterpriseApplication; <br>
+import org.eclipse.jst.server.core.IJ2EEModule; <br>
import org.eclipse.wst.common.componentcore.ModuleCoreNature; <br>
import org.eclipse.wst.server.core.IModule; <br>
import org.eclipse.wst.server.core.internal.DeletedModule; <br>
@@ -37,11 +38,11 @@ <br>
import org.jboss.ide.eclipse.as.core.server.IJBossServerConstants; <br>
import org.jboss.ide.eclipse.as.core.server.xpl.ModulePackager; <br>
import org.jboss.ide.eclipse.as.core.util.DeploymentPreferenceLoader; <br>
-import org.jboss.ide.eclipse.as.core.util.IJBossToolingConstants; <br>
-import org.jboss.ide.eclipse.as.core.util.IWTPConstants; <br>
import
org.jboss.ide.eclipse.as.core.util.DeploymentPreferenceLoader.DeploymentModulePrefs;
<br>
import
org.jboss.ide.eclipse.as.core.util.DeploymentPreferenceLoader.DeploymentPreferences;
<br>
import
org.jboss.ide.eclipse.as.core.util.DeploymentPreferenceLoader.DeploymentTypePrefs;
<br>
+import org.jboss.ide.eclipse.as.core.util.IJBossToolingConstants; <br>
+import org.jboss.ide.eclipse.as.core.util.IWTPConstants; <br>
<br>
public class PublishUtil { <br>
public static int countChanges(IModuleResourceDelta[] deltas) { <br>
@@ -126,7 +127,11 @@ <br>
public static IPath getDeployPath(IModule[] moduleTree, String
deployFolder) { <br>
IPath root = new Path( deployFolder ); <br>
String type, modName, name, uri, suffixedName; <br>
- for( int i = 0; i < moduleTree.length; i++ ) { <br>
+ for( int i = 0; i < moduleTree.length; i++ ) { <br>
+ IJ2EEModule j2eeModule = (IJ2EEModule)
moduleTree[i].loadAdapter(IJ2EEModule.class, null); <br>
+ if (j2eeModule != null && j2eeModule.isBinary()) {
<br>
+ continue; <br>
+ } <br>
type = moduleTree[i].getModuleType().getId(); <br>
modName = moduleTree[i].getName(); <br>
name = new Path(modName).lastSegment(); <br>
Index:
jbosscore/org/jboss/ide/eclipse/as/core/publishers/JstPublisher.java <br>
=================================================================== <br>
---
jbosscore/org/jboss/ide/eclipse/as/core/publishers/JstPublisher.java
(revision 23095) <br>
+++
jbosscore/org/jboss/ide/eclipse/as/core/publishers/JstPublisher.java
(working copy) <br>
@@ -22,6 +22,7 @@ <br>
import org.eclipse.core.runtime.MultiStatus; <br>
import org.eclipse.core.runtime.Path; <br>
import org.eclipse.core.runtime.Status; <br>
+import org.eclipse.jst.server.core.IJ2EEModule; <br>
import org.eclipse.osgi.util.NLS; <br>
import org.eclipse.wst.server.core.IModule; <br>
import org.eclipse.wst.server.core.IServer; <br>
@@ -107,8 +108,13 @@ <br>
IModuleResource[] members = getResources(module); <br>
<br>
ArrayList<IStatus> list = new ArrayList<IStatus>();
<br>
+ IJ2EEModule j2eeModule = (IJ2EEModule)
module.loadAdapter(IJ2EEModule.class, null); <br>
+ boolean delete = true; <br>
+ if (j2eeModule != null && j2eeModule.isBinary()) { <br>
+ delete = false; <br>
+ } <br>
// if the module we're publishing is a project, not a binary,
clean it's folder <br>
- if( !(new Path(module.getName()).segmentCount() > 1 )) <br>
+ if( !(new Path(module.getName()).segmentCount() > 1 )
&& delete) <br>
list.addAll(Arrays.asList(localSafeDelete(deployPath))); <br>
<br>
if( !deployPackaged(moduleTree) &&
!isBinaryObject(moduleTree)) { <br>
</blockquote>
<br>
</blockquote>
<br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
jbosstools-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></pre>
</blockquote>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
jbosstools-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></pre>
</blockquote>
<br>
</body>
</html>