<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 04/23/2012 10:14 AM, Mickael Istria wrote:
<blockquote cite="mid:4F958DFD.9030700@redhat.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hello,<br>
<br>
Working on the 2 following bugs:<br>
* <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://issues.jboss.org/browse/JBIDE-11370">https://issues.jboss.org/browse/JBIDE-11370</a>
: Get all components to have tests, and get rid of the "in case
there is not test" build steps<br>
* <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://issues.jboss.org/browse/JBIDE-11600">https://issues.jboss.org/browse/JBIDE-11600</a>
: org.jboss.tools.tests.tests.UtilsTest -
java.lang.AssertionError: Not yet implemented<br>
We are trying to set up the necessary stuff to ensure all modules
can easily write tests and get them executed in their builds
without effort.<br>
<br>
The issue is that we had to create a dummy test for the tests/
modules since it did not had test before. The tests modules
provides an API to write tests for JBT/JBDS, so it makes a lot of
sense to set up some tests for this test API, which is used all
over the product. But this dummy test is too dummy. </blockquote>
At first I asked myself why would we write tests for tests. Then I
thought that might be good to have them, because they are really
utils used in tests and should be tested. The only issue I see is
test plug-in name not following the naming convention. Instead of
tests/rg.jboss.tools.tests.tests it should be
tests/org.jboss.tools.tests.test<br>
<br>
It would not too dummy if there was a reference to
org.jboss.tools.tests as a dependency in org.jboss.tests.test
manifest. It would trigger plug-in plug-in activator for
org.jboss.tools.tests and increase code coverage. test method could
be empty, but should be named as testBundleIsLoaded to show what it
is for.<br>
<br>
Denis<br>
<br>
<blockquote cite="mid:4F958DFD.9030700@redhat.com" type="cite">Looking
deeper in the content of the tests module, it looks like there are
some automated tests in the plugins/ folder, those tests are not
automatically executed at build time. This is not a clean layout
and behavior.<br>
So I am wondering: <b>what is the purpose of
org.jboss.tools.ui.bot.ext.test.config.Suite and Annotated*
class</b>? Can/Should it be used for CI testing? I tried it with
surefire and got 7 of 9 tests successful.<br>
If this can be automated, please find attached a patch containing
the necessary change to follow the "normal" layout and enable
those tests.<br>
If this is not meant to be automated, then what is this?<br>
</blockquote>
<br>
<br>
<br>
<blockquote cite="mid:4F958DFD.9030700@redhat.com" type="cite">
<div class="moz-signature">-- <br>
Mickael Istria<br>
Eclipse developer at <a moz-do-not-send="true"
href="http://www.jboss.org/tools">JBoss, by Red Hat</a><br>
<a moz-do-not-send="true"
href="http://mickaelistria.wordpress.com">My blog</a> - <a
moz-do-not-send="true" href="http://twitter.com/mickaelistria">My
Tweets</a></div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
jbosstools-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></pre>
</blockquote>
<br>
</body>
</html>