<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 09/05/2012 12:46 PM, Max Rydahl
Andersen wrote:<br>
</div>
<blockquote
cite="mid:3679F49D-9CED-4A93-9F74-E6219E755A01@redhat.com"
type="cite">
<blockquote type="cite">
<pre wrap="">On 09/05/2012 11:03 AM, Max Rydahl Andersen wrote:
</pre>
<blockquote type="cite">
<pre wrap="">What few classes exactly ? link to github ?
</pre>
</blockquote>
<pre wrap="">For the example I've just checked, only this one seems necessary: <a class="moz-txt-link-freetext" href="https://github.com/jeeeyul/eclipse-themes/blob/master/net.jeeeyul.eclipse.themes/src/net/jeeeyul/eclipse/themes/rendering/ChromeTabRendering.java">https://github.com/jeeeyul/eclipse-themes/blob/master/net.jeeeyul.eclipse.themes/src/net/jeeeyul/eclipse/themes/rendering/ChromeTabRendering.java</a>
</pre>
</blockquote>
<pre wrap="">
this class seem to depend heavily on HackedCTabRendering and themes* classes ?</pre>
</blockquote>
Yup.<br>
<br>
<blockquote
cite="mid:3679F49D-9CED-4A93-9F74-E6219E755A01@redhat.com"
type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">for me it seriously feels like overkill to start depending on an external project for something like css theming.
</pre>
</blockquote>
<pre wrap="">It also provides the nice Theme editor in preferences. But I'm not sure that's something we want to provide.
</pre>
</blockquote>
<pre wrap="">
well, I don't find it like something we would want to maintain would we ?</pre>
</blockquote>
Maintainance effort are probably very low. But we could also ask to
split the bundle into several bundles (common, renderers, editor) so
we could reuse only common and renderers.<br>
<br>
<blockquote
cite="mid:3679F49D-9CED-4A93-9F74-E6219E755A01@redhat.com"
type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Would it make sense to fork these classes instead ?
</pre>
</blockquote>
<pre wrap="">Sure we could.
</pre>
</blockquote>
<pre wrap="">
is this class something the css styles would reference as a "alternative rendering" ?
What does this one actually fix ?</pre>
</blockquote>
Yes it is.<br>
I supports some additional color parameters compared to default one
from e4. So you can have different color for text, a gradient, and
draw lines more clearly.
<blockquote
cite="mid:3679F49D-9CED-4A93-9F74-E6219E755A01@redhat.com"
type="cite">
</blockquote>
<div class="moz-signature">-- <br>
Mickael Istria<br>
Eclipse developer at <a href="http://www.jboss.org/tools">JBoss,
by Red Hat</a><br>
<a href="http://mickaelistria.wordpress.com">My blog</a> - <a
href="http://twitter.com/mickaelistria">My Tweets</a></div>
</body>
</html>