<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Thanks. I pulled the new repo and was able to run my tests - that's a good sign.<div><br><div>Also, both tests/org.jboss.tools.bpel.ui.bot.test/src/org/jboss/tools/bpel/ui/bot/ext/widgets and projects in tests/org.jboss.tools.bpel.ui.bot.test/projects/ that were missing are there now.</div><div><br></div><div>Andrej, can you please check if everything is ok? You can use my fork here <a href="git://github.com/mmalina/temp-jbosstools-integration-tests.git">git://github.com/mmalina/temp-jbosstools-integration-tests.git</a></div><div>This contains pom.xml, tests/pom.xml and also fixed parent definition for your tests/org.jboss.tools.bpel.ui.bot.test/pom.xml so it should work right away.<br><div><br><div><div>Max, there are still both master and trunk branches. Why is that?</div><div><br></div><div>Thanks,</div><div>Martin</div><div><br></div><div>On 18. 10. 2012, at 18:25, Max Rydahl Andersen <<a href="mailto:max.andersen@redhat.com">max.andersen@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br>reran the git migration for the tests with mmalinas fix plus another fix ;)<br><br><a href="https://github.com/jbosstools/temp-jbosstools-integration-tests/tree/master/tests/org.jboss.tools.ui.bot.ext/src/org/jboss/tools/ui/bot/ext/widgets">https://github.com/jbosstools/temp-jbosstools-integration-tests/tree/master/tests/org.jboss.tools.ui.bot.ext/src/org/jboss/tools/ui/bot/ext/widgets</a><br><br>now exist.<br><br>Please take it for a spin and see if anything else missing.<br><br>/max<br><br><br>On 17 Oct 2012, at 13:01, Max Rydahl Andersen <max.andersen@redhat.com> wrote:<br><br><blockquote type="cite">...and its a reminder how wrong it is to just svn rename something to signify deprecation/"oldness"<br><br>if something is not used anymore - *delete* it - dont rename it. its a SCM that has history - you can always go back and get it.<br><br>/max<br><br>On 17 Oct 2012, at 12:42, Martin Malina <mmalina@redhat.com> wrote:<br><br><blockquote type="cite">Summarizing our discussion here:<br>This should be fixed with https://github.com/maxandersen/jbosstools-gitmigration/pull/4/<br>The solution is to add the excludes to our jbosstools-integration-tests filter. Thanks catching this, Andrej! And thanks Max for seeing exactly what happened.<br><br>Long boring explanation of what happened:<br>Our filter only preserves files in _component_/_something_/*.bot*.<br>So it preserved bpel/tests/org.jboss.tools.bpel.ui.bot.test AND ALSO bpel_old/tests/org.jboss.tools.bpel.ui.bot.test .<br>But the filter also renames _component_/_something_/_random.bot.plugin_ to tests/_random.bot.plugin_.<br>So both bpel/tests/org.jboss.tools.bpel.ui.bot.test and bpel_old/tests/org.jboss.tools.bpel.ui.bot.test were renamed to tests/org.jboss.tools.bpel.ui.bot.test.<br>So basically we merged two dirs into one dir. And since the last commit in this merged dir was removing bpel_old completely, it also removed everything from this new merged dir.<br>The fix is to exclude bpel_old altogether.<br><br>-Martin<br><br>On 17. 10. 2012, at 11:28, Max Rydahl Andersen <max.andersen@redhat.com> wrote:<br><br><blockquote type="cite">....so bpel-old *was* actually used ?! wtf...<br><br>pinging you on irc....<br><br>/max<br><br>On 16 Oct 2012, at 19:38, Martin Malina <mmalina@redhat.com> wrote:<br><br><blockquote type="cite">Hi Max,<br><br>I'm resending this just to make sure it doesn't fall through. This is quite a big problem that we need to solve somehow. It seems that any file that was originally committed under some other path (not matching the regexp that we use for jbosstools-integration-tests) and then moved in svn under bot tests won't be included in the filtered git repo :(<br><br>Let's talk on irc tomorrow.<br><br>-Martin<br><br>On 16. 10. 2012, at 19:28, Martin Malina <mmalina@redhat.com> wrote:<br><br><blockquote type="cite"><br>On 16. 10. 2012, at 10:54, Andrej Podhradsky <apodhrad@redhat.com> wrote:<br><br><blockquote type="cite">I'm looking that some resources are also missing, namely<br>http://anonsvn.jboss.org/repos/jbosstools/trunk/bpel/tests/org.jboss.tools.bpel.ui.bot.test/projects/<br></blockquote><br>You are right again. It has to do something with the fact that the missing directories were forked from somewhere else.<br>Compare this:<br>https://github.com/jbosstools/jbosstools-full-svn-mirror/tree/trunk/bpel/tests/org.jboss.tools.bpel.ui.bot.test/projects<br>with<br>https://github.com/jbosstools/temp-jbosstools-integration-tests/tree/trunk/tests/org.jboss.tools.bpel.ui.bot.test/projects<br><br>On the first link you can see that all the folders that disappear in the second link have this last commit message:<br>https://github.com/jbosstools/jbosstools-full-svn-mirror/commit/b4ea72bf293ad7677a91a6b9c141d88ddcea0334<br>https://issues.jboss.org/browse/JBDS-1810 new bpel in trunk (forked from old bpel-old/ folder)<br><br>What I don't understand is that there is no commit containing the addition of the files. Because this last commit contains all these files under different filename - they must have been moved in bulk inside the bot test folder sometime later. But since there is no commit for it in git, when the fast filter filters the files in commit, it simply skips all these files :( We need to fix this.<br><br>-Martin<br><br><blockquote type="cite"><br>Andrej.<br><br>----- Original Message -----<br>From: "Andrej Podhradsky" <apodhrad@redhat.com><br>To: "Max Rydahl Andersen" <max.andersen@redhat.com><br>Cc: "jbosstools-dev jbosstools-dev" <jbosstools-dev@lists.jboss.org><br>Sent: Tuesday, October 16, 2012 10:04:18 AM<br>Subject: Re: [jbosstools-dev] [gitmigration] ACTION REQUIRED please respond back<span class="Apple-tab-span" style="white-space:pre"> </span>wether your project git repo is ok or not!<br><br>Hi Max,<br><br>in temp-jbosstools-integration-tests isn't the whole project for bpel bot tests.<br>The following folder is missing<br><br>http://anonsvn.jboss.org/repos/jbosstools/trunk/bpel/tests/org.jboss.tools.bpel.ui.bot.test/src/org/jboss/tools/bpel/ui/bot/ext/<br><br>Note that this isn't new folder, was added in 2011.<br><br>Have a nice day!<br><br>Andrej.<br><br>----- Original Message -----<br>From: "Max Rydahl Andersen" <max.andersen@redhat.com><br>To: "jbosstools-dev jbosstools-dev" <jbosstools-dev@lists.jboss.org><br>Sent: Wednesday, October 10, 2012 6:37:52 PM<br>Subject: [jbosstools-dev] [gitmigration] ACTION REQUIRED please respond back<span class="Apple-tab-span" style="white-space:pre"> </span>wether your project git repo is ok or not!<br><br>Hi,<br><br>If you have not yet taken a look at the temp-* repositories on https://github.com/jbosstools please do so ASAP <br><br>If I haven't heard back a +1 or "hey - this works great, except for this and this" for the content of the repositories by Wednesday next week (17th)<br>the git migration will be delayed/postponed *after* GA.<br><br>Thus if you want to use git *now* is the time to go help verify the content of the repositories are sane.<br><br>thank you!<br>/max<br><br><br><br>_______________________________________________<br>jbosstools-dev mailing list<br>jbosstools-dev@lists.jboss.org<br>https://lists.jboss.org/mailman/listinfo/jbosstools-dev<br>_______________________________________________<br>jbosstools-dev mailing list<br>jbosstools-dev@lists.jboss.org<br>https://lists.jboss.org/mailman/listinfo/jbosstools-dev<br>_______________________________________________<br>jbosstools-dev mailing list<br>jbosstools-dev@lists.jboss.org<br>https://lists.jboss.org/mailman/listinfo/jbosstools-dev<br></blockquote><br>--<br>Martin Malina<br>JBoss QA Engineer<br>Red Hat Czech s.r.o.<br>Purkynova 99<br>612 45 Brno, Czech Republic<br><br>Tel.: +420 532 294 265<br><br><br><br><br>_______________________________________________<br>jbosstools-dev mailing list<br>jbosstools-dev@lists.jboss.org<br>https://lists.jboss.org/mailman/listinfo/jbosstools-dev<br></blockquote><br>--<br>Martin Malina<br>JBoss QA Engineer<br>Red Hat Czech s.r.o.<br>Purkynova 99<br>612 45 Brno, Czech Republic<br><br>Tel.: +420 532 294 265<br><br><br><br><br></blockquote><br></blockquote><br>--<br>Martin Malina<br>JBoss QA Engineer<br>Red Hat Czech s.r.o.<br>Purkynova 99<br>612 45 Brno, Czech Republic<br><br>Tel.: +420 532 294 265<br><br><br><br><br></blockquote><br></blockquote><br></blockquote></div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div apple-content-edited="true"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; font-size: 12px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div>Martin Malina<br>JBoss QA Engineer<br>Red Hat Czech s.r.o.<br>Purkynova 99<br>612 45 Brno, Czech Republic<br></div><div><br></div><div><span class="Apple-style-span" style="font-size: medium; ">Tel.: +420 532 294 265</span></div><div><span class="Apple-style-span" style="font-size: medium; "><br></span></div></div></span></div></div></div></span><br class="Apple-interchange-newline"></span><br class="Apple-interchange-newline">
</div>
<br></div></div></div></body></html>