<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 14. 3. 2013, at 9:27, Max Rydahl Andersen <<a href="mailto:max.andersen@redhat.com">max.andersen@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><blockquote type="cite"><a href="https://github.com/jbosstools/jbosstools-integration-tests/pull/188">https://github.com/jbosstools/jbosstools-integration-tests/pull/188</a><br><br><br>The problem is (was) that:<br>* The ESB tests require the ESB UI which requires Zest - tests build fails on master for 7.0<br>* Zest is not in the JBT test package, but it is in the JBTIS test package<br></blockquote><br>we probably need Zest for other reasons anyway so that probably makes sense to add to core TP anyway.<br></blockquote><div><br></div><div>ok, so one problem will be solved. but spliting the repos make sense anyway imo.</div><br><blockquote type="cite"><blockquote type="cite">* Adding JBTIS TP repo to our root pom in integration-tests would affect all our tests:<br></blockquote><br><blockquote type="cite">-> The tests would run slower<br></blockquote><br>Hopefully not...did you see a big effect ?<br></blockquote><div><br></div><div>It's more of a theoretical possibility - I think it was you who raised this concern in the past - that each new repo that is searched in a build introduces more complexity for resolving of the dependencies</div><div><br></div><blockquote type="cite"><blockquote type="cite">-> The JBTIS test package might affect our tests - we might miss issues of plugins not being in the JBT test package<br></blockquote><br>not following what you mean here ? if JBTIS test package does affect your test we want to know about it ;)<br></blockquote><div><br></div><div>The core integration tests should be able to resolve all dependencies from the JBT core TP and update site - we're trying to emulate the usual use case when somebody installs JBT core - they won't have JBTIS update site available.</div><div>So if we add JBTIS update site for all tests we might miss some problem - a missing dependency on the core update site. Sure, this would probably be picked up by a failing build of a component, but even so, I think it's cleaner if we just use the intended update sites (core TP and core update site for core tests).</div><br><blockquote type="cite">That said you should be using JBTIS since that is where the esb plugins are. Can't just use jbosstools core as base for this.<br></blockquote><div><br></div>Sure, that's why it would be good for JBTIS integration tests to be separate - they need to use JBTIS TP and update site.</div><div><br><blockquote type="cite"><blockquote type="cite">So - what are the solutions?<br></blockquote><br>Split out the github repository and move the integration-platform tests to a separate repo.<br></blockquote><div><br></div>+1</div><div><br><blockquote type="cite"><blockquote type="cite">Second, long-term<br>* We had talked about this in the past - creating a new SOA test repo<br></blockquote><br>integration-test repo - its no longer just SOA.<br></blockquote><div><br></div><div>We tend to say "soa integration tests" because integration stack integration tests is even more confusing. Do you have a better suggestion here? :)</div><br><blockquote type="cite"><blockquote type="cite">-> The SOA 6 tests will be affected (remember that the ESB examples are still not configured here with JBTIS)<br></blockquote><br>jira ?<br></blockquote><div><br></div>Not sure exactly what Len meant here. I think they will be mainly affected by the move to a new repo itself.</div><div><br><blockquote type="cite"><blockquote type="cite">-> This will mean that existing 4.0.x work would move to the new repo<br></blockquote><br>you'll need to migrate the history very carefully yes.<br></blockquote><div><br></div><div>Yeah, another exercise for filter-branch/fast-filter I guess.</div><div><br></div><div>-Martin</div><br><blockquote type="cite"><blockquote type="cite">-> Everyone using the SOA tests will have to adapt<br>-> What else can go wrong?<br>Need to tell Drools tests - BRMS team - Lukas Petroviky<br>- the BRMS team has no one to do the testing at the moment.<br></blockquote><br>/max<br><br>_______________________________________________<br>jbosstools-dev mailing list<br><a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/jbosstools-dev<br></blockquote></div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div apple-content-edited="true"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; font-size: 12px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div>Martin Malina<br>JBoss QA Engineer<br>Red Hat Czech s.r.o.<br>Purkynova 99<br>612 45 Brno, Czech Republic<br></div><div><br></div><div><span class="Apple-style-span" style="font-size: medium; ">Tel.: +420 532 294 265</span></div><div><span class="Apple-style-span" style="font-size: medium; "><br></span></div></div></span></div></div></div></span><br class="Apple-interchange-newline"></span><br class="Apple-interchange-newline">
</div>
<br></body></html>