<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">I suggested a different patch that
ensures that GlobalUsageSettingsTest is restoring the usage
enablement after each test (the test is modyfining it).<br>
<br>
filed a PR at
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="https://github.com/jbosstools/jbosstools-base/pull/76">https://github.com/jbosstools/jbosstools-base/pull/76</a><br>
<br>
<br>
On 04/05/2013 11:33 PM, Snjezana Peco wrote:<br>
</div>
<blockquote cite="mid:515F4325.2020200@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">> Furthermore I can run those
(even without flag, just by 'mvn clean verify') locally <br>
<br>
The -Dusage_reporting_enabled=false flag is set in the parent
pom for all JBT tests. <br>
It helps for all the tests except for the usage tests on
Linux/Kepler M6.<br>
<br>
Try to create parent pom that doesn't set this flag. You will be
able to reproduce the issue on Windows too.<br>
<br>
On 4/5/2013 11:07 PM, André Dietisheim wrote:<br>
</div>
<blockquote cite="mid:515F3D06.1050508@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 04/05/2013 10:08 PM, Snjezana
Peco wrote:<br>
</div>
<blockquote cite="mid:515F2F23.9040707@redhat.com" type="cite">A
test doesn't have to be an UI test to open the
UsageReportEnablementDialog dialog. <br>
The dialog is created using the startup extension point.
That's why the usage plugin will always try to open this
dialog. <br>
<br>
</blockquote>
<br>
hmm, I looked at the patch and the test. To me the integration
test is using fakes and I therefore dont see where the test
would trigger the dialog. <br>
</blockquote>
<br>
The usage plugin triggers the dialog using the
org.eclipse.ui.startup extension point.<br>
<br>
<blockquote cite="mid:515F3D06.1050508@redhat.com" type="cite"> I
tend to think that the Eclipse runtime that is running the test
has the plugin installed and opens the dialog independently of
the tests. Thus I thinking that the flag (
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
-
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Dusage_reporting_enabled=false) is not working properly? Or some
similar explanation... wrong?<br>
<br>
</blockquote>
<br>
The flag works properly. I have debugged the usage tests. The flag
is false before starting the usage tests and true after finishing
them. Kepler M6 runs the tests and, after that, calls the dialog.<br>
The patch fixes the issue by resetting the flag after finishing
the tests and before calling the dialog.<br>
<br>
Snjeza<br>
<br>
<blockquote cite="mid:515F3D06.1050508@redhat.com" type="cite">
<blockquote cite="mid:515F2F23.9040707@redhat.com" type="cite">The
issue can't be reproduced on Windows. It can always be
reproduced on Linux when using Kepler M6. Not sure for Mac. <br>
<br>
The issue isn't caused by changes in usage/JBT, but in Kepler
M6. <br>
<br>
Snjeza <br>
<br>
On 4/5/2013 9:28 PM, André Dietisheim wrote: <br>
<blockquote type="cite">On 04/05/2013 09:00 PM, Nick Boldt
wrote: <br>
<blockquote type="cite">Isn't there a commandline flag to
suppress that so that the test DOES <br>
NOT block until timeout? <br>
</blockquote>
<br>
As far as I can say the flag is only suppressing the usage
in SWTBot-Test where a UI is actually run. The usage test
are not running UI, thus the flag has no effect on them.
Furthermore I can run those (even without flag, just by 'mvn
clean verify') locally and they run perfectly smooth. <br>
<br>
[INFO] usage.tests .......................................
SUCCESS [0.004s] <br>
[INFO] org.jboss.tools.usage.test ........................
SUCCESS [10.156s] <br>
<br>
There was 0 change in usage since Alpha1 (and even before)
so I wonder why this should now fail? <br>
I have to test with Kepler TP though. <br>
<br>
<br>
On 04/05/2013 02:56 PM, Snjezana Peco wrote: <br>
<blockquote type="cite">
<blockquote type="cite">Yes, they do. <br>
<br>
Snjeza <br>
<br>
On 4/5/2013 8:41 PM, Nick Boldt wrote: <br>
<blockquote type="cite">Do the usage tests involve
waiting for a user to click the dialog <br>
asking if it's OK to collect anonymous usage stats? <br>
<br>
N <br>
<br>
On 04/05/2013 02:19 PM, Snjezana Peco wrote: <br>
<blockquote type="cite">See <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://issues.jboss.org/browse/JBIDE-13939">https://issues.jboss.org/browse/JBIDE-13939</a>
and <br>
<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JBossTools/view/JBossTools_Trunk/job/jbosstools-base_master/220/console">https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JBossTools/view/JBossTools_Trunk/job/jbosstools-base_master/220/console</a>
<br>
<br>
<br>
<br>
The usage tests take 1.02 sec, but freeze. <br>
<br>
Snjeza <br>
<br>
On 4/3/2013 9:33 PM, Snjezana Peco wrote: <br>
<blockquote type="cite">I have created JBIDE-13908,
JBIDE-13910, JBIDE-13911 and reopened <br>
JBIDE-13733. They are related to tests. <br>
<br>
Snjeza <br>
<br>
On 4/3/2013 6:30 PM, Nick Boldt wrote: <br>
<blockquote type="cite">As code freeze is
tomorrow, it's that time of the month where I <br>
have the <br>
pleasure of sending reminder note that if your
job is red or yellow, <br>
*you need to fix your tests*. <br>
<br>
Here are today's failures. You'll note that
they've all been <br>
failing for <br>
about a week. <br>
<br>
== RED == <br>
<br>
Base: Failing tests since Mar 24 <br>
<br>
Forge: 2 test failures, 8 skipped tests since
Mar 24 <br>
<br>
Hibernate: COMPILATION FAILURES since ??? (last
good build on Feb 18) <br>
<br>
JavaEE: 7 test failures since Mar 31; 11 test
failures since Mar 21 <br>
<br>
== YELLOW == <br>
<br>
Central: 1-2 test failures since Apr 1 <br>
<br>
JST: 20+ test failures since Mar 28 <br>
<br>
Web Services: 917 test failures since Mar 24 <br>
<br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>