<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 04/11/2013 12:52 PM, Max Rydahl
Andersen wrote:<br>
</div>
<blockquote cite="mid:20130411105247.GM9208@slowbeard.local"
type="cite">Got any examples of this xml ?
<br>
</blockquote>
<br>
Here are some examples of xml (drafts):<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="https://www.dropbox.com/s/swn1mmrhktev8mx/JBossAS71.xml">https://www.dropbox.com/s/swn1mmrhktev8mx/JBossAS71.xml</a><br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="https://www.dropbox.com/s/19802tauw279sd2/JBossEAP60.xml">https://www.dropbox.com/s/19802tauw279sd2/JBossEAP60.xml</a><br>
<br>
<blockquote cite="mid:20130411105247.GM9208@slowbeard.local"
type="cite">
<br>
First instinct input:
<br>
<br>
Why do we have hard coded EAP and AS names in here?
<br>
<br>
AS is not going to be called AS much longer.
<br>
EAP is just one of many.
<br>
</blockquote>
<br>
The names are derived from the server adapter labels as seen in
'eclipse/new server' wizard.<br>
<br>
I intentionally hard coded server versions and names to the xsd
file, because I wanted to have some kind of validation on entry
phase - that means that this will be automatically validated when
first reading the xml configuration. Only valid combinations will be
accepted (e.g. combination of EAP in version 3.2 will not be
validated) I don't argue that this can't be handled on higher level
(for instance when there is no EAP server adapter for version 3.2,
we will get WidgetNotFoundException). <br>
<br>
And I like the idea that the xsd describes a valid xml requirement
and a user can see what is valid and supported on a first glance.<br>
<br>
<blockquote cite="mid:20130411105247.GM9208@slowbeard.local"
type="cite">
<br>
What about tomcat, jetty, fusion and other server/runtimes.
<br>
<br>
The design seems very limited in that context.
<br>
<br>
Secondly, I do no think this should be isolated to reddeer/swtbot
<br>
based tests. We already have multiple mutations of this.
<br>
</blockquote>
<br>
Red Deer was designed as a general testing framework for eclipse
with multiple modules. And the idea was that if there is some kind
of "industry" specific requirement, then an extension to reddeer
will be written - but 'project reddeer' don't care.<br>
<br>
As we have jboss specific server requirements (now we stand on the
industry side, not on the reddeer project side) we decided to
implement a reddeer extension for jboss server requirements: that is
the package org.jboss.ide.eclipse.as.reddeer in
jbosstools-integration-tests repository. And this is a reddeer
extension only for jboss products, that's why there is no tomcat and
so on. <br>
<br>
Besides that, this requirements operate on jboss server adapter UI
wizards when setting up a server for the test. (and tomcat has a
slightly different wizards as far as I know) - that's the other
reason why is this not meant to be for tomcat, jetty etc. <br>
<br>
For tomcat, jetty, fusion and so on we could write several other
redder extensions which would support also theirs respective UI
server wizards.<br>
<br>
I agree with you that we should not limit this just to swtbot based
tests. But I'd like to limit this to<br>
JBoss products (not tomcat etc) because of the swtbot based tests.<br>
<br>
<br>
-Pavol.<br>
<br>
<blockquote cite="mid:20130411105247.GM9208@slowbeard.local"
type="cite">
<br>
/max
<br>
<br>
On Thu, Apr 11, 2013 at 12:19:18PM +0200, Pavol Srna wrote:
<br>
<blockquote type="cite">Hi Max,
<br>
<br>
the idea behind this is to have some new mechanism for server
requirements similar as it was
<br>
in org.jboss.tools.ui.bot.ext [1]. But we need to rewrite and
redesign it using reddeer. The new server requirements will be
based on xml (not on property files as it was in [1])
<br>
<br>
I designed xsd file here [2] which describes how such a
requirement should look like.
<br>
When ready it will let us annotate our test classes with
'@Server' annotation and the framework
<br>
will setup server adapter automatically in eclipse.
<br>
<br>
<br>
On 04/11/2013 10:57 AM, Max Rydahl Andersen wrote:
<br>
<blockquote type="cite">What is
<a class="moz-txt-link-freetext" href="http://www.jboss.org/NS/ServerReq">http://www.jboss.org/NS/ServerReq</a> ? why are we using a global
namespace location for reddeer xml configurations ?
<br>
<br>
</blockquote>
<br>
<a class="moz-txt-link-freetext" href="http://www.jboss.org/NS/ServerReq">http://www.jboss.org/NS/ServerReq</a> should be a namespace for
*jboss* server requirements. This is jboss specific (not reddeer
specific) and the code lives in jbosstools-integration-tests
repo.
<br>
<br>
If it's wrong ok, we can change it easily. Any suggestion?
<br>
<br>
<blockquote type="cite">I assume this is some xml we use to
define server runtimes - how does this relate to the many
other server runtime definitions
<br>
that exists ? Is this a format we can use with other things ?
if yes - awesome. tell more.
<br>
</blockquote>
<br>
The main intent is to use it in UI tests (the fullfill method
[3] should setup server adapter through UI), but we can think
about how to use it with pure junit tests as well.
<br>
<br>
<br>
[1] <a class="moz-txt-link-freetext" href="https://docspace.corp.redhat.com/docs/DOC-38528">https://docspace.corp.redhat.com/docs/DOC-38528</a>
<br>
[2]
<a class="moz-txt-link-freetext" href="https://github.com/jbosstools/jbosstools-integration-tests/blob/master/tests/org.jboss.ide.eclipse.as.reddeer/resources/ServerRequirements.xsd">https://github.com/jbosstools/jbosstools-integration-tests/blob/master/tests/org.jboss.ide.eclipse.as.reddeer/resources/ServerRequirements.xsd</a><br>
[3]
<a class="moz-txt-link-freetext" href="https://github.com/jbosstools/jbosstools-integration-tests/blob/master/tests/org.jboss.ide.eclipse.as.reddeer/src/org/jboss/ide/eclipse/as/reddeer/server/requirement/ServerRequirement.java">https://github.com/jbosstools/jbosstools-integration-tests/blob/master/tests/org.jboss.ide.eclipse.as.reddeer/src/org/jboss/ide/eclipse/as/reddeer/server/requirement/ServerRequirement.java</a><br>
<br>
-Pavol.
<br>
<br>
-- <br>
Pavol Srna
<br>
QA Engineer, JBDS
<br>
Phone: +420 532 294 352
<br>
irc: psrna
<br>
<br>
Red Hat Czech
<br>
Purkynova 99, 612 00 Brno, Czech Republic
<br>
<br>
</blockquote>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Pavol Srna
QA Engineer, JBDS
Phone: +420 532 294 352
irc: psrna
Red Hat Czech
Purkynova 99, 612 00 Brno, Czech Republic </pre>
</body>
</html>