<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>You did not have to rebuild all of jbosstools - just rebuild the parts that are most dependent on it. In this case central. </div><div><br></div><div>Anyway - onwards to find a proper way to get stacks decoupled. </div><div><br>/max (sent from my phone)<div><br></div></div><div><br>On 30/04/2013, at 09.43, Rob Stryker <<a href="mailto:rstryker@redhat.com">rstryker@redhat.com</a>> wrote:<br><br></div><blockquote type="cite"><div>
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div class="moz-cite-prefix">Reverting the patch was the correct
solution. <br>
<br>
It is not always possible to rebuild *all* dependent components
locally and run the test suites. That's what Jenkins is for. It'd
take a very long time. I *did* rebuild all of base and run its
tests though. Reverting the fix is the best solution there is.
It's a smack in the face to the committer (me), which alerts me to
fix my problem, and it also gets MASTER back in shape as fast as
possible. <br>
<br>
I take full blame for the issue of course, but I do feel that
asking me to build all of jbt before committing is a bit much. I
should have just taken more time to review the change. <br>
<br>
In the future, also re-open whichever jira was the one that caused
the error. You can see it in the commit log. <br>
<br>
Anyway, good work team. ... well, everyone except me ;) <br>
<br>
On 04/27/2013 01:05 PM, Alexey Kazakov wrote:<br>
</div>
<blockquote cite="mid:517B5C84.5040904@exadel.com" type="cite">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div class="moz-cite-prefix">On 04/26/2013 08:07 PM, Max Andersen
wrote:<br>
</div>
<blockquote cite="mid:6CC44868-844C-46B9-92FD-AC0EDD70BE21@redhat.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<div>Alexey,</div>
<div><br>
</div>
<div>That sucks and should not happen. In such cases its ok to
revert that commit and reopen the PR. I can't do it right now
since I'm on the road. Feel free to do it. <br>
</div>
</blockquote>
Done.<br>
<br>
<br>
<br>
<br>
<br>
<blockquote cite="mid:6CC44868-844C-46B9-92FD-AC0EDD70BE21@redhat.com" type="cite">
<div><br>
/max (sent from my phone)
<div><br>
</div>
</div>
<div><br>
On 26/04/2013, at 22.22, Alexey Kazakov <<a moz-do-not-send="true" href="mailto:akazakov@exadel.com">akazakov@exadel.com</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Guys, if you change any common code then please make sure
that all the dependent components are built locally w/o
errors before pushing PRs to the upstream repo.<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
It seems that <a moz-do-not-send="true" href="https://github.com/jbosstools/jbosstools-base/pull/93">https://github.com/jbosstools/jbosstools-base/pull/93</a>
broke central: <a moz-do-not-send="true" href="https://issues.jboss.org/browse/JBIDE-14327">https://issues.jboss.org/browse/JBIDE-14327</a>
</div>
</blockquote>
<blockquote type="cite">
<div><span>_______________________________________________</span><br>
<span>jbosstools-dev mailing list</span><br>
<span><a moz-do-not-send="true" href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a></span><br>
<span><a moz-do-not-send="true" href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></span></div>
</blockquote>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
jbosstools-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></pre>
</blockquote>
<br>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>jbosstools-dev mailing list</span><br><span><a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></span></div></blockquote></body></html>