<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 05/09/2013 02:51 AM, Rob Stryker
wrote:<br>
</div>
<blockquote cite="mid:518B7193.3010405@redhat.com" type="cite">
<pre wrap="">Hey All:
When browsing code, I found something very interesting and dangerous.
The wait job inside ECFTransport is not a safe implementation. It seems
there's an upstream eclipse issue on join() which was a workaround for
UI deadlocks but makes a join() not able to be interrupted.</pre>
</blockquote>
It seems not really big issue because it is not common case, there
are just two requests since
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
2009-10-26 one is yours.<br>
Where do you need this this case to be working inside JBossTools? <br>
<br>
Thanks<br>
Denis<br>
<blockquote cite="mid:518B7193.3010405@redhat.com" type="cite">
<pre wrap="">
You can read more on the eclipse bug:
<a class="moz-txt-link-freetext" href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=293312">https://bugs.eclipse.org/bugs/show_bug.cgi?id=293312</a>
Any time your code uses Join, you should pay extra attention as to who
can interrupt you, for what reason, or not. If join() is not able to be
interrupted, and the job you join against freezes, both threads may be
deadlocked forever. Stopping the job will NOT un-lock your job OR the
joined thread, either, unless your job overrides the canceling() method
to interrupt itself!
So be aware.
My new implementation of WaitJob is here below:
<a class="moz-txt-link-freetext" href="https://github.com/jbosstools/jbosstools-base/blob/master/common/plugins/org.jboss.tools.common.core/src/org/jboss/tools/common/core/ecf/internal/WaitJob.java">https://github.com/jbosstools/jbosstools-base/blob/master/common/plugins/org.jboss.tools.common.core/src/org/jboss/tools/common/core/ecf/internal/WaitJob.java</a>
_______________________________________________
jbosstools-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>