<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Fred!<br>
<br>
I merged your PR.<br>
<br>
I think that the second proposed solution is better because it
doesn't evolve any respin with a fix and the result as I understood
is the same. Do you agree ?<br>
<br>
<div class="moz-cite-prefix">Em 02/12/13 16:28, Fred Bricon
escreveu:<br>
</div>
<blockquote cite="mid:529CD151.6050102@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Thanks Rafael, that fixed the main
issue. However, the essential dependencies are incorrect, here's
a PR fixing them : <a moz-do-not-send="true"
href="https://github.com/jboss-jdf/jdf-stack/pull/28">https://github.com/jboss-jdf/jdf-stack/pull/28</a>
<br>
<br>
Now this lead me to find a severe issue in JBoss Central (<a
moz-do-not-send="true"
href="https://issues.jboss.org/browse/JBIDE-16170">https://issues.jboss.org/browse/JBIDE-16170</a>),
where we display a warning about these missing dependencies only
if the user selects an enterprise runtime which is really really
bad.<br>
<br>
We have 2 solutions :<br>
- respin JBT/JBDS for GA with a fix<br>
- make stacks.yaml point at the old html5 archetype, with a <span
class="nv" style="color: teal; font-family: Consolas,
'Liberation Mono', Courier, monospace; font-size: 12px;
font-style: normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 18px; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: pre; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255,
255, 255);">target</span><span class="p-Indicator"
style="color: rgb(51, 51, 51); font-family: Consolas,
'Liberation Mono', Courier, monospace; font-size: 12px;
font-style: normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 18px; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: pre; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255,
255, 255);">:</span><span style="color: rgb(51, 51, 51);
font-family: Consolas, 'Liberation Mono', Courier, monospace;
font-size: 12px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height:
18px; orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: pre; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); display: inline
!important; float: none;"> </span><span class="nv"
style="color: teal; font-family: Consolas, 'Liberation Mono',
Courier, monospace; font-size: 12px; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: 18px; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space: pre;
widows: auto; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255);">community</span>
label, effectively using a different archetype if a
non-enterprise runtime is selected.<br>
<br>
WDYT?<br>
<br>
Fred<br>
<br>
<br>
<br>
Le 29/11/2013 21:14, Rafael Benevides a écrit :<br>
</div>
<blockquote cite="mid:5298F5A5.6010003@redhat.com" type="cite">I
hope this commit fixes the issues: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://github.com/jboss-jdf/jdf-stack/commit/49134b900">https://github.com/jboss-jdf/jdf-stack/commit/49134b900</a>
<br>
<br>
Please, let me know of any additional issues. <br>
<br>
Thanks for the report. <br>
<br>
Em 29/11/13 15:26, Fred Bricon escreveu: <br>
<blockquote type="cite">2 issues were introduced in JBoss
Central with the latest stacks.yaml <br>
update : <br>
<br>
- 2 archetype versions use the same html5-mobile tag :
2.4.0.Final and <br>
2.4.0-build-1. But JBT, using <br>
org.apache.maven.artifact.versioning.ComparableVersion, finds
<br>
2.4.0-build-1 is higher than 2.4.0.Final and uses it as the
most recent <br>
version. Since 2.4.0-build-1 dependencies haven't been
released as part <br>
of WFK 2.4, the generated project fails to build because of
missing <br>
deps. lastWFKArchetypeRelease should be updated to 2.4.0.Final
in <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://github.com/jboss-jdf/jdf-stack/blob/1.0.0.Final/stacks.yaml">https://github.com/jboss-jdf/jdf-stack/blob/1.0.0.Final/stacks.yaml</a>
<br>
<br>
- There's a blank html5 archetype, pointing at the non-blank
one, which <br>
makes JBoss Central wizards to enable a useless 'use blank'
checkbox. <br>
Why keep it referenced? <br>
<br>
Fred <br>
<br>
_______________________________________________ <br>
jdf-dev mailing list <br>
<a moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:jdf-dev@lists.jboss.org">jdf-dev@lists.jboss.org</a>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://lists.jboss.org/mailman/listinfo/jdf-dev">https://lists.jboss.org/mailman/listinfo/jdf-dev</a>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>