<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 10/21/2014 07:09 PM, Alexey Kazakov
wrote:<br>
</div>
<blockquote cite="mid:54469338.4070207@exadel.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 10/21/2014 06:20 AM, Mickael
Istria wrote:<br>
</div>
<blockquote cite="mid:54465D8E.2090600@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 10/21/2014 03:12 AM, Alexey
Kazakov wrote:<br>
</div>
<blockquote cite="mid:5445B2F3.3040806@exadel.com" type="cite">
<pre wrap="">base, jst, javaee - done.
So, jbosstools-4.2.x is now open for 4.2.1 development, correct?
</pre>
</blockquote>
Yes, it should be good to go.<br>
But changes on this branch should really be associated to jira
entries targeting 4.2.1, use and link pull requests, and get a
positive review before merging.<br>
</blockquote>
<br>
Are you saying I have to get the PR approved by Max, Denis or Fred
before I can merge it to 4.2.x for JBT 4.2.1?<br>
</blockquote>
I think that the Jira needs to be at least considered as important
enough to require a change in 4.2.x.<br>
About the PR, the better seems to be that you get it reviewed by
someone else who has good understanding of the code, so that there
are more chances reviewer catches actual issues.<br>
<div class="moz-signature">-- <br>
Mickael Istria<br>
Eclipse developer at <a href="http://www.jboss.org/tools">JBoss,
by Red Hat</a><br>
<a href="http://mickaelistria.wordpress.com">My blog</a> - <a
href="http://twitter.com/mickaelistria">My Tweets</a></div>
</body>
</html>