<div dir="ltr"><div>i tested full build yesterday and only javaee requires to update some features (see <a href="https://github.com/jbosstools/jbosstools-javaee/pull/339">https://github.com/jbosstools/jbosstools-javaee/pull/339</a>) Everything else is fine.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 22, 2015 at 9:05 AM, Max Rydahl Andersen <span dir="ltr"><<a href="mailto:manderse@redhat.com" target="_blank">manderse@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Your junit tests does not use anything that requires junit 4 ?<br>
<br>
You should at least set the minimum boundary.<br>
<br>
/max<br>
<a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a><br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> On 22 May 2015, at 17:17, George Gastaldi <<a href="mailto:ggastald@redhat.com">ggastald@redhat.com</a>> wrote:<br>
><br>
> Another hint as Nick proposed is to remove the JUnit version constraint.<br>
> I'm doing that for Forge<br>
><br>
>> On 05/22/2015 12:16 PM, Nick Boldt wrote:<br>
>> Some PRs to consider, which fix MANIFEST.MF and feature.xml files to<br>
>> depend on 4.12.0 instead of 3.8.x:<br>
>><br>
>> <a href="https://github.com/jbosstools/jbosstools-forge/pull/140" target="_blank">https://github.com/jbosstools/jbosstools-forge/pull/140</a><br>
>> <a href="https://github.com/jbosstools/jbosstools-vpe/pull/311" target="_blank">https://github.com/jbosstools/jbosstools-vpe/pull/311</a><br>
>> <a href="https://github.com/jbosstools/jbosstools-portlet/pull/33" target="_blank">https://github.com/jbosstools/jbosstools-portlet/pull/33</a><br>
>> <a href="https://github.com/jbosstools/jbosstools-jst/pull/487" target="_blank">https://github.com/jbosstools/jbosstools-jst/pull/487</a><br>
>> <a href="https://github.com/jbosstools/jbosstools-javaee/pull/340" target="_blank">https://github.com/jbosstools/jbosstools-javaee/pull/340</a><br>
>> <a href="https://github.com/jbosstools/jbosstools-hibernate/pull/73" target="_blank">https://github.com/jbosstools/jbosstools-hibernate/pull/73</a><br>
>> <a href="https://github.com/jbosstools/jbosstools-bpel/pull/25" target="_blank">https://github.com/jbosstools/jbosstools-bpel/pull/25</a><br>
>> <a href="https://github.com/jbosstools/jbosstools-base/pull/407" target="_blank">https://github.com/jbosstools/jbosstools-base/pull/407</a><br>
>><br>
>> I've omitted changing anything in poms that declare a MAVEN dependency<br>
>> to JUnit 3.8, since that should still be resolved by Maven (not by p2).<br>
>><br>
>> Lookin' at you, Central (Maven), JavaEE (CDI & JSF), and VPE.<br>
>><br>
>>> On 05/21/2015 09:20 PM, Nick Boldt wrote:<br>
>>> The following projects have plugins or features which depend on JUnit 3.8.<br>
>>><br>
>>> Can they be changed to use JUnit 4.12, which is the version included in<br>
>>> the latest 4.50.0.Beta1-SNAPSHOT target platform and Mars M7?<br>
>>><br>
>>> * base<br>
>>> * bpel<br>
>>> * central<br>
>>> * forge<br>
>>> * hibernate<br>
>>> * javaee<br>
>>> * jst<br>
>>> * portlet<br>
>>> * vpe<br>
>>><br>
>>> Or do we need to find a way to include JUnit 3.8 as well as JUnit 4.12?<br>
>>><br>
>>> Details here: <a href="https://issues.jboss.org/browse/JBIDE-19836" target="_blank">https://issues.jboss.org/browse/JBIDE-19836</a><br>
><br>
> _______________________________________________<br>
> jbosstools-dev mailing list<br>
> <a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
<br>
_______________________________________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
</div></div></blockquote></div><br></div>