<div dir="ltr">You are correct, I did not. But error you mention is exactly what I have fixed :)<div>But you probably right about migration to exact version of JUnit, because if we declare range [3.8.0,5.0.0) for instance, it means we have to in some way check 3.8.0 works as well, since we are not going to do that lets move up to [4.12.0, 5.0.0) or even to open range starting from 4.12.0.</div><div><br></div><div>Denis</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 22, 2015 at 9:30 AM, Nick Boldt <span dir="ltr"><<a href="mailto:nboldt@redhat.com" target="_blank">nboldt@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You must not have run all the tests. coretests failed in Jenkins with<br>
this error:<br>
<br>
[ERROR] Missing requirement:<br>
org.jboss.tools.batch.test.feature.feature.group<br>
1.7.0.Beta1-v20150520-2011-B779 requires 'org.junit [3.8.1,4.0.0)' but<br>
it could not be found<br>
<br>
<a href="https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.coretests-site_master/4370/console" target="_blank">https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.coretests-site_master/4370/console</a><br>
<br>
Everything else is NOT fine. :D<br>
<span class=""><br>
On 05/22/2015 12:09 PM, Denis Golovin wrote:<br>
> i tested full build yesterday and only javaee requires to update some<br>
> features (see <a href="https://github.com/jbosstools/jbosstools-javaee/pull/339" target="_blank">https://github.com/jbosstools/jbosstools-javaee/pull/339</a>)<br>
> Everything else is fine.<br>
><br>
> On Fri, May 22, 2015 at 9:05 AM, Max Rydahl Andersen<br>
</span><span class="">> <<a href="mailto:manderse@redhat.com">manderse@redhat.com</a> <mailto:<a href="mailto:manderse@redhat.com">manderse@redhat.com</a>>> wrote:<br>
><br>
> Your junit tests does not use anything that requires junit 4 ?<br>
><br>
> You should at least set the minimum boundary.<br>
><br>
> /max<br>
> <a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a><br>
><br>
><br>
> > On 22 May 2015, at 17:17, George Gastaldi <<a href="mailto:ggastald@redhat.com">ggastald@redhat.com</a><br>
</span><div><div class="h5">> <mailto:<a href="mailto:ggastald@redhat.com">ggastald@redhat.com</a>>> wrote:<br>
> ><br>
> > Another hint as Nick proposed is to remove the JUnit version<br>
> constraint.<br>
> > I'm doing that for Forge<br>
> ><br>
> >> On 05/22/2015 12:16 PM, Nick Boldt wrote:<br>
> >> Some PRs to consider, which fix MANIFEST.MF and feature.xml files to<br>
> >> depend on 4.12.0 instead of 3.8.x:<br>
> >><br>
> >> <a href="https://github.com/jbosstools/jbosstools-forge/pull/140" target="_blank">https://github.com/jbosstools/jbosstools-forge/pull/140</a><br>
> >> <a href="https://github.com/jbosstools/jbosstools-vpe/pull/311" target="_blank">https://github.com/jbosstools/jbosstools-vpe/pull/311</a><br>
> >> <a href="https://github.com/jbosstools/jbosstools-portlet/pull/33" target="_blank">https://github.com/jbosstools/jbosstools-portlet/pull/33</a><br>
> >> <a href="https://github.com/jbosstools/jbosstools-jst/pull/487" target="_blank">https://github.com/jbosstools/jbosstools-jst/pull/487</a><br>
> >> <a href="https://github.com/jbosstools/jbosstools-javaee/pull/340" target="_blank">https://github.com/jbosstools/jbosstools-javaee/pull/340</a><br>
> >> <a href="https://github.com/jbosstools/jbosstools-hibernate/pull/73" target="_blank">https://github.com/jbosstools/jbosstools-hibernate/pull/73</a><br>
> >> <a href="https://github.com/jbosstools/jbosstools-bpel/pull/25" target="_blank">https://github.com/jbosstools/jbosstools-bpel/pull/25</a><br>
> >> <a href="https://github.com/jbosstools/jbosstools-base/pull/407" target="_blank">https://github.com/jbosstools/jbosstools-base/pull/407</a><br>
> >><br>
> >> I've omitted changing anything in poms that declare a MAVEN<br>
> dependency<br>
> >> to JUnit 3.8, since that should still be resolved by Maven (not<br>
> by p2).<br>
> >><br>
> >> Lookin' at you, Central (Maven), JavaEE (CDI & JSF), and VPE.<br>
> >><br>
> >>> On 05/21/2015 09:20 PM, Nick Boldt wrote:<br>
> >>> The following projects have plugins or features which depend on<br>
> JUnit 3.8.<br>
> >>><br>
> >>> Can they be changed to use JUnit 4.12, which is the version<br>
> included in<br>
> >>> the latest 4.50.0.Beta1-SNAPSHOT target platform and Mars M7?<br>
> >>><br>
> >>> * base<br>
> >>> * bpel<br>
> >>> * central<br>
> >>> * forge<br>
> >>> * hibernate<br>
> >>> * javaee<br>
> >>> * jst<br>
> >>> * portlet<br>
> >>> * vpe<br>
> >>><br>
> >>> Or do we need to find a way to include JUnit 3.8 as well as<br>
> JUnit 4.12?<br>
> >>><br>
> >>> Details here: <a href="https://issues.jboss.org/browse/JBIDE-19836" target="_blank">https://issues.jboss.org/browse/JBIDE-19836</a><br>
> ><br>
> > _______________________________________________<br>
> > jbosstools-dev mailing list<br>
> > <a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>
</div></div>> <mailto:<a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>><br>
<span class="">> > <a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
><br>
> _______________________________________________<br>
> jbosstools-dev mailing list<br>
</span>> <a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a> <mailto:<a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>><br>
<span class="im HOEnZb">> <a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> jbosstools-dev mailing list<br>
> <a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
><br>
<br>
</span><span class="im HOEnZb">--<br>
Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools & Dev Studio<br>
<a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a><br>
</span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
</div></div></blockquote></div><br></div>