<div dir="ltr">I did update for jetty 9.2.10 in tests to fix test errors, but new version was introduced by this commit <a href="https://github.com/jbosstools/jbosstools-target-platforms/commit/da4aeb27d8941ff4196d18f561713737836513d2">https://github.com/jbosstools/jbosstools-target-platforms/commit/da4aeb27d8941ff4196d18f561713737836513d2</a>. <div><br></div><div>Not sure what happened with jetty mirroring, but probably the mirror was done from jetty p2 repo, which had newer version than mars M7 release.</div><div><br></div><div>This difference between versions in mars and jbt tp and the fact help in eclipse lock down to jetty 9.2.9 leads to both included into jbds installer.</div><div><br></div><div>jetty bundles are not singletons and that fact we have two versions at the same time should not be a problem., eclipse help will still use 9.2.9 and we will use 9.2.10.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 21, 2015 at 5:53 AM, Max Rydahl Andersen <span dir="ltr"><<a href="mailto:manderse@redhat.com" target="_blank">manderse@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 21 Jul 2015, at 11:57, Ilya Buziuk wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
AFAIK we used to ship 9.2.9 bundles for CordovaSim / Livereload.<br>
There is also a test that track changes in TP and fails once Mars TP has<br>
jetty updates ( it has some Jetty 9 bundles (via other dependencies)) -<br>
<a href="https://github.com/jbosstools/jbosstools-aerogear/blob/master/cordovasim/tests/org.jboss.tools.cordovasim.eclipse.test/src/org/jboss/tools/corodvasim/eclipse/test/JettyBundlesTest.java#L33" rel="noreferrer" target="_blank">https://github.com/jbosstools/jbosstools-aerogear/blob/master/cordovasim/tests/org.jboss.tools.cordovasim.eclipse.test/src/org/jboss/tools/corodvasim/eclipse/test/JettyBundlesTest.java#L33</a><br>
So, once the test fails (Mars TP has been updated) we also need to update<br>
jetty in our TP.<br>
Denis fixed the test and AFAIK now CordovaSim uses 9.2.10 bundles, but we<br>
also need to make clean up in TP. So, I guess we need to simply remove<br>
9.2.9 from TP if LiveReload is fine with it<br>
</blockquote>
<br></span>
Problem is that Help in eclipse seem to lock down on jetty 9.2.9 thus:<br>
<br>
a) why are they locked down so close<br>
<br>
b) why did we need jetty 9.2.10 if 9.2.9 is what Mars is locked to/preferring to use ?<br>
<br>
Denis - you seem to have done parts of the 9.2.10 move - any idea ?<span class="HOEnZb"><font color="#888888"><br>
/max</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On Mon, Jul 20, 2015 at 11:00 PM, Max Rydahl Andersen <<a href="mailto:manderse@redhat.com" target="_blank">manderse@redhat.com</a>><br>
wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Our target platforms contain multiple versions of Jetty.<br>
<br>
What's in Jetty 9.2.10 that we need that's not in 9.2.9?<br>
</blockquote>
<br>
Ilya do you know what the diff is ?<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Could we push<br>
on Eclipse to bump up to depending on 9.2.10 (or at least widening<br>
their<br>
version requirement range) for Mars SR1?<br>
</blockquote>
<br>
You should open a bugzilla if you find something that is too narrow.<br>
<br>
jira asking for jetty 9 is at<br>
<a href="https://issues.jboss.org/browse/JBIDE-19497" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/JBIDE-19497</a> where I said there was risk<br>
for version mismatch<br>
but Mickael stated there wouldn't be one. I guess that changed ? (I<br>
don't know more than what are in those jiras)<br>
<br>
/max<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Ref: <a href="https://issues.jboss.org/browse/JBIDE-20313" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/JBIDE-20313</a><br>
<br>
--<br>
Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools & Dev Studio<br>
<a href="http://nick.divbyzero.com" rel="noreferrer" target="_blank">http://nick.divbyzero.com</a><br>
_______________________________________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
</blockquote>
<br>
<br>
/max<br>
<a href="http://about.me/maxandersen" rel="noreferrer" target="_blank">http://about.me/maxandersen</a><br>
_______________________________________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
<br>
</blockquote>
<br>
<br>
<br>
-- <br>
Best Regards,<br>
Ilya Buziuk<br>
</blockquote>
<br>
<br>
/max<br>
<a href="http://about.me/maxandersen" rel="noreferrer" target="_blank">http://about.me/maxandersen</a><br>
</div></div></blockquote></div><br></div>