<div class="markdown">
<p dir="auto">On 30 Nov 2015, at 21:55, Nick Boldt wrote:</p>
<blockquote>
<p dir="auto">Looking in the 4.3.x and master branches, I can only see two poms with<br>
a reference to maven-dependency-plugin or generate-resources, both of<br>
which have their <skip>false</skip> set:</p>
<p dir="auto">./plugins/org.jboss.tools.openshift.client/pom.xml<br>
./plugins/org.jboss.tools.openshift.express.client/pom.xml</p>
<p dir="auto">So, how was your openshift build failing? Can you give details<br>
(console log, for example) on how <code>mvn clean install -DskipTests=true</code><br>
failed?</p>
</blockquote>
<p dir="auto">yes, the build did not work when you run with -DskipTests=true.</p>
<p dir="auto">I have to run it with just "mvn clean install" to work, just doing "mvn clean install -DskipTests=true" resulted in failure to build related to the openshift java client updates.</p>
<p dir="auto">anyway, lets just fix the issue that requires us to litter <skip>false</skip><br>
into components builds. Please.</p>
<p dir="auto">/max</p>
<blockquote>
<p dir="auto">On Thu, Nov 26, 2015 at 7:40 AM, Max Rydahl Andersen<br>
<a href="mailto:manderse@redhat.com">manderse@redhat.com</a> wrote:</p>
<blockquote>
<p dir="auto">on this note - I just spent half the day figuring out why<br>
jbosstools-openshift<br>
was not building when I did "mvn clean install -DskipTests=true".</p>
<p dir="auto">Turns out I'm hit with this exact issue - that skipTest is for reason I<br>
never understood<br>
is used to turn off download for testing dependencies by turning of download<br>
of all dependencies.</p>
<p dir="auto">We need to stop adding workaround for this into our projects and instead<br>
have those few projects<br>
that have large dependencies to use another mechanism to turn of download.</p>
<p dir="auto">/max</p>
<p dir="auto">Only one I don't know about is swtbot.test.skip.</p>
<p dir="auto">The others I don't see how to remove nor why since they all play a part.</p>
<p dir="auto">This sounds more like should fix how the skip's works rather than remove<br>
them.</p>
<p dir="auto">The issue in JBIDE-15330 seem to because of the many time pointed out bad<br>
assumption that skipTest<br>
should mean you don't want dependencies to be downloaded.</p>
<p dir="auto">Reported here <a href="https://issues.jboss.org/browse/JBIDE-15332">https://issues.jboss.org/browse/JBIDE-15332</a> in 2013.</p>
<p dir="auto">The issue is <skipRequirements>${skipTests}</skipRequirements><br>
and then skipRequirements are used to disable all basic dependency fetching<br>
which is simply a wrong/bad assumption.</p>
<p dir="auto">/max</p>
<p dir="auto">If your project needs to download upstream libraries/runtimes/jars<br>
using something like maven-dependency-plugin, and you have not set<br>
<skip>false</skip> for those plugins' builds, eg.,<br>
<a href="https://github.com/jbosstools/jbosstools-livereload/pull/54/">https://github.com/jbosstools/jbosstools-livereload/pull/54/</a> you<br>
should do so.</p>
<p dir="auto">This is because I'd like to remove some of the obsolete skip*<br>
variables we have in the parent pom, and you don't want your builds to<br>
fail when skipping tests, as livereload used to before<br>
<a href="https://issues.jboss.org/browse/JBIDE-15330">https://issues.jboss.org/browse/JBIDE-15330</a> was fixed.</p>
<p dir="auto">Here are all the skip-related variables in our parent pom [1]:</p>
<p dir="auto"><swtbot.test.skip>true</swtbot.test.skip><br>
<skipRequirements>${skipTests}</skipRequirements><br>
<skipPrivateRequirements>true</skipPrivateRequirements><br>
<skipTestsWithPrivateRequirements>${skipPrivateRequirements}</skipTestsWithPrivateRequirements><br>
and<br>
skipTestsOrITests (which is true when skipTests or skipITests is true).</p>
<p dir="auto">[1]<br>
<a href="https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml">https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml</a></p>
<p dir="auto">Which of those are no longer used, that can be safely removed? Are<br>
skipTestsWithPrivateRequirements and skipRequirements used for the<br>
same purposes as skipITests?</p>
<p dir="auto">Thanks,</p>
<p dir="auto">--<br>
Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools & Dev Studio<br>
<a href="http://nick.divbyzero.com">http://nick.divbyzero.com</a></p>
<hr>
<p dir="auto">jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p>
<p dir="auto">/max<br>
<a href="http://about.me/maxandersen_______________________________________________">http://about.me/maxandersen_______________________________________________</a><br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p>
<p dir="auto">/max<br>
<a href="http://about.me/maxandersen">http://about.me/maxandersen</a></p>
</blockquote>
<p dir="auto">-- <br>
Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools & Dev Studio<br>
<a href="http://nick.divbyzero.com">http://nick.divbyzero.com</a></p>
</blockquote>
<p dir="auto">/max<br>
<a href="http://about.me/maxandersen">http://about.me/maxandersen</a></p>
</div>