<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">We (QA) used to use swtbot.test.skip in the past, but we abandoned it earlier this year:<div class=""><a href="https://github.com/jbosstools/jbosstools-integration-tests/commit/517bc6938bb1cbe616a2abeb25b383da3d6c4dda" class="">https://github.com/jbosstools/jbosstools-integration-tests/commit/517bc6938bb1cbe616a2abeb25b383da3d6c4dda</a></div><div class=""><br class=""></div><div class="">So we're fine with removing it. But I don't know if some developers use it for their tests in their repos.</div><div class=""><br class=""></div><div class="">-Martin</div><div class=""><div apple-content-edited="true" class=""><br class="Apple-interchange-newline">
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On 26. 11. 2015, at 0:00, Max Rydahl Andersen <<a href="mailto:manderse@redhat.com" class="">manderse@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="markdown"><p dir="auto" class="">Only one I don't know about is swtbot.test.skip.</p><p dir="auto" class="">The others I don't see how to remove nor why since they all play a part.</p><p dir="auto" class="">This sounds more like should fix how the skip's works rather than remove them.</p><p dir="auto" class="">The issue in JBIDE-15330 seem to because of the many time pointed out bad assumption that skipTest <br class="">
should mean you don't want dependencies to be downloaded.</p><p dir="auto" class="">Reported here <a href="https://issues.jboss.org/browse/JBIDE-15332" class="">https://issues.jboss.org/browse/JBIDE-15332</a> in 2013.</p><p dir="auto" class="">The issue is <skipRequirements>${skipTests}</skipRequirements><br class="">
and then skipRequirements are used to disable all basic dependency fetching<br class="">
which is simply a wrong/bad assumption.</p><p dir="auto" class="">/max</p>
<blockquote class=""><p dir="auto" class="">If your project needs to download upstream libraries/runtimes/jars<br class="">
using something like maven-dependency-plugin, and you have not set<br class="">
<skip>false</skip> for those plugins' builds, eg.,<br class="">
<a href="https://github.com/jbosstools/jbosstools-livereload/pull/54/" class="">https://github.com/jbosstools/jbosstools-livereload/pull/54/</a> you<br class="">
should do so.</p><p dir="auto" class="">This is because I'd like to remove some of the obsolete skip*<br class="">
variables we have in the parent pom, and you don't want your builds to<br class="">
fail when skipping tests, as livereload used to before<br class="">
<a href="https://issues.jboss.org/browse/JBIDE-15330" class="">https://issues.jboss.org/browse/JBIDE-15330</a> was fixed.</p><p dir="auto" class="">Here are all the skip-related variables in our parent pom [1]:</p><p dir="auto" class=""><swtbot.test.skip>true</swtbot.test.skip><br class="">
<skipRequirements>${skipTests}</skipRequirements><br class="">
<skipPrivateRequirements>true</skipPrivateRequirements><br class="">
<skipTestsWithPrivateRequirements>${skipPrivateRequirements}</skipTestsWithPrivateRequirements><br class="">
and<br class="">
skipTestsOrITests (which is true when skipTests or skipITests is true).</p><p dir="auto" class="">[1] <a href="https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml" class="">https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml</a></p><p dir="auto" class="">Which of those are no longer used, that can be safely removed? Are<br class="">
skipTestsWithPrivateRequirements and skipRequirements used for the<br class="">
same purposes as skipITests?</p><p dir="auto" class="">Thanks,</p><p dir="auto" class="">-- <br class="">
Nick Boldt :: JBoss by Red Hat<br class="">
Productization Lead :: JBoss Tools & Dev Studio<br class="">
<a href="http://nick.divbyzero.com/" class="">http://nick.divbyzero.com</a></p>
<hr class=""><p dir="auto" class="">jbosstools-dev mailing list<br class="">
<a href="mailto:jbosstools-dev@lists.jboss.org" class="">jbosstools-dev@lists.jboss.org</a><br class="">
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" class="">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p>
</blockquote><p dir="auto" class="">/max<br class="">
<a href="http://about.me/maxandersen" class="">http://about.me/maxandersen</a></p>
</div>_______________________________________________<br class="">jbosstools-dev mailing list<br class=""><a href="mailto:jbosstools-dev@lists.jboss.org" class="">jbosstools-dev@lists.jboss.org</a><br class="">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</div></blockquote></div><br class=""></div></body></html>