<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 12/01/2015 09:44 PM, Denis Golovin
wrote:<br>
</div>
<blockquote
cite="mid:CAJXFskaqnbtsMmpFCR9d=-qTGYpU8X80iouteVJjaMT7b0KOag@mail.gmail.com"
type="cite">
<div dir="ltr">There are several kinds of downloaded resources
throughout jbosstools:
<div>1. <b>Runtimes</b> required during test execution (seam,
as and etc)</div>
<div>2. <b>Compile time libraries</b> required for compilations</div>
<div>3. <b>Test project libraries</b> included into test
projects</div>
<div><br>
</div>
<div>(1) is defines test environment and should be skipped for
download if tests skipped</div>
<div>(2) and (3) should be never skipped.</div>
</div>
</blockquote>
Why do you need (3) if you not executing tests?<br>
<br>
Thanks.<br>
<br>
<blockquote
cite="mid:CAJXFskaqnbtsMmpFCR9d=-qTGYpU8X80iouteVJjaMT7b0KOag@mail.gmail.com"
type="cite">
<div dir="ltr">
<div><br>
</div>
<div>Now to handle (1) we use three different maven plugins
declared in parent pom (<a moz-do-not-send="true"
href="https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L504">see
parent/pom.xml line 504</a>):</div>
<div>
<ul>
<li><span style="color:rgb(51,51,51);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre">maven-dependency-plugin</span> -
to download some early versions of jboss-as from maven
repo<br>
</li>
<li>download-maven-plugin - to download jboss-as from
specified url<br>
</li>
<li>maven-download-plugin - to download seam distributions
from specified url</li>
</ul>
<div>To handle (2) and (3) only <span style="color:rgb(51,51,51);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre">maven-dependency-plugin</span>
is used<span style="color:rgb(51,51,51);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre">.</span></div>
</div>
<div><span style="color:rgb(51,51,51);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre">
</span></div>
I think at this time obviously we have to change <span style="color:rgb(51,51,51);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre">maven-dependency-plugin </span>declaration
in parent/pom.xml#build/pluginManagement to never skip
downloading dependencies, because it is most common use case.
After it is done we can remove unnecessary
<skip>false</skip> throughout the projects.
<div><br>
</div>
<div>If there are libs for (2) and (3) downloaded from external
URL using download-maven-plugin/maven-download-plugin we
should probably move them to locus.</div>
<div><br>
</div>
<div>Denis</div>
<div>
<div>
<div>
<div><br>
<div>
<div class="gmail_quote">
<div dir="ltr">On Tue, Dec 1, 2015 at 5:57 PM Denis
Golovin <<a moz-do-not-send="true"
href="mailto:dgolovin@exadel.com"
target="_blank">dgolovin@exadel.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_quote">
<div dir="ltr">On Tue, Dec 1, 2015 at 2:34 AM
Max Rydahl Andersen <<a
moz-do-not-send="true"
href="mailto:manderse@redhat.com"
style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:orange"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:manderse@redhat.com">manderse@redhat.com</a></a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div>
<p dir="auto">On 30 Nov 2015, at 21:55,
Nick Boldt wrote:</p>
<blockquote>
<p dir="auto">Looking in the 4.3.x and
master branches, I can only see two
poms with<br>
a reference to maven-dependency-plugin
or generate-resources, both of<br>
which have their
<skip>false</skip> set:</p>
<p dir="auto">./plugins/org.jboss.tools.openshift.client/pom.xml<br>
./plugins/org.jboss.tools.openshift.express.client/pom.xml</p>
<p dir="auto">So, how was your openshift
build failing? Can you give details<br>
(console log, for example) on how <code>mvn
clean install -DskipTests=true</code><br>
failed?</p>
</blockquote>
</div>
<div>
<p dir="auto">yes, the build did not work
when you run with -DskipTests=true.</p>
<p dir="auto">I have to run it with just
"mvn clean install" to work, just doing
"mvn clean install -DskipTests=true"
resulted in failure to build related to
the openshift java client updates.</p>
<p dir="auto">anyway, lets just fix the
issue that requires us to litter
<skip>false</skip><br>
into components builds. Please.</p>
</div>
</blockquote>
</div>
</div>
<div dir="ltr">
<div class="gmail_quote">
<div>I cannot replicate that. I was always
running full build with </div>
<div><br>
</div>
<div>mvn clean install -DskipTests=true<br>
</div>
<div><br>
</div>
<div>before and after branching of 4.3.x and
builds were always fine. I remember to have
problems when new code pushed in tooling
referencing resent changes in client jar,
which is not available from maven
repository.</div>
<div><br>
</div>
<div>nightly full build from master is still
available from wonka and it's been running
without any problems for a couple weeks.</div>
<div><br>
</div>
<div>what kind of failure you have for
openshift build from 4.3.x branch?</div>
</div>
</div>
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>Denis</div>
</div>
</div>
<div dir="ltr">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div>
<p dir="auto">/max</p>
</div>
<div>
<blockquote>
<p dir="auto">On Thu, Nov 26, 2015 at
7:40 AM, Max Rydahl Andersen<br>
<a moz-do-not-send="true"
href="mailto:manderse@redhat.com"
target="_blank">manderse@redhat.com</a>
wrote:</p>
<blockquote>
<p dir="auto">on this note - I just
spent half the day figuring out why<br>
jbosstools-openshift<br>
was not building when I did "mvn
clean install -DskipTests=true".</p>
<p dir="auto">Turns out I'm hit with
this exact issue - that skipTest is
for reason I<br>
never understood<br>
is used to turn off download for
testing dependencies by turning of
download<br>
of all dependencies.</p>
<p dir="auto">We need to stop adding
workaround for this into our
projects and instead<br>
have those few projects<br>
that have large dependencies to use
another mechanism to turn of
download.</p>
<p dir="auto">/max</p>
<p dir="auto">Only one I don't know
about is swtbot.test.skip.</p>
<p dir="auto">The others I don't see
how to remove nor why since they all
play a part.</p>
<p dir="auto">This sounds more like
should fix how the skip's works
rather than remove<br>
them.</p>
<p dir="auto">The issue in <a
moz-do-not-send="true"
href="https://issues.jboss.org/browse/JBIDE-15330"
style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:orange"
target="_blank">JBIDE-15330</a>
seem to because of the many time
pointed out bad<br>
assumption that skipTest<br>
should mean you don't want
dependencies to be downloaded.</p>
<p dir="auto">Reported here <a
moz-do-not-send="true"
href="https://issues.jboss.org/browse/JBIDE-15332"
target="_blank"><a class="moz-txt-link-freetext" href="https://issues.jboss.org/browse/JBIDE-15332">https://issues.jboss.org/browse/JBIDE-15332</a></a>
in 2013.</p>
<p dir="auto">The issue is
<skipRequirements>${skipTests}</skipRequirements><br>
and then skipRequirements are used
to disable all basic dependency
fetching<br>
which is simply a wrong/bad
assumption.</p>
<p dir="auto">/max</p>
<p dir="auto">If your project needs to
download upstream
libraries/runtimes/jars<br>
using something like
maven-dependency-plugin, and you
have not set<br>
<skip>false</skip> for
those plugins' builds, eg.,<br>
<a moz-do-not-send="true"
href="https://github.com/jbosstools/jbosstools-livereload/pull/54/"
target="_blank">https://github.com/jbosstools/jbosstools-livereload/pull/54/</a>
you<br>
should do so.</p>
<p dir="auto">This is because I'd like
to remove some of the obsolete skip*<br>
variables we have in the parent pom,
and you don't want your builds to<br>
fail when skipping tests, as
livereload used to before<br>
<a moz-do-not-send="true"
href="https://issues.jboss.org/browse/JBIDE-15330"
target="_blank">https://issues.jboss.org/browse/JBIDE-15330</a>
was fixed.</p>
<p dir="auto">Here are all the
skip-related variables in our parent
pom [1]:</p>
<p dir="auto"><swtbot.test.skip>true</swtbot.test.skip><br>
<skipRequirements>${skipTests}</skipRequirements><br>
<skipPrivateRequirements>true</skipPrivateRequirements><br>
<skipTestsWithPrivateRequirements>${skipPrivateRequirements}</skipTestsWithPrivateRequirements><br>
and<br>
skipTestsOrITests (which is true
when skipTests or skipITests is
true).</p>
<p dir="auto">[1]<br>
<a moz-do-not-send="true"
href="https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml"
target="_blank">https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml</a></p>
<p dir="auto">Which of those are no
longer used, that can be safely
removed? Are<br>
skipTestsWithPrivateRequirements and
skipRequirements used for the<br>
same purposes as skipITests?</p>
<p dir="auto">Thanks,</p>
<p dir="auto">--<br>
Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools
& Dev Studio<br>
<a moz-do-not-send="true"
href="http://nick.divbyzero.com"
target="_blank">http://nick.divbyzero.com</a></p>
<hr>
<p dir="auto">jbosstools-dev mailing
list<br>
<a moz-do-not-send="true"
href="mailto:jbosstools-dev@lists.jboss.org"
target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p>
<p dir="auto">/max<br>
<a moz-do-not-send="true"
href="http://about.me/maxandersen_______________________________________________"
target="_blank">http://about.me/maxandersen_______________________________________________</a><br>
jbosstools-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:jbosstools-dev@lists.jboss.org"
target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p>
<p dir="auto">/max<br>
<a moz-do-not-send="true"
href="http://about.me/maxandersen"
target="_blank">http://about.me/maxandersen</a></p>
</blockquote>
<p dir="auto">-- <br>
Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools
& Dev Studio<br>
<a moz-do-not-send="true"
href="http://nick.divbyzero.com"
target="_blank">http://nick.divbyzero.com</a></p>
</blockquote>
</div>
<div>
<p dir="auto">/max<br>
<a moz-do-not-send="true"
href="http://about.me/maxandersen"
target="_blank">http://about.me/maxandersen</a></p>
</div>
<br>
<div
style="font-family:Arial,Helvetica,sans-serif">
<p style="margin-bottom:0.08in"><span
style="font-family:Arial,serif;background-color:rgb(255,255,255)"><font
size="1" color="#808080">CONFIDENTIALITY
NOTICE:
This email and files attached to it
are confidential. If you
are not the intended recipient you
are hereby notified that using,
copying, distributing or taking any
action in reliance on the contents
of this information is strictly
prohibited. If you have
received this email in error please
notify the sender and delete this
email.</font></span></p>
</div>
_______________________________________________<br>
jbosstools-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:jbosstools-dev@lists.jboss.org"
target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev"
rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<div style="font-family:Arial,Helvetica,sans-serif">
<p style="margin-bottom:0.08in"><span
style="font-family:Arial,serif;background-color:rgb(255,255,255)"><font
size="1" color="#808080">CONFIDENTIALITY
NOTICE: This email and files attached to it are
confidential. If you
are not the intended recipient you are hereby notified
that using,
copying, distributing or taking any action in reliance on
the contents of this information is strictly prohibited.
If you have
received this email in error please notify the sender and
delete this
email.</font></span></p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
jbosstools-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></pre>
</blockquote>
<br>
</body>
</html>