<div dir="ltr">Discussion moved to <a href="https://issues.jboss.org/browse/JBIDE-21232">https://issues.jboss.org/browse/JBIDE-21232</a></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 2, 2015 at 4:21 AM, Max Rydahl Andersen <span dir="ltr"><<a href="mailto:manderse@redhat.com" target="_blank">manderse@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
<p dir="auto">Nice writeup.</p><span class="">
<blockquote>
<p dir="auto">I think at this time obviously we have to change<br>
maven-dependency-plugin declaration<br>
in parent/pom.xml#build/pluginManagement to never skip downloading<br>
dependencies, because it is most common use case. After it is done we can<br>
remove unnecessary <skip>false</skip> throughout the projects.</p>
</blockquote>
</span><p dir="auto">Yes - your conclusion matches mine on the jira and what mistria suggestion for fixes<br>
and with my updates handles.</p>
<p dir="auto">Can you make it happen ? :)</p><span class="">
<blockquote>
<p dir="auto">If there are libs for (2) and (3) downloaded from external URL using<br>
download-maven-plugin/maven-download-plugin we should probably move them to<br>
locus.</p>
</blockquote>
</span><p dir="auto">Main problem I know is forge, hibernate and openshift afaik.</p>
<p dir="auto">forge and openshift would not be able to move very fast if we moved their libs for Locus.</p>
<p dir="auto">Hibernate - we don't actually want/intend to expose the internal apis of hibernate so not<br>
sure if pushing all variations of hibernate into Locus is such a good idea....but it could<br>
be considered.</p>
<p dir="auto">One thing that might be worth looking for are those bundling mockito or other testing libs<br>
that we might already have put into locus or use from orbit so these are not even relevant anymore.</p>
<p dir="auto">/max</p>
<blockquote><div><div class="h5">
<p dir="auto">Denis</p>
<p dir="auto">On Tue, Dec 1, 2015 at 5:57 PM Denis Golovin <a href="mailto:dgolovin@exadel.com" target="_blank">dgolovin@exadel.com</a> wrote:</p>
</div></div><blockquote><div><div class="h5">
<p dir="auto">On Tue, Dec 1, 2015 at 2:34 AM Max Rydahl Andersen <a href="mailto:manderse@redhat.com" target="_blank">manderse@redhat.com</a><br>
wrote:</p>
<blockquote>
<p dir="auto">On 30 Nov 2015, at 21:55, Nick Boldt wrote:</p>
<p dir="auto">Looking in the 4.3.x and master branches, I can only see two poms with<br>
a reference to maven-dependency-plugin or generate-resources, both of<br>
which have their <skip>false</skip> set:</p>
<p dir="auto">./plugins/org.jboss.tools.openshift.client/pom.xml<br>
./plugins/org.jboss.tools.openshift.express.client/pom.xml</p>
<p dir="auto">So, how was your openshift build failing? Can you give details<br>
(console log, for example) on how mvn clean install -DskipTests=true<br>
failed?</p>
<p dir="auto">yes, the build did not work when you run with -DskipTests=true.</p>
<p dir="auto">I have to run it with just "mvn clean install" to work, just doing "mvn<br>
clean install -DskipTests=true" resulted in failure to build related to the<br>
openshift java client updates.</p>
<p dir="auto">anyway, lets just fix the issue that requires us to litter<br>
<skip>false</skip><br>
into components builds. Please.</p>
</blockquote>
<p dir="auto">I cannot replicate that. I was always running full build with</p>
<p dir="auto">mvn clean install -DskipTests=true</p>
<p dir="auto">before and after branching of 4.3.x and builds were always fine. I<br>
remember to have problems when new code pushed in tooling referencing<br>
resent changes in client jar, which is not available from maven repository.</p>
<p dir="auto">nightly full build from master is still available from wonka and it's been<br>
running without any problems for a couple weeks.</p>
<p dir="auto">what kind of failure you have for openshift build from 4.3.x branch?</p>
<p dir="auto">Denis</p>
</div></div><blockquote><div><div class="h5">
<p dir="auto">/max</p>
<p dir="auto">On Thu, Nov 26, 2015 at 7:40 AM, Max Rydahl Andersen<br>
<a href="mailto:manderse@redhat.com" target="_blank">manderse@redhat.com</a> wrote:</p>
<p dir="auto">on this note - I just spent half the day figuring out why<br>
jbosstools-openshift<br>
was not building when I did "mvn clean install -DskipTests=true".</p>
<p dir="auto">Turns out I'm hit with this exact issue - that skipTest is for reason I<br>
never understood<br>
is used to turn off download for testing dependencies by turning of<br>
download<br>
of all dependencies.</p>
<p dir="auto">We need to stop adding workaround for this into our projects and instead<br>
have those few projects<br>
that have large dependencies to use another mechanism to turn of download.</p>
<p dir="auto">/max</p>
<p dir="auto">Only one I don't know about is swtbot.test.skip.</p>
<p dir="auto">The others I don't see how to remove nor why since they all play a part.</p>
<p dir="auto">This sounds more like should fix how the skip's works rather than remove<br>
them.</p>
</div></div><p dir="auto">The issue in JBIDE-15330 <a href="https://issues.jboss.org/browse/JBIDE-15330" target="_blank">https://issues.jboss.org/browse/JBIDE-15330</a></p><div><div class="h5"><br>
seem to because of the many time pointed out bad<br>
assumption that skipTest<br>
should mean you don't want dependencies to be downloaded.</div></div><p></p><div><div class="h5">
<p dir="auto">Reported here <a href="https://issues.jboss.org/browse/JBIDE-15332" target="_blank">https://issues.jboss.org/browse/JBIDE-15332</a> in 2013.</p>
<p dir="auto">The issue is <skipRequirements>${skipTests}</skipRequirements><br>
and then skipRequirements are used to disable all basic dependency<br>
fetching<br>
which is simply a wrong/bad assumption.</p>
<p dir="auto">/max</p>
<p dir="auto">If your project needs to download upstream libraries/runtimes/jars<br>
using something like maven-dependency-plugin, and you have not set<br>
<skip>false</skip> for those plugins' builds, eg.,<br>
<a href="https://github.com/jbosstools/jbosstools-livereload/pull/54/" target="_blank">https://github.com/jbosstools/jbosstools-livereload/pull/54/</a> you<br>
should do so.</p>
<p dir="auto">This is because I'd like to remove some of the obsolete skip*<br>
variables we have in the parent pom, and you don't want your builds to<br>
fail when skipping tests, as livereload used to before<br>
<a href="https://issues.jboss.org/browse/JBIDE-15330" target="_blank">https://issues.jboss.org/browse/JBIDE-15330</a> was fixed.</p>
<p dir="auto">Here are all the skip-related variables in our parent pom [1]:</p>
<p dir="auto"><swtbot.test.skip>true</swtbot.test.skip><br>
<skipRequirements>${skipTests}</skipRequirements><br>
<skipPrivateRequirements>true</skipPrivateRequirements></p>
<p dir="auto"><skipTestsWithPrivateRequirements>${skipPrivateRequirements}</skipTestsWithPrivateRequirements><br>
and<br>
skipTestsOrITests (which is true when skipTests or skipITests is true).</p>
<p dir="auto">[1]<br>
<a href="https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml" target="_blank">https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml</a></p>
<p dir="auto">Which of those are no longer used, that can be safely removed? Are<br>
skipTestsWithPrivateRequirements and skipRequirements used for the<br>
same purposes as skipITests?</p>
<p dir="auto">Thanks,</p>
<p dir="auto">--<br>
Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools & Dev Studio</p>
<h2><a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a></h2>
</div></div><p dir="auto">jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p><div><div class="h5">
<p dir="auto">/max<br>
<a href="http://about.me/maxandersen_______________________________________________" target="_blank">http://about.me/maxandersen_______________________________________________</a><br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p>
<p dir="auto">/max<br>
<a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a></p>
<p dir="auto">--<br>
Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools & Dev Studio<br>
<a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a></p>
<p dir="auto">/max<br>
<a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a></p>
<p dir="auto">CONFIDENTIALITY NOTICE: This email and files attached to it are<br>
confidential. If you are not the intended recipient you are hereby notified<br>
that using, copying, distributing or taking any action in reliance on the<br>
contents of this information is strictly prohibited. If you have received<br>
this email in error please notify the sender and delete this email.</p>
<hr>
<p dir="auto">jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p>
</div></div></blockquote>
</blockquote>
<p dir="auto">-- </p><span class="">
<p dir="auto">CONFIDENTIALITY NOTICE: This email and files attached to it are<br>
confidential. If you are not the intended recipient you are hereby notified<br>
that using, copying, distributing or taking any action in reliance on the<br>
contents of this information is strictly prohibited. If you have received<br>
this email in error please notify the sender and delete this email.</p>
</span></blockquote>
<p dir="auto">/max<br>
<a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a></p>
</div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Nick Boldt :: JBoss by Red Hat<br>Productization Lead :: JBoss Tools & Dev Studio<br><a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a><br></div></div></div></div>
</div>