<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-western">On 04/27/2016 11:01 AM, Nick
Boldt wrote:
<br>
<blockquote type="cite" style="color: #000000;">One PR in Base
will not automatically cause the results of that PR to
<br>
be picked up by downstream projects (eg., Server, Openshift) or
<br>
JBT/JBDS aggregation -- to do that would require passing in a
<br>
commandline override for
<br>
-Djbosstools-base-site=<a class="moz-txt-link-freetext"
href="http://path/to/output/of/the/pull-request/build/repo/">http://path/to/output/of/the/pull-request/build/repo/</a>
<br>
... for all the downstream projects of Base, and ensuring that
the
<br>
output was published to a <i class="moz-txt-slash"><span
class="moz-txt-tag">/</span>pulls<span class="moz-txt-tag">/</span></i>
folder instead of the usual <i class="moz-txt-slash"><span
class="moz-txt-tag">/</span>builds<span class="moz-txt-tag">/</span></i>
<br>
folder.
<br>
<br>
So if I'm going down this road I wanted to make sure we think a
little
<br>
about how the future might unfold, and how we might get there.
Rather
<br>
not be painted into a corner. :D
<br>
</blockquote>
<br>
<br>
I think it is beyond overkill to even try for b). wildfly doesn't
rebuild and run the test suite for a given change in jasper, for
example. The entire idea that not even an actual change, but a
potential change / PR, to base, could end up kicking off the
entire product build and their associated test suites. I think
this is beyond overkill: it's dangerous and will sap computing
power and lock up slaves doing what's essentially no-ops.
<br>
<br>
PR's change frequently. Imagine a change in base that gets a few
different revisions? Suddenly I can't even update my PR to change
some text string without it kicking off a potential entire build
chain and test suite.
<br>
<br>
Not to mention, what if the upstream tests were already failing?
You'd have to build all the upstream plugins with the OLD base,
then build base, build everything, run all the tests, and somehow
compare the new test results to the previous test results.
<br>
<br>
I think this is folly, and it should not be pursued at all.
<br>
<br>
Start with a), and finish with a).
<br>
<br>
<blockquote type="cite" style="color: #000000;">
<br>
On Tue, Apr 26, 2016 at 6:59 PM, Alexey Kazakov <a
class="moz-txt-link-rfc2396E"
href="mailto:alkazako@redhat.com"><a class="moz-txt-link-rfc2396E" href="mailto:alkazako@redhat.com"><alkazako@redhat.com></a></a>
wrote:
<br>
<blockquote type="cite" style="color: #000000;">+100 to start
with a)
<br>
<br>
On 04/26/2016 02:20 PM, Nick Boldt wrote:
<br>
<blockquote type="cite" style="color: #000000;"><a
class="moz-txt-link-freetext"
href="https://issues.jboss.org/browse/JBIDE-21657"><a class="moz-txt-link-freetext" href="https://issues.jboss.org/browse/JBIDE-21657">https://issues.jboss.org/browse/JBIDE-21657</a></a>
<br>
<br>
On Tue, Apr 26, 2016 at 1:13 PM, Mickael Istria <a
class="moz-txt-link-rfc2396E"
href="mailto:mistria@redhat.com"><a class="moz-txt-link-rfc2396E" href="mailto:mistria@redhat.com"><mistria@redhat.com></a></a>
wrote:
<br>
<blockquote type="cite" style="color: #000000;">On
04/26/2016 05:50 PM, Max Rydahl Andersen wrote:
<br>
<br>
in other words, start with a <span class="moz-smiley-s1"
title=":)"></span>
<br>
<br>
<blockquote type="cite" style="color: #000000;">a) does
the PR break my tests / want a green light on the PR
page
<br>
</blockquote>
+1000. Is there a Jira for that?
<br>
--
<br>
Mickael Istria
<br>
Eclipse developer at JBoss, by Red Hat
<br>
My blog - My Tweets
<br>
<br>
_______________________________________________
<br>
jbosstools-dev mailing list
<br>
<a class="moz-txt-link-abbreviated"
href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<br>
<a class="moz-txt-link-freetext"
href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a>
<br>
</blockquote>
<br>
</blockquote>
_______________________________________________
<br>
jbosstools-dev mailing list
<br>
<a class="moz-txt-link-abbreviated"
href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a>
<br>
<a class="moz-txt-link-freetext"
href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</div>
</body>
</html>