<div dir="ltr"><div>This is an awesome improvement over having to resolve the PR locally, but I suspect it only works for simple PR changes. </div><div><br></div><div>---<br></div><div>Workflow is as follows:<div><br></div><div>a) create a PR, eg., <a href="https://github.com/jbosstools/jbosstools-target-platforms/pull/214" target="_blank">https://github.com/jbosstools/jbosstools-target-platforms/pull/214</a></div><div><br></div><div>b) wait a few minutes for the build to start, eg.,</div><div><br></div><div><a href="http://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Master/job/jbosstools-target-platform--pull-request/22/" target="_blank">http://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Master/job/jbosstools-target-platform--pull-request/22/</a><br></div><div><br></div><div>c) when the build is done, check the output for a blue ball and p2diff reports that show nothing unexpected</div><div><br></div><div>d) send email to jbosstools-dev@, eg., <a href="http://lists.jboss.org/pipermail/jbosstools-dev/2016-May/011351.html" target="_blank">http://lists.jboss.org/pipermail/jbosstools-dev/2016-May/011351.html</a></div><div><br></div><div>e) wait until PR review is done (eg., 2 days); apply PR and kick the matrix job to build it and publish it to the usual place</div><div><br></div><div>When I moved us to M7, there were a number of required small tweaks before I had a PR that worked, and that validation happens much more efficiently on local than by submitting it off to Jenkins to build. And that "blue" PR contained bad changes like the addition of jetty 9.3.6 and a newer Mylyn Wikitext version. Neither of these were caught by the TP build/validation process -- they were caught by downstream install-grinder and p2director install tests.<br></div><div><br></div><div>So, this isn't foolproof, but it's still a huge improvement!</div><div><br></div><div>Nick</div><div><br></div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 10, 2016 at 4:16 AM, Max Rydahl Andersen <span dir="ltr"><<a href="mailto:manderse@redhat.com" target="_blank">manderse@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><u></u>
<div>
<div><div dir="auto">or give a link to a PR to see the results (both with good and bad results) ?
</div><div dir="auto">
</div><div dir="auto">/max
</div><div dir="auto">
</div></div><div><div>
<blockquote>
<div>
<p dir="auto">This sounds awesome. Any chance you could screencast or screenshot this workflow ?</p>
<p dir="auto">/max</p>
<blockquote>
</blockquote></div>
<blockquote>
<div text="#000000" bgcolor="#FFFFFF">
Hi all,<br>
<br>
With <a href="https://issues.jboss.org/browse/JBIDE-22312" target="_blank">https://issues.jboss.org/browse/JBIDE-22312</a> , a new CI job [1]
now validates, mirror and runs p2diff [2] automatically whenever a
pull request is submitted against the
jhttps://<a href="http://github.com/jbosstools/jbosstools-target-platforms/" target="_blank">github.com/jbosstools/jbosstools-target-platforms/</a>
repository. This automated validation then report its success or
failure on the pull request directly, annotating it like Travis CI
does (with a green or red box depending on success).<br>
It returns a failure if TP validation or mirroring fail. It's most
likely to happen because of a wrong reference to a p2 repository, a
missing IU or an incorrect version, or a missing requirement.<br>
It returns a successful build if it managed to validate the PR and
mirror its content. In such case, there is still need to follow the
links to the jenkins job have a human look at the p2diff attached to
the build, and to comment whether p2diff looks fine on the PR. Then,
when build is successful and p2diff looks good, the PR can be
announced to the team and considered for a merge.<br>
<br>
Notes:<br>
* p2diff report is now generated automatically on regular Maven
build (even local ones), building the TP with the -Pmultiple2repo
profile.<br>
* Triggering validation build is setup as a cron running every 5
minutes, so it's fine if the build doesn't start immediately after
your PR creation/update. Just check it again a bit later and in case
of issue, ping @mickaelistria and/or @nickboldt on this PR<br>
* The validation build takes about 1 hour. There are for sure
opportunities to speed it up, but as the TP process is slow anyway
and that this approach is already faster than the previous ones
requiring local mirror and p2diff, speeding it up isn't high
priority at the moment.<br>
<br>
Cheers,<br>
<br>
[1]
<a href="https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Master/job/jbosstools-target-platform--pull-request/" target="_blank">https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Master/job/jbosstools-target-platform--pull-request/</a><br>
[2] <a href="https://issues.jboss.org/browse/JBIDE-22308" target="_blank">https://issues.jboss.org/browse/JBIDE-22308</a>
<div>-- <br>
Mickael Istria<br>
Eclipse developer at <a href="http://www.jboss.org/tools" target="_blank">JBoss,
by Red Hat</a><br>
<a href="http://mickaelistria.wordpress.com" target="_blank">My blog</a> - <a href="http://twitter.com/mickaelistria" target="_blank">My Tweets</a></div>
</div></blockquote>
<div>
<blockquote>
<hr>
<p dir="auto">jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a></p>
</blockquote>
<p dir="auto">/max<br>
<a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a></p>
</div></blockquote>
</div></div><div><div dir="auto">
</div><div dir="auto">
</div><div dir="auto">
</div><div dir="auto">/max
</div><div dir="auto"><a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a></div></div>
</div>
<br>_______________________________________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr">Nick Boldt :: JBoss by Red Hat<br>Productization Lead :: JBoss Tools & Dev Studio<br><a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a><br></div></div></div></div>
</div></div></div>