<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 05/25/2016 07:45 PM, Nick Boldt
wrote:<br>
</div>
<blockquote
cite="mid:CA+QcL11ZEh9SKr1z32EmB3RvV5kP37bL6dan+_yu8aOP4vd0Mg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>When I moved us to M7, there were a number of required
small tweaks before I had a PR that worked, and that
validation happens much more efficiently on local than by
submitting it off to Jenkins to build.</div>
</div>
</blockquote>
Contributions checks are in no way meant to replace the local tests
and are not an assistance for development/authoring the change.
They're just an assistance for review (someone else reviewing the
change doesn't have to build locally).<br>
<blockquote
cite="mid:CA+QcL11ZEh9SKr1z32EmB3RvV5kP37bL6dan+_yu8aOP4vd0Mg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>And that "blue" PR contained bad changes like the addition
of jetty 9.3.6 and a newer Mylyn Wikitext version. Neither of
these were caught by the TP build/validation process -- they
were caught by downstream install-grinder and p2director
install tests.<br>
</div>
</div>
</blockquote>
Right.<br>
It's already good that such issues are detected automatically by
those jobs.<br>
But we can do better, I've opened
<a class="moz-txt-link-freetext" href="https://issues.jboss.org/browse/JBIDE-22443">https://issues.jboss.org/browse/JBIDE-22443</a> to suggest a way to
catch such issues earlier automatically.<br>
<div class="moz-signature">-- <br>
Mickael Istria<br>
Eclipse developer at <a href="http://www.jboss.org/tools">JBoss,
by Red Hat</a><br>
<a href="http://mickaelistria.wordpress.com">My blog</a> - <a
href="http://twitter.com/mickaelistria">My Tweets</a></div>
</body>
</html>