<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
My main concern is that we don't have time to fix anything if there
is something broken in that new docker. So IMO this issues is not
critical enough to introduce even bigger risk for this release. <br>
This is a bad issue but not a blocker in the current circumstances.<br>
<br>
Jeff, where we can see the code difference for the docker tooling?
Do you have a gerrit change, a PR or something?<br>
<br>
<div class="moz-cite-prefix">On 06/10/2016 03:08 PM, Nick Boldt
wrote:<br>
</div>
<blockquote
cite="mid:CA+QcL11kWopXXjg8gstfNn5W4OYbCvb_QNA08zcxnq8WFdyqhQ@mail.gmail.com"
type="cite">
<div dir="ltr">Please clarify: is this a blocker for devstudio <a
moz-do-not-send="true" href="http://10.0.0.GA">10.0.0.GA</a>?
Or something to pick up in a later sprint / release?
<div><br>
</div>
<div>Given we've slipped respin-a to Monday, and still have to
rebrand everything, we probably have time to contain a small
TP change like this. IFF it's a blocker.</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Jun 10, 2016 at 2:35 PM, Jeff
Johnston <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jjohnstn@redhat.com" target="_blank">jjohnstn@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I have
just made a build available with the patch in:<br>
<br>
<a class="moz-txt-link-freetext" href="http:/">http:/</a><a moz-do-not-send="true"
href="http://download.eclipse.org/linuxtools/update-neon-docker-rc4a"
rel="noreferrer" target="_blank">download.eclipse.org/linuxtools/update-neon-docker-rc4a</a><br>
<div class="HOEnZb">
<div class="h5"><br>
-- Jeff J.<br>
<br>
----- Original Message -----<br>
> Moving to jbosstools-dev.<br>
><br>
> OK. This memory leak seems to be bad. Please
continue to work on proper<br>
> bug fix and update for the Linux/Docker Tools for
Neon but I'm afraid we<br>
> don't have time to change anything in our Target
Platform for devstudio<br>
> 10 GA / JBoss Tools 4.4.0.Final at this point.<br>
><br>
> Thanks.<br>
><br>
> On 06/10/2016 12:56 PM, Jeff Johnston wrote:<br>
> > Should be Neon only as status icons were added
for Neon M1 milestone.<br>
> > There<br>
> > may be other image leaks in Mars, but they are
minor and no errors have<br>
> > shown<br>
> > in our testing or customer usage.<br>
> ><br>
> > -- Jeff J.<br>
> ><br>
> > ----- Original Message -----<br>
> >> Is this bug in Neon branch only? What
about Mars releases?<br>
> >><br>
> >><br>
> >> On 06/10/2016 12:38 PM, Jeff Johnston
wrote:<br>
> >>> It appears that the issue I found has
been around since Aug 2015 (Neon<br>
> >>> M1).<br>
> >>> I have a fix<br>
> >>> and there appears to be another
possible leak in the DockerExplorerView<br>
> >>> which I<br>
> >>> am pushing a fix for currently.<br>
> >>><br>
> >>> I noticed the memory leak the other
day and during my testing I saw that<br>
> >>> images<br>
> >>> were being left behind to the point
that the Eclipse MAT tool took notice<br>
> >>> over a<br>
> >>> short period and flagged it as a
suspected memory leak. Docker<br>
> >>> Containers<br>
> >>> get refreshed every 15 seconds so
Views<br>
> >>> that show them (Docker Containers View
and Docker Explorer View) that use<br>
> >>> icons need<br>
> >>> to dispose of them properly. For the
Docker Containers View, all<br>
> >>> containers were being<br>
> >>> given a new image each refresh
period. The Explorer View isn't much of a<br>
> >>> problem because<br>
> >>> it is node-based and doesn't always
show the full list of Containers. A<br>
> >>> short list of Containers<br>
> >>> will slow down the leak as will
closing the View.<br>
> >>><br>
> >>> My intention was to do a quick rebuild
of the stable-5.0 branch and save<br>
> >>> it<br>
> >>> as RC4a repo. If desired,<br>
> >>> I can do a point release, but this
requires more changes to all features<br>
> >>> and pom files to renumber<br>
> >>> them. Let me know if a point release
is required.<br>
> >>><br>
> >>> I will continue with the task of
building an RC4a repo that will be saved<br>
> >>> in the Linux Tools download<br>
> >>> area. Neon users will have to use the
updates-nightly-neon repo which<br>
> >>> will<br>
> >>> have<br>
> >>> the fix (same git branch is used to
create the RC4a repo).<br>
> >>><br>
> >>> -- Jeff J.<br>
> >>><br>
> >>> ----- Original Message -----<br>
> >>>> When did it happen? How long do
you have it in Docker Tools.<br>
> >>>><br>
> >>>> Have you already fixed it?
Released the updated 2.0.1?<br>
> >>>><br>
> >>>> On 06/10/2016 11:19 AM, Jeff
Johnston wrote:<br>
> >>>>> This issue was introduced with
a change to adding status icons in the<br>
> >>>>> Containers View. It wasn't
noticed because it requires a long time to<br>
> >>>>> show (small image icons not
being disposed of).<br>
> >>>>><br>
> >>>>> -- Jeff J.<br>
> >>>>><br>
> >>>>> ----- Original Message -----<br>
> >>>>>> We will conceder to
include any updated in respin-b besides branding<br>
> >>>>>> only if we have to fix
some very bad issues. Real blocker.<br>
> >>>>>> Is this issue is old or
some new regression?<br>
> >>>>>><br>
> >>>>>> On 06/10/2016 10:57 AM,
Xavier Coulon wrote:<br>
> >>>>>>> From my
understanding, Jeff noticed the issue after letting<br>
> >>>>>>> Eclipse<br>
> >>>>>>> run<br>
> >>>>>>> all night long,
but I don't remember if Eclipse was then unusable<br>
> >>>>>>> or<br>
> >>>>>>> crashed.<br>
> >>>>>>> Anyway, it could be
serious enough it users have the Docker tooling<br>
> >>>>>>> views<br>
> >>>>>>> open in their
workspace.<br>
> >>>>>>><br>
> >>>>>>> Best regards,<br>
> >>>>>>> Xavier<br>
> >>>>>>>> On 10 Jun 2016, at
12:37, Alexey Kazakov <<a moz-do-not-send="true"
href="mailto:alkazako@redhat.com">alkazako@redhat.com</a>><br>
> >>>>>>>> wrote:<br>
> >>>>>>>><br>
> >>>>>>>><br>
> >>>>>>>> How bad is that
leak?<br>
> >>>>>>>><br>
> >>>>>>>><br>
> >>>>>>>>> On Jun 10,
2016, at 4:33 AM, Xavier Coulon <<a
moz-do-not-send="true"
href="mailto:xcoulon@redhat.com"><a class="moz-txt-link-abbreviated" href="mailto:xcoulon@redhat.com">xcoulon@redhat.com</a></a>><br>
> >>>>>>>>> wrote:<br>
> >>>>>>>>><br>
> >>>>>>>>> Fred, Alexey,<br>
> >>>>>>>>><br>
> >>>>>>>>> Jeff J. found
a memory leak in the Docker tooling. It's too late<br>
> >>>>>>>>> for<br>
> >>>>>>>>> Neon.0
RC4/Final, but he proposes that we cut a Linux Tools
5.0.1 /<br>
> >>>>>>>>> Docker Tooling
2.0.1 to address this specific issue.<br>
> >>>>>>>>> Is this
something that can be included in the upcoming
"respin-b"<br>
> >>>>>>>>> build<br>
> >>>>>>>>> along with the
branding updates ? I understand that Alexey<br>
> >>>>>>>>> initially<br>
> >>>>>>>>> said that this
ultimate build would not include any other bug fix,<br>
> >>>>>>>>> but<br>
> >>>>>>>>> nonetheless,
I'm asking the question ;-)<br>
> >>>>>>>>><br>
> >>>>>>>>> Best regards,<br>
> >>>>>>>>> /Xavier<br>
> >>>>>>>>><br>
> >>>>>>>>>> Hi Xavier,<br>
> >>>>>>>>>><br>
> >>>>>>>>>> Jeff
here. I found a memory leak in the Docker Containers
View.<br>
> >>>>>>>>>> I<br>
> >>>>>>>>>> believe it
is fixed with my gerrit patch. If JBoss wants, I can<br>
> >>>>>>>>>> create<br>
> >>>>>>>>>> a<br>
> >>>>>>>>>> special
repo for them to use to remove this bug. The fix is too<br>
> >>>>>>>>>> late<br>
> >>>>>>>>>> for<br>
> >>>>>>>>>> Neon, but
we can cut a point release if necessary or wait until<br>
> >>>>>>>>>> 5.1<br>
> >>>>>>>>>> and<br>
> >>>>>>>>>> fix it in
the updates-nightly-neon.<br>
> >>>>>>>>>><br>
> >>>>>>>>>> The
problem was with the images used for status in the
Table.<br>
> >>>>>>>>>> They<br>
> >>>>>>>>>> were<br>
> >>>>>>>>>> constantly
being created via createImage() but never stored any<br>
> >>>>>>>>>> where<br>
> >>>>>>>>>> and<br>
> >>>>>>>>>> never
disposed. I simply created 3 images for status and
return<br>
> >>>>>>>>>> one<br>
> >>>>>>>>>> of<br>
> >>>>>>>>>> 3<br>
> >>>>>>>>>> for each
table entry, then dispose of them in the Containers View<br>
> >>>>>>>>>> dispose<br>
> >>>>>>>>>> method.<br>
> >>>>>>>>>><br>
> >>>>>>>>>> -- Jeff J.<br>
> >><br>
><br>
><br>
_______________________________________________<br>
jbosstools-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:jbosstools-dev@lists.jboss.org">jbosstools-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev"
rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/jbosstools-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">Nick Boldt :: JBoss by Red Hat<br>
Productization Lead :: JBoss Tools & Dev Studio<br>
<a moz-do-not-send="true"
href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a><br>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>