<div dir="ltr">OK this is running ok if I update the PR. But the PR page says 1 successful check although 2 have run (see <a href="https://github.com/jbosstools/jbosstools-openshift/pull/1235">https://github.com/jbosstools/jbosstools-openshift/pull/1235</a>). it is a Github pb ?<div><br></div><div>Jeff</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 22, 2016 at 6:49 PM, Mickael Istria <span dir="ltr"><<a href="mailto:mistria@redhat.com" target="_blank">mistria@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class="">
<div>On 06/22/2016 06:44 PM, Max Andersen
wrote:<br>
</div>
<blockquote type="cite">Well we could remove all push rights to master repos
and let the ci bot do the merge.</blockquote></span>
You mean a CI bot that would merge on developer request? If so I
don't get how it's better than leaving the developer push directly.<span class=""><br>
<blockquote type="cite">
<div>Then it's as prevented as gerrit. <br>
</div>
</blockquote></span>
Usually, Gerrit UI simply hides the "Submit" button on a
contribution if it doesn't conform to project requirements
(fast-forward, Verified+1, Code-Review+2, no -1). AFAIK, there is no
way to add such logic on GitHub UI and the Merge button is always
there, even when no-one likes it.<br>
<br>
Note that usually with Gerrit, it's still possible for committers to
push directly to master.<br>
But indeed, some projects do lock master and only allow submission
via Gerrit UI. Would GitHub allow that? Would it be good to use it
given the limitation explained above (no way to control the
availability of the merge operation in UI) ?<span class=""><br>
<br>
<div>-- <br>
Mickael Istria<br>
Eclipse developer at <a href="http://www.jboss.org/tools" target="_blank">JBoss,
by Red Hat</a><br>
<a href="http://mickaelistria.wordpress.com" target="_blank">My blog</a> - <a href="http://twitter.com/mickaelistria" target="_blank">My Tweets</a></div>
</span></div>
</blockquote></div><br></div>