<div dir="ltr">Nick,<div><br></div><div>yes that the idea. This is following what you've done with your PR's for fixing master (livereload,...) except that we will increment mini in master </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 28, 2017 at 7:09 PM, Nick Boldt <span dir="ltr"><<a href="mailto:nboldt@redhat.com" target="_blank">nboldt@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="">"<span style="font-size:12.8px">We will upversion only the sub component that has changed."</span><div><span style="font-size:12.8px"><br></span></div></span><div><span style="font-size:12.8px">Does that mean "only increment the plugin and its containing feature when a change happens in a given plugin; for all other plugins/features don't bump for the sake of bumping" ?</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Or does that mean "if in jbosstools-base, only foundation and common have changed, but the sub components called usage, runtime, tests, and stacks have not, then only the features and plugins in foundation and common should be mass-bumped to x.y+1 (master) or x.y.z+1 (4.4.x branch)" ? </span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">By the way, if you forget to increment a feature that contains your changed plugin, the baseline comparator will complain when you build locally:</span></div><div><span style="font-size:12.8px"><br></span></div><div><div><span style="font-size:12.8px">[ERROR] Failed to execute goal compare-version-with-baselines on org.jboss.tools.openshift.<wbr>core: Version have moved backwards for (org.jboss.tools.openshift.<wbr>core/3.3.2.v20170215-1207). Baseline has 3.3.2.v20170217-1329)</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">So you can verify you've bumped all the right things by iterating until the errors go away.</span></div><div style="font-size:12.8px"><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Tue, Feb 28, 2017 at 12:11 PM, Jean-Francois Maury <span dir="ltr"><<a href="mailto:jmaury@redhat.com" target="_blank">jmaury@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">Hello,<div><br></div><div>as we branched for Oxygen, we now have two different branches to maintain and as we are pushed changes in the code base, we need to upversion the components.</div><div>In order to be better aligned with OSGI/P2, we decided to change a little how the bump is managed.</div><div>Previously, all sub-components of a component (eg jbosstools-openshift) were upversioned as soon as a single sub component is modified). We will upversion only the sub component that has changed.</div><div>For master, the minor will be incremented and for 4.4.x, the micro will be increment.</div><div><br></div><div>As an example, we need to update org.jboss.tools.openshift.clie<wbr>nt in both branches and as OpenShift is 3.3.2, this will give:</div><div><ul><li>master: org.jboss.tools.openshift.clie<wbr>nt only will switch to 3.4.0</li><li>4.4.x: org.jboss.tools.openshift.clie<wbr>nt only will switch to 3.3.3</li></ul>We will experiment this during 4.4.4.AM1 and revisit if we found too many problems</div></div>
<br></div></div>______________________________<wbr>_________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/jbosstools-dev</a><span class="HOEnZb"><font color="#888888"><br></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_8499481708550318141gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Nick Boldt :: JBoss by Red Hat<br>Productization Lead :: JBoss Tools & Dev Studio<br><a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a><br></div></div></div></div>
</font></span></div>
</blockquote></div><br></div>