<div dir="ltr">I've opened <a href="https://issues.jboss.org/browse/JBIDE-24439">https://issues.jboss.org/browse/JBIDE-24439</a> to track this request and gather SPECIFIC requests from project leads as to what projects should be changed and how they should be protected. <div><br></div><div>Thanks,</div><div><br></div><div>Nick</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 11, 2017 at 1:14 PM, Jean-Francois Maury <span dir="ltr"><<a href="mailto:jmaury@redhat.com" target="_blank">jmaury@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Simple is beautiful. I fully agree<div><br></div><div>+1</div><div><br></div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Thu, May 11, 2017 at 7:10 PM, Nick Boldt <span dir="ltr"><<a href="mailto:nboldt@redhat.com" target="_blank">nboldt@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Better suggestion then:<div><br></div><div>* Make sure if your PR requires a version bump that the PR includes TWO commits. One for the change, and one for the version bump. That way the pair of commits can be built in the PR build and verify it works, AND when cherry picking the commit across branches, you can pick only the change and not the version-bump commit too.</div><div><br></div><div>So say we all?</div><span class="m_-2667567317813593700HOEnZb"><font color="#888888"><div><br></div><div>Nick</div><div><br></div></font></span></div><div class="m_-2667567317813593700HOEnZb"><div class="m_-2667567317813593700h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 10, 2017 at 1:56 PM, Jean-Francois Maury <span dir="ltr"><<a href="mailto:jmaury@redhat.com" target="_blank">jmaury@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">I would like to keep the version bump out of the pr because it will allow us to cherry pick the pr in the maintenance branch<div dir="auto"><br></div><div dir="auto"><br></div></div><div class="m_-2667567317813593700m_-8527266126270282380HOEnZb"><div class="m_-2667567317813593700m_-8527266126270282380h5"><div class="gmail_extra"><br><div class="gmail_quote">Le 10 mai 2017 16:31, "Nick Boldt" <<a href="mailto:nboldt@redhat.com" target="_blank">nboldt@redhat.com</a>> a écrit :<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I would rather see these PRs fail specifically because the versions were not correctly bumped. <div>Then the PR could be fixed to include the correct bump and resubmitted / rebuilt. </div><div>Or if in the intervening time another commit happened which fixed the versions, then the PR could be rebased and rebuilt.<br><br>But having them fail is<b> A GOOD THING</b> as it reminds people to build locally before pushing the PR up to github. Doing so they'd see the baseline check fail locally and could therefore apply the version bump locally too.<br><br>For example (and not to pick on anyone - this is just the most recent example I've seen) here's a commit that caused the build to break in both 4.4.x and master [1], which required 4 additional files [2] to be updated:<br><br>[1] <a href="https://github.com/jbosstools/jbosstools-base/commit/3dafb287134414720de46da20c7e2f210cd73aaf" target="_blank">https://github.com/jbosstools/<wbr>jbosstools-base/commit/3dafb28<wbr>7134414720de46da20c7e2f210cd73<wbr>aaf</a><br>[2] <a href="https://github.com/jbosstools/jbosstools-base/commit/dbfad28ff809f99e8c3bf3d80b26cd06806d3b2f" target="_blank">https://github.com/jbosstools/<wbr>jbosstools-base/commit/dbfad28<wbr>ff809f99e8c3bf3d80b26cd06806d3<wbr>b2f</a><br><br>You'll notice the PR [3] failed to build [4], too:<br><br>[3] <a href="https://github.com/jbosstools/jbosstools-base/pull/579" target="_blank">https://github.com/jbosstools/<wbr>jbosstools-base/pull/579</a><br>[4] <a href="https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-base-Pull-Request/121/console" target="_blank">https://dev-platform-jenkins.r<wbr>hev-ci-vms.eng.rdu2.redhat.com<wbr>/job/jbosstools-base-Pull-Requ<wbr>est/121/console</a><br><br>"[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho<wbr>-p2-extras-plugin:1.0.0:compar<wbr>e-version-with-baselines<br>(default) on project org.jboss.tools.usage: <br>Only qualifier changed for (org.jboss.tools.usage/<a href="http://2.2.3." target="_blank">2.2.3.</a>v<wbr>20170505-1402). <br>Expected to have bigger x.y.z than what is available in baseline (2.2.3.v20161213-1258)"<br><div><br></div><div>So these failures SHOULD be respected and SHOULD block pushing the PR into the branch.</div><div><br></div><div><b>+100 for Dmitri's suggestion of implementing Protected Branches and Required Status Checks. </b></div><div><br></div><div>We can furthermore do what Fuse Tools does and require that PRs be reviewed before they can be merged, if we're ready to have that additional overhead on every PR.</div><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 10, 2017 at 3:17 AM, Dmitrii Bocharov <span dir="ltr"><<a href="mailto:dbocharo@redhat.com" target="_blank">dbocharo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Jeff, for this purpose we can think of some special comment for such PRs, that would allow to merge them (like <i>testPR</i> for a new build). As far as i know it's possible.</div><div class="m_-2667567317813593700m_-8527266126270282380m_3751293907893152714m_-9204853031674158883HOEnZb"><div class="m_-2667567317813593700m_-8527266126270282380m_3751293907893152714m_-9204853031674158883h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 10, 2017 at 9:01 AM, Jean-Francois Maury <span dir="ltr"><<a href="mailto:jmaury@redhat.com" target="_blank">jmaury@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">I'm ok with that rule except for one case when the pr is done before the version bump has been merged then the Jenkins build will fail because of the baseline check so maybe we need to update the pr Jenkins build <div dir="auto"><br></div><div dir="auto">Jeff</div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-2667567317813593700m_-8527266126270282380m_3751293907893152714m_-9204853031674158883m_-2547270886660430091h5">Le 9 mai 2017 23:10, "Mickael Istria" <<a href="mailto:mistria@redhat.com" target="_blank">mistria@redhat.com</a>> a écrit :<br type="attribution"></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-2667567317813593700m_-8527266126270282380m_3751293907893152714m_-9204853031674158883m_-2547270886660430091h5"><div dir="ltr"><div><div><div>FYI, not merging the broken patches is the policy followed by most Eclipse.org projects and overall, none of this project has complained from a reduced productivity; on the contrary, catching and fixing issues immediately on the right context has improved quality and reduced the necessary amount of quick fix patches (which are actually quite time consuming and stressful for their low added-value).<br></div>So I think if it works for Eclipse.org projects, it can work for JBoss Tools.<br><br></div>Cheers,<br></div>Mickael<br></div>
<br></div></div><span>______________________________<wbr>_________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/jbosstools-dev</a><br></span></blockquote></div></div>
</blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
jbosstools-dev mailing list<br>
<a href="mailto:jbosstools-dev@lists.jboss.org" target="_blank">jbosstools-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jbosstools-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/jbosstools-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-2667567317813593700m_-8527266126270282380m_3751293907893152714m_-9204853031674158883gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Nick Boldt</font></span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Senior Software Engineer, RHCSA</font></span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Productization Lead :: JBoss Tools & Dev Studio</font></span></p><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:3pt"><span><font color="#999999"><span style="font-size:8pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">IM: @nickboldt / @nboldt / </span><span style="font-size:8pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a></span></font></span><br></p><div><div dir="ltr"><table border="0" style="color:rgb(0,0,0)"><tbody><tr><td width="100px"><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank"><font face="arial, helvetica, sans-serif" size="1"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></font></a></td><td><div><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);text-decoration:none;font-weight:bold" target="_blank"><font face="arial, helvetica, sans-serif" size="1">TRIED. TESTED. TRUSTED.</font></a></div></td></tr></tbody></table><div style="color:rgb(0,0,0)"><div style="color:rgb(153,153,153)"><font face="arial, helvetica, sans-serif" size="1"><a href="https://twitter.com/redhatnews" title="twitter" style="color:rgb(119,119,119);background-image:url("https://www.redhat.com/files/brand/email/sm-twitter.png");height:20px;text-decoration:none;display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank">@ @redhatnews</a> </font><a href="https://www.facebook.com/RedHatInc" title="Facebook" style="color:rgb(119,119,119);background-image:url("https://www.redhat.com/files/brand/email/sm-facebook.png");height:20px;text-decoration:none;display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank"><span style="color:rgb(153,153,153);font-family:Arial;font-size:8pt;white-space:pre-wrap"> Red Hat</span><br></a></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>
</blockquote></div></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-2667567317813593700m_-8527266126270282380gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Nick Boldt</font></span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Senior Software Engineer, RHCSA</font></span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Productization Lead :: JBoss Tools & Dev Studio</font></span></p><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:3pt"><span><font color="#999999"><span style="font-size:8pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">IM: @nickboldt / @nboldt / </span><span style="font-size:8pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a></span></font></span><br></p><div><div dir="ltr"><table border="0" style="color:rgb(0,0,0)"><tbody><tr><td width="100px"><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank"><font face="arial, helvetica, sans-serif" size="1"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></font></a></td><td><div><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);text-decoration:none;font-weight:bold" target="_blank"><font face="arial, helvetica, sans-serif" size="1">TRIED. TESTED. TRUSTED.</font></a></div></td></tr></tbody></table><div style="color:rgb(0,0,0)"><div style="color:rgb(153,153,153)"><font face="arial, helvetica, sans-serif" size="1"><a href="https://twitter.com/redhatnews" title="twitter" style="color:rgb(119,119,119);background-image:url("https://www.redhat.com/files/brand/email/sm-twitter.png");height:20px;text-decoration:none;display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank">@ @redhatnews</a> </font><a href="https://www.facebook.com/RedHatInc" title="Facebook" style="color:rgb(119,119,119);background-image:url("https://www.redhat.com/files/brand/email/sm-facebook.png");height:20px;text-decoration:none;display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank"><span style="color:rgb(153,153,153);font-family:Arial;font-size:8pt;white-space:pre-wrap"> Red Hat</span><br></a></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_-2667567317813593700gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>JEFF</span> <span>MAURY</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px;text-decoration:none" target="_blank">Red Hat <span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span style="margin:0px;padding:0px"><a href="mailto:jmaury@redhat.com" style="color:rgb(0,136,206);margin:0px;text-decoration:none" target="_blank">jmaury@redhat.com</a> </span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td><td style="font-size:10px"><div><a href="https://redhat.com/summit" style="text-decoration:none" target="_blank"><img width="70px" height="auto" src="https://www.redhat.com/files/brand/email/sig-summit.png" style="outline:0px"></a></div></td></tr></tbody></table><div style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px"><div style="color:rgb(153,153,153)"><a href="https://twitter.com/redhatjobs" title="twitter" style="background-image:url("https://www.redhat.com/files/brand/email/sm-twitter.png");height:20px;text-decoration:none;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank">@redhatjobs</a> <a href="https://www.facebook.com/redhatjobs/" title="facebook" style="background-image:url("https://www.redhat.com/files/brand/email/sm-facebook.png");height:20px;text-decoration:none;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank">redhatjobs</a> <a href="https://instagram.com/redhatjobs" title="instagram" style="background-image:url("https://www.redhat.com/files/brand/email/sm-instagram.png");height:20px;text-decoration:none;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank">@<wbr>redhatjobs</a> </div></div></div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Nick Boldt</font></span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Senior Software Engineer, RHCSA</font></span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:8pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><font color="#999999">Productization Lead :: JBoss Tools & Dev Studio</font></span></p><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:3pt"><span><font color="#999999"><span style="font-size:8pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">IM: @nickboldt / @nboldt / </span><span style="font-size:8pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><a href="http://nick.divbyzero.com" target="_blank">http://nick.divbyzero.com</a></span></font></span><br></p><div><div dir="ltr"><table border="0" style="color:rgb(0,0,0)"><tbody><tr><td width="100px"><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank"><font face="arial, helvetica, sans-serif" size="1"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></font></a></td><td><div><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);text-decoration:none;font-weight:bold" target="_blank"><font face="arial, helvetica, sans-serif" size="1">TRIED. TESTED. TRUSTED.</font></a></div></td></tr></tbody></table><div style="color:rgb(0,0,0)"><div style="color:rgb(153,153,153)"><font face="arial, helvetica, sans-serif" size="1"><a href="https://twitter.com/redhatnews" title="twitter" style="color:rgb(119,119,119);background-image:url("https://www.redhat.com/files/brand/email/sm-twitter.png");height:20px;text-decoration:none;display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank">@ @redhatnews</a> </font><a href="https://www.facebook.com/RedHatInc" title="Facebook" style="color:rgb(119,119,119);background-image:url("https://www.redhat.com/files/brand/email/sm-facebook.png");height:20px;text-decoration:none;display:inline-block;line-height:20px;padding-left:16px;background-repeat:no-repeat;background-position:0px 50%" target="_blank"><span style="color:rgb(153,153,153);font-family:Arial;font-size:8pt;white-space:pre-wrap"> Red Hat</span><br></a></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>