<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">We’d already agreed to make the paths for both source and target required in the wizard, so I have no problem with removing the “change” ability from the editor. Not sure if I see the advantage of the extra pages, but maybe Brian’s mockups with shed light on that.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 19, 2015, at 12:36 PM, Keith Babo <<a href="mailto:kbabo@redhat.com" class="">kbabo@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 19, 2015, at 1:23 PM, John Verhaeg <<a href="mailto:verhaeg@icloud.com" class="">verhaeg@icloud.com</a>> wrote:</div><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">I'm probably missing something, but if the user doesn't select the path for Java types, what do we show in the editor in the model viewers?</span></div></blockquote><div class=""><br class=""></div><div class="">My initial thought was that they could just select it from the mapper, but after i thought about it some more I wrote the last bit of my email about selecting the Java type in the wizard.</div><br class=""><blockquote type="cite" class=""><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""><blockquote type="cite" class=""><div class=""><div class=""><div class=""><div class=""><br class=""></div><div class="">Another idea I’ve been playing around with is removing support for changing the source and target types in the editor and instead allowing the user to select the target type in the wizard. Since changing a source or target type invalidates all mappings anyway, I don’t think this is much of an inconvenience. It also makes life simpler as we won’t need to change the Camel config from within the mapper editor any longer to update source/target types. If we went ahead with this plan, then my comments above about skipping the source/target pages in the wizard would no longer apply. Instead, we would have a page where the user had a type browser where they selected the source and target type on each page.</div></div></div></div></blockquote><div class=""><br class=""></div>So if the user changes their mind about source and/or target, they just delete the existing transformation.xml before restarting the wizard?</div></div></blockquote><div class=""><br class=""></div><div class="">Sorry, I phrased the last part of my initial email bit poorly and conflated two things. I will break them up:</div><div class=""><br class=""></div><div class="">1) We should prompt for the model class in the new transformation wizard for Java source/target types.</div><div class="">2) If we do (1), we have an option to remove support for changing the type in the editor.</div><div class=""><br class=""></div><div class="">We should definitely do (1), in my opinion. (2) is optional - an advantage is that it removes the need to prompt for camel context location when opening a map directly from the project explorer.</div><div class=""><br class=""></div><div class="">regards,</div><div class="">keith</div></div></div></div></blockquote></div><br class=""></div></body></html>