[jbosstools-issues] [JBoss JIRA] (JBIDE-10264) Wizard-ify the project examples

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665463#comment-12665463 ] 

Max Rydahl Andersen commented on JBIDE-10264:
---------------------------------------------

> huh ? why ? if its maven it uses the maven pages, if its plain it uses the plain pages.

> Because we are using m2e archetype page that already includes those properties.

but m2e archetype are not used/shown when we aren't working with archetypes.

> Disagree - why else does eclipse provide an output directory choice for all its project/file creation wizards ? It's so it can be changed if needed and otherwise default.

>...but doesn't create a separate page for those properties. The user that doesn't use those properties doesn't need any additional click.

He can press finish and never see that page.

>We can add those properties to the Requirements page after the user has chosen a project example on this page.

Then the page looks different from maven than examples - unnecessary complexity IMO.

> And the intent is to have a clear flow. If you want to skip the last page - then fine, but then I do not see how we can fix the "select projects" since it would be happening async while user is waiting 
> and doing something else.

>OK. The last page prevents us from implementing download correctly and requires an additional user action (click Finish).

I disagree with this but fine skipping that last page.

>>As to the "select projects", we can select it without the page. We select it when a project example is downloaded and built. Can be controlled by a property.

don't think this should be done - should just select the projects imported by default. Makes it nice and clear what got imported.

> The request for this jira is to have the same behavior/flow wether you are starting examples from central or project examples.
> Wizard approach is that suggestion.

>The only difference would be the existence of Page 1 when using Help>Project Examples (project example choice). When starting from JBoss Central, we go to the Page 2 (Requi>rements) directly.

Yes.

>>is it necessary to add output directory/workinkset properties page (already exists in the maven archetypes pages)
>>If you want we to add it to other types of project examples, we would have to add a tag (skipOutputDirectory for example) saying that showing this page is unnecessary (for >all the mavenArchetype project examples, for instance)

>> I do not understand this logic - for me it is "if mvn showmvn pages, if not mvn showoutput pages"

>Currently, the mavenArchetype project examples show the outputdirectory/workingset properties. 
>We somehow have to skip showing those properties in the standard wizard pages when handling a mavenArchetype project example.

Yes? if "no additional pages" add the page for output directory for the examples.

> okey - so I dont think we have time to argue more on this so if you could
> at least make the requirements page and provide page with option for which directory the projects will be stored in for "plain" and for mvn use the wizard pages then
> i'm fine to skip the "last page" allowing you to do "background" download.

> ok ?

Agree.

I suggest the following:

>Page 1 - project example choice (this page is skiped when starting from JBoss Central)
>Page 2 - Requirements - includes output directory/workingset properties (these properties are hidden for some project examples - mavenArchetype, for instance)
>contributed page ...
>If a project example doesn't include any contributed page, the wizard will always finish on the Page 2. If there are contributed pages, they will do the download.

I suggest:

Page 1 - project example choice (this page is skiped when starting from JBoss Central)
Page 2 - Requirements 
if contributed pages:
 >contributed page ...
else
Page 3 - includes output directory/workingset properties. (this page is optional since its all defaulted so pressing finish on Page 2 hides this completely)

If a project example doesn't include any contributed page, the wizard will be possible to finish on the Page 2, Page 3 is optional. If there are contributed pages, they will do the download.

>When the wizard finishes, we open the Quick Fix dialog, readme/cheatsheet and select a project(s) if the user required that.

Yes - except now I don't see where we put the checkboxes for these things (quickfix, cheatsheet and projects..)
so I guess these should be defaulted.

I've added a workflow showing this.

Could also simply when all the import is done show dialog showing those three options plus info on "Example xyz imported and ready to use".
But that is what you don't want as far as I understand ;) 
                
> Wizard-ify the project examples
> -------------------------------
>
>                 Key: JBIDE-10264
>                 URL: https://issues.jboss.org/browse/JBIDE-10264
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: project-examples
>    Affects Versions: 3.3.0.M4
>            Reporter: Fred Bricon
>            Assignee: Snjezana Peco
>            Priority: Blocker
>             Fix For: 3.3.0.Beta1
>
>         Attachments: simplified-workflow.bmml, simplified-workflow.png, wizardsuggestion.bmml, wizardsuggestion.bmml, wizardsuggestion.png
>
>
> In the wake of JBIDE-9776 and JBIDE-10140, it turns out that, in order for us to contribute 5 new wizards to the "New " menu under the Jboss perspective and in the "New project" section of JBoss central, "project examples" based projects should be created via a Wizard implementation from the get go. 
> Current project examples workflow involves :
> - displaying a form dialog : to display missing runtimes and let the user install/download the required runtimes
> - launching a workspace job, which in turn : 
>   * downloads the example
>   * does the actual project import (launches a wizard for maven archetypes)
>   * resolve quickfixes
> Ideally, all these steps would be part of a single wizard, spanning one to N pages (depending on the complexity/requirements of the examples). Everything contributed by the form dialog would be replaced by a wizard page, which would bring consistency to the UI.
> In other words, that means the project example dialog needs to be refactored into a Wizard, providing an API so that client plugins can contribute wizard pages. 
> I'm aware this is not a simple task to refactor the existing workflow to such an infrastructure but ultimately, that would allow us to easily contribute new project wizards to the IDE in a standard way.
> Current target is 3.3.0.Beta1. Snjeza, WDYT?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira