[jbosstools-issues] [JBoss JIRA] (JBIDE-10127) Resolve selector in open-on of style class in VPE

Fri Feb 17 13:14:36 EST 2012

    [ https://issues.jboss.org/browse/JBIDE-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668988#comment-12668988 ] 

Viacheslav Kabanovich commented on JBIDE-10127:
-----------------------------------------------

Well, of course, 'distance' was just my guess attempting to explain what I got in browser. Its failure reminds us that it is not a simple task to reconstruct a function of many variables by few points. 
As soon as we have got the exact algorithm, please do not limit it to 'selector's specificity', use all there is in 'section 6.4' that relates to rule sorting.
And, once more, if two rules Rule1 and Rule2 match the node, and Rule2 is more specific, some style attributes of Rule1 may be still used for the node, either because they are not defined in Rule2, or because they are marked '!important' in Rule1. That means that open-on options should be shown for all rules that contribute to the style of the node.

> Resolve selector in open-on of style class in VPE
> -------------------------------------------------
>
>                 Key: JBIDE-10127
>                 URL: https://issues.jboss.org/browse/JBIDE-10127
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: jsp/jsf/xml source editing
>    Affects Versions: 3.3.0.M3
>            Reporter: Viacheslav Kabanovich
>            Assignee: Victor Rubezhny
>             Fix For: 3.4.x
>
>         Attachments: css2.pdf
>
>
> EXECUTE: Create style sheet:
> {code}
>     .styleA {color: #FF0000}
>     .styleA .styleB {color: #FF8000}
>     div.styleA {color: #FF0080}
>     div[title="x"].styleA {color: #0000FF}
>     p input.styleA {color: #CCAA00}
>     div p input.styleA {color: #CC00FF}
>     [title="y"] p input.styleA {color: #00CCFF}
> {code}
> EXECUTE: Create html:
> {code}
> <html>
> <head>
> 	<title>Hello!</title> 
> 	<link href="stylesheet.css" rel="stylesheet" type="text/css"/>
> </head>
> <body>	
> 	<p class="styleA">
> 		.styleA {color: #FF0000}
> 	</p>	
> 	<p class="styleA">
> 		.styleA {color: #FF0000}
> 		<br/>
> 		<b class="styleB">.styleA .styleB {color: #FF8000}</b>
> 	</p>
> 	<div class="styleA">
> 		div.styleA {color: #FF0080}
> 	</div>	
> 	<div title="x" class="styleA">
> 		div[title="x"].styleA {color: #0000FF}
> 	</div>	
> 	<p>
> 		<input type="button" class="styleA" value="p input.styleA {color: #CCAA00}"/>
> 	</p>
> 	<div>
> 		<p>
> 			<input type="button" class="styleA" value="div p input.styleA {color: #CC00FF}"/>
> 		</p>
> 	</div>	
> 	<div title="y">
> 	  <div>
> 		<p>
> 			<input type="button" class="styleA" value="[title='y'] div p input.styleA {color: #00CCFF}"/>
> 		</p>
> 	  </div>
> 	</div>	
> </body>
> </html>
> {code}
> ASSERT: Style opened at each class="styleA" should be the same as text value in element.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira