[jbosstools-issues] [JBoss JIRA] (JBIDE-10127) Resolve selector in open-on of style class in VPE

Fri Feb 17 13:33:36 EST 2012

    [ https://issues.jboss.org/browse/JBIDE-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668994#comment-12668994 ] 

Victor Rubezhny edited comment on JBIDE-10127 at 2/17/12 1:32 PM:
------------------------------------------------------------------

Disagree on CSS Style Attribute importance usage. We cannot use importance of the the style attribute in Open-Ons because we have to find rules only by CSS Class Name, but not by CSS Style attribute. Open-On knows NOTHING on CSS Style Attributes. It knows the only name of CSS Class to search.

However, I agree that more than one rule may have the same importance (I'm not about CSS Style attribute importance, but about the importance that is calculated using 'selector's specificity' for the whole CSS Rule). If so, more than one Open-On is to be shown to a user.

      was (Author: vrubezhny):
    Disagree on CSS Style Attribute importance usage. We cannot use importance of the the style attribute in Open-Ons because we have to find rules only by CSS Class Name, but not by CSS Style attribute. Open-On knows NOTHING on CSS Style Attributes. It knows the only name of CSS Class to search.

However I agree that more than one rule may have the same importance (I'm not about CSS Style attribute importance, but about the importance that is calculated using 'selector's specificity' for the whole CSS Rule). If so, more than one Open-On is to be shown to a user.

> Resolve selector in open-on of style class in VPE
> -------------------------------------------------
>
>                 Key: JBIDE-10127
>                 URL: https://issues.jboss.org/browse/JBIDE-10127
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: jsp/jsf/xml source editing
>    Affects Versions: 3.3.0.M3
>            Reporter: Viacheslav Kabanovich
>            Assignee: Victor Rubezhny
>             Fix For: 3.4.x
>
>         Attachments: css2.pdf
>
>
> EXECUTE: Create style sheet:
> {code}
>     .styleA {color: #FF0000}
>     .styleA .styleB {color: #FF8000}
>     div.styleA {color: #FF0080}
>     div[title="x"].styleA {color: #0000FF}
>     p input.styleA {color: #CCAA00}
>     div p input.styleA {color: #CC00FF}
>     [title="y"] p input.styleA {color: #00CCFF}
> {code}
> EXECUTE: Create html:
> {code}
> <html>
> <head>
> 	<title>Hello!</title> 
> 	<link href="stylesheet.css" rel="stylesheet" type="text/css"/>
> </head>
> <body>	
> 	<p class="styleA">
> 		.styleA {color: #FF0000}
> 	</p>	
> 	<p class="styleA">
> 		.styleA {color: #FF0000}
> 		<br/>
> 		<b class="styleB">.styleA .styleB {color: #FF8000}</b>
> 	</p>
> 	<div class="styleA">
> 		div.styleA {color: #FF0080}
> 	</div>	
> 	<div title="x" class="styleA">
> 		div[title="x"].styleA {color: #0000FF}
> 	</div>	
> 	<p>
> 		<input type="button" class="styleA" value="p input.styleA {color: #CCAA00}"/>
> 	</p>
> 	<div>
> 		<p>
> 			<input type="button" class="styleA" value="div p input.styleA {color: #CC00FF}"/>
> 		</p>
> 	</div>	
> 	<div title="y">
> 	  <div>
> 		<p>
> 			<input type="button" class="styleA" value="[title='y'] div p input.styleA {color: #00CCFF}"/>
> 		</p>
> 	  </div>
> 	</div>	
> </body>
> </html>
> {code}
> ASSERT: Style opened at each class="styleA" should be the same as text value in element.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira