[jbosstools-issues] [JBoss JIRA] (JBIDE-10976) Hibernate 2 /JPA facet install fails with NPE

[Fred Bricon (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred Bricon updated JBIDE-10976:
--------------------------------

    Attachment: do_not_register_maven_resource_locator.patch


Attached patch fixes the issue. we no longer register the Maven Locator to Dali and instantiate it directly to locate the persistence.xml. Fortunately, PersistenceXmlResourceProvider doesn't lookup for the project's resource Locator afterwards, when accessing the persistence.xml resource, so it seems safe. No regression found when running the test suite, tested on simple java, single or multimodule projects without issues.
                
> Hibernate 2 /JPA facet install fails with NPE
> ---------------------------------------------
>
>                 Key: JBIDE-10976
>                 URL: https://issues.jboss.org/browse/JBIDE-10976
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: hibernate
>            Reporter: Max Rydahl Andersen
>            Assignee: Fred Bricon
>            Priority: Blocker
>             Fix For: 3.3.0.Beta1
>
>         Attachments: do_not_register_maven_resource_locator.patch, resourceLocatorPriority_workaround.txt
>
>
> with latest beta1 - creating jpa project with hibernate 2 gives NPE but no info beyond that.
> error log:
> java.lang.NullPointerException
> 	at org.eclipse.jpt.common.core.internal.utility.PlatformTools.getContainer(PlatformTools.java:37)
> 	at org.eclipse.jpt.jpa.core.internal.operations.AbstractJpaFileCreationOperation.getContainer(AbstractJpaFileCreationOperation.java:65)
> 	at org.eclipse.jpt.jpa.core.internal.operations.AbstractJpaFileCreationOperation.getProject(AbstractJpaFileCreationOperation.java:73)
> 	at org.eclipse.jpt.jpa.core.internal.operations.AbstractJpaFileCreationOperation.getSchedulingRule(AbstractJpaFileCreationOperation.java:125)
> 	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.runOperation(DataModelPausibleOperationImpl.java:404)
> 	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.runOperation(DataModelPausibleOperationImpl.java:360)
> 	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.doExecute(DataModelPausibleOperationImpl.java:247)
> 	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.executeImpl(DataModelPausibleOperationImpl.java:219)
> 	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.cacheThreadAndContinue(DataModelPausibleOperationImpl.java:89)
> 	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.execute(DataModelPausibleOperationImpl.java:207)
> 	at org.eclipse.jpt.jpa.core.internal.facet.JpaFacetInstallDelegate.createPersistenceXml(JpaFacetInstallDelegate.java:115)
> 	at org.eclipse.jpt.jpa.core.internal.facet.JpaFacetInstallDelegate.createProjectXml(JpaFacetInstallDelegate.java:101)
> 	at org.eclipse.jpt.jpa.core.internal.facet.JpaFacetInstallDelegate.execute_(JpaFacetInstallDelegate.java:62)
> 	at org.eclipse.jpt.jpa.core.internal.facet.JpaFacetActionDelegate.execute(JpaFacetActionDelegate.java:34)
> 	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.callDelegate(FacetedProject.java:1477)
> 	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.modifyInternal(FacetedProject.java:441)
> 	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.mergeChangesInternal(FacetedProject.java:1181)
> 	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.access$2(FacetedProject.java:1117)
> 	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject$5.run(FacetedProject.java:1099)
> 	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
> 	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.mergeChanges(FacetedProject.java:1109)
> 	at org.eclipse.wst.common.project.facet.core.internal.FacetedProjectWorkingCopy.commitChanges(FacetedProjectWorkingCopy.java:2020)
> 	at org.eclipse.wst.common.project.facet.ui.ModifyFacetedProjectWizard.performFinish(ModifyFacetedProjectWizard.java:400)
> 	at org.eclipse.wst.web.ui.internal.wizards.NewProjectDataModelFacetWizard.performFinish(NewProjectDataModelFacetWizard.java:282)
> 	at org.eclipse.wst.common.project.facet.ui.ModifyFacetedProjectWizard$3.run(ModifyFacetedProjectWizard.java:331)
> 	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
> 	at org.eclipse.wst.common.project.facet.ui.ModifyFacetedProjectWizard$4.run(ModifyFacetedProjectWizard.java:345)
> 	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira