[jbosstools-issues] [JBoss JIRA] (JBIDE-11037) wizard is preventing going to next page if app name matches existing project

Andre Dietisheim (JIRA) jira-events at lists.jboss.org
Fri Feb 24 09:00:38 EST 2012


    [ https://issues.jboss.org/browse/JBIDE-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670823#comment-12670823 ] 

Andre Dietisheim edited comment on JBIDE-11037 at 2/24/12 8:59 AM:
-------------------------------------------------------------------

The ParametrizableWizardPageSupport binds the validation state of all bindings within a context (our wizard page for instance) to the *page complete* state of the wizard page.

1.) before the patch:

AbstractOpenShiftWizardPage#setupWizardPageSupport:

{code}
ParametrizableWizardPageSupport.create(
                IStatus.ERROR | IStatus.INFO | IStatus.WARNING | IStatus.CANCEL, this,
                dbc);
{code}
-> Validation states ERROR, INFO, WARNING, CANCEL are all considered as cases where the page is not complete, the next button shall be disabled (this is  the default in our wizard pages)

2.) after the patch:

ApplicationConfigurationWizardPage#setupWizardPageSupport (overrides the default of the abstract super-class):
{code}
ParametrizableWizardPageSupport.create(
                IStatus.ERROR | IStatus.INFO | IStatus.CANCEL, this,
                dbc);
{code}
-> only ERROR, INFO and CANCEL Validation are considered as cases where the next button shall be disabled
                
      was (Author: adietish):
    The ParametrizableWizardPageSupport binds the validation state of all bindings within a context (our wizard page for instance) to the *page complete* state of the wizard page.

1.) before the patch:

AbstractOpenShiftWizardPage#setupWizardPageSupport(DataBindingContext):

{code}
ParametrizableWizardPageSupport.create(
                IStatus.ERROR | IStatus.INFO | IStatus.WARNING | IStatus.CANCEL, this,
                dbc);
{code}
-> Validation states ERROR, INFO, WARNING, CANCEL are all considered as cases where the page is not complete, the next button shall be disabled (this is  the default in our wizard pages)

2.) after the patch:
{code}
ParametrizableWizardPageSupport.create(
                IStatus.ERROR | IStatus.INFO | IStatus.CANCEL, this,
                dbc);
{code}
-> only ERROR, INFO and CANCEL Validation are considered as cases where the next button shall be disabled
                  
> wizard is preventing going to next page if app name matches existing project
> ----------------------------------------------------------------------------
>
>                 Key: JBIDE-11037
>                 URL: https://issues.jboss.org/browse/JBIDE-11037
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>            Reporter: Max Rydahl Andersen
>            Assignee: Andre Dietisheim
>            Priority: Blocker
>             Fix For: 3.3.0.Beta1
>
>         Attachments: openshift.mkv, warn-on-existing-project-2.patch, warn-on-existing-project.patch
>
>
> (this might already be reported but couldn't find it)
> Create projet named "xyz"
> OpenShift wizard, create app named "xyz"
> now wizard will not let you do this complaining project already exist - which does not make sense to error against since
> the user might want to actually use the existing app.
> It should just warn/inform IMO and the user can choose to point to that existing app on next page

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list