[jbossts-issues] [JBoss JIRA] Commented: (JBTM-778) WSDL bindings in XTS code employ the wrong attribute in the binding:operation:input/output declarations

[Andrew Dinn (JIRA)]

    [ https://jira.jboss.org/browse/JBTM-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12546051#action_12546051 ] 

Andrew Dinn commented on JBTM-778:
----------------------------------

No, this is not the parsing problem I mentioned. However, I think that you are right that the name needs to be a simple  string. Also, the name needs to be declared in the port type declared in the imported file wsat.wsdl. Now this file is a copy of the OASIS wsdl which does not provide names for inputs/outputs in the port declarations just message types. So, mentioning a name in the bindings is not an option without modifying the OASIS wsdl. I would rather not do that since this is what is defined by the spec.

I don't think this presents a problem because you can also specify the binding inputs and outputs without using a name attribute e.g.

    <wsdl:operation name="AbortedOperation">
      <soap:operation soapAction="http://docs.oasis-open.org/ws-tx/wsat/2006/06/Aborted" style="document"/>
      <wsdl:input>
        <soap:body use="literal"/>
      </wsdl:input>
    </wsdl:operation>

The input message type should still be determined correctly using the information provided in the port type and the name should still default to the unqualified name of the message type. So, I think the required fix is just to remove the message=.. .attributes from the binding:operation:input/output elements.

> WSDL bindings in XTS code employ the wrong attribute in the binding:operation:input/output declarations
> -------------------------------------------------------------------------------------------------------
>
>                 Key: JBTM-778
>                 URL: https://jira.jboss.org/browse/JBTM-778
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: XTS
>    Affects Versions: 4.12.0
>            Reporter: Andrew Dinn
>            Assignee: Andrew Dinn
>             Fix For: 4.13.0
>
>
> The WSDL for the WSTX service bindings employs the invalid attribute "message" for the binding:operation:input and binding:operation:output elements. The correct attribute name is "name". e.g. in wscoor-activation-binding.wsdl the declaration is
>   <wsdl:binding name="Activation_SOAPBinding" type="wscoor:ActivationPortType">
>     <soap:binding style="document" transport="http://schemas.xmlsoap.org/soap/http"/>
>     <wsdl:operation name="CreateCoordinationContextOperation">
>             <wsdl:input message="wscoor:CreateCoordinationContext">
>                 <soap:body use="literal"/>
>             </wsdl:input>
>             <wsdl:output message="wscoor:CreateCoordinationContextResponse">
>                 <soap:body use="literal"/>
>             </wsdl:output>
>         </wsdl:operation>
>   </wsdl:binding>
> The correct version  should be
>   <wsdl:binding name="Activation_SOAPBinding" type="wscoor:ActivationPortType">
>     <soap:binding style="document" transport="http://schemas.xmlsoap.org/soap/http"/>
>     <wsdl:operation name="CreateCoordinationContextOperation">
>             <wsdl:input name="wscoor:CreateCoordinationContext">
>                 <soap:body use="literal"/>
>             </wsdl:input>
>             <wsdl:output name="wscoor:CreateCoordinationContextResponse">
>                 <soap:body use="literal"/>
>             </wsdl:output>
>         </wsdl:operation>
>   </wsdl:binding>
> According to a comment in the flle this was a workaround for an error in the com.ibm.wsdl parsing which now appears to have been fixed. The WSDL should be updated accordingly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira