[jbossts-issues] [JBoss JIRA] Created: (JBTM-789) Potential connection leak

Mauro Molinari (JIRA) jira-events at lists.jboss.org
Wed Sep 15 08:12:28 EDT 2010


Potential connection leak
-------------------------

                 Key: JBTM-789
                 URL: https://jira.jboss.org/browse/JBTM-789
             Project: JBoss Transaction Manager
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: JTA
         Environment: JBoss Transactions 4.11, Tomcat, Spring
            Reporter: Mauro Molinari


I recently upgraded JBossTS from 4.6.1 GA to 4.11 Final. I see that bug JBTM-532 that I opened against 4.5 and 4.6 should have been fixed in 4.8.0. However, I have a doubt on the current (4.11) implementation of com.arjuna.ats.internal.jdbc.ConnectionImple.close().
 
I mean, if _theModifier is null, a comment says: "no indication about connections, so assume close immediately". However in this case only _theConnection is closed and set to null, while _recoveryConnection.closeCloseCurrentConnection() is not called. I think this may lead to connection leaks.

What I would expect is that if _theModifier is null, a log entry were added but nothing else were done; in particular I would expect not to return and let the following "if (!delayClose)" (towards the end of the method) close the connections immediately (both _theConnection and _recoveryConnection).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbossts-issues mailing list