[jbossts-issues] [JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2

Paul Robinson (JIRA) jira-events at lists.jboss.org
Mon Dec 17 11:49:08 EST 2012


     [ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Robinson updated JBTM-1145:
--------------------------------

    Description: 
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.

Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}

Add logging

Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
@Required to something that matched EJB TX annotation

Remove Statefull tests

Consider making handlers statefull

  was:
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.

Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}

Add logging

Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
@Required to something that matched EJB TX annotation

Remove Statefull tests


    
> TXFramework Code Tidy Part 2
> ----------------------------
>
>                 Key: JBTM-1145
>                 URL: https://issues.jboss.org/browse/JBTM-1145
>             Project: JBoss Transaction Manager
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: TXFramework
>            Reporter: Paul Robinson
>            Assignee: Paul Robinson
>             Fix For: 5.0.0.M2
>
>   Original Estimate: 1 day
>  Remaining Estimate: 1 day
>
> Test restructuring
> Try using annotations in subsystem
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO  [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> @Required to something that matched EJB TX annotation
> Remove Statefull tests
> Consider making handlers statefull

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbossts-issues mailing list