[jbossts-issues] [JBoss JIRA] (JBTM-1057) Port TXBridge demo tests to quickstarts/txbridge/demo
Paul Robinson (JIRA)
jira-events at lists.jboss.org
Mon Feb 20 07:50:36 EST 2012
[ https://issues.jboss.org/browse/JBTM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669180#comment-12669180 ]
Paul Robinson commented on JBTM-1057:
1. (Slightly unrelated) can we move the XTS demo to quickstarts/?
Way ahead of you ;-) [JBTM-1056]
2. (on topic) Is the idea that the user builds upon the XTS demo or is the restaurant service used for hack/simplicity? If the idea is that we build upon the XTS demo then I think that the dependency (assuming XTS demo is moved to quickstarts) is OK, if the restaurant service is however used out of convenience and the XTS demo is not referenced in any way in associated meta-data (README.md etc) then I think it is a good idea to duplicate the code in the TXBridge demo and break the dependency.
I see it being used for "hack/simplicity" (not sure which). However, this is referenced in the TXBridge documentation. I agree, I think we need to remove the dependency on the XTS demo. I think we just need to copy&simplify the Restaurant service into the TXBridge demo and update the docs.
> Port TXBridge demo tests to quickstarts/txbridge/demo
> Key: JBTM-1057
> URL: https://issues.jboss.org/browse/JBTM-1057
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TxBridge
> Affects Versions: 5.0.0.M1
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 5.0.0.M3
> Currently the TXBridge demo tests are only in the 4.16 branch. Here they live in the JBossTS project and pull in built artefacts for, txbridge-demo-service.jar, txbridge-demo-client.war and xts-demo.ear.
> see here: https://svn.jboss.org/repos/labs/labs/jbosstm/branches/JBOSSTS_4_16/txbridge/demo-test/src/test/java/org/jboss/jbossts/txbridge/demotest/TxBridgeDemoTest.java
> The TXBridge demo has been moved, in trunk, to the quickstarts project. Therefore the built artefact of the XTS demo will not be available. We need to figure out a way of pulling this in. Maybe we could pull in the XTS demo as a maven artefact? Alternately, we could remove the dependency on the XTS demo by re-creating the Restaurant service in the TXBridge demo.
> Also, it doesn't seem right, that built txbridge-demo artefacts are required. Wouldn't it be better for shrinkwrap to create these?
> The reason why these artefacts where used in 4.16, was to fit in with the existing layout and build system. In trunk we are using maven throughout and can make more disruptive changes, so we should try and get this test right.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jbossts-issues