[jbossts-issues] [JBoss JIRA] (JBTM-849) registerSynchronization fails with wrong status message

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677792#comment-12677792 ] 

Tom Jenkinson commented on JBTM-849:
------------------------------------

Is part of the confusion that an underlying state of the "JBoss Transactions" view of a transaction (i.e. ActionStatus) is being exposed to the user in the error message?

If we wanted to lift some text from the javadoc we could return:

java.lang.IllegalStateException: "Transaction is in the prepared state or the transaction is inactive."
	at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.registerSynchronizationImple(TransactionImple.java:367)


But this would be less helpful if a Jira was raised a guess. I am definitely tempted to resolve this as "Won't fix" but will wait to see if anyone has anything else to add.
                
> registerSynchronization fails with wrong status message
> -------------------------------------------------------
>
>                 Key: JBTM-849
>                 URL: https://issues.jboss.org/browse/JBTM-849
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JTA
>    Affects Versions: 4.15.1
>         Environment: https://github.com/jbossejb3/jboss-as/tree/991e836c1bcb6b471010c5930fc3f58e72ed7972
>            Reporter: Carlo de Wolf
>            Assignee: Tom Jenkinson
>             Fix For: 5.0.1.Final
>
>         Attachments: JBTM-849-stracktrace.txt
>
>
> registerSynchronization is called from within a beforeCompletion of another Synchronization. I would expect the status to be PREPARING (or anything but RUNNING).
> {noformat}
> java.lang.IllegalStateException: Synchronizations are not allowed! Transaction status isActionStatus.RUNNING
> 	at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.registerSynchronizationImple(TransactionImple.java:367)
> 	at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.registerSynchronization(TransactionImple.java:344)
> 	at org.jboss.jca.core.connectionmanager.transaction.TransactionSynchronizer.getRegisteredSynchronizer(TransactionSynchronizer.java:198)
> 	at org.jboss.jca.core.connectionmanager.listener.TxConnectionListener.enlist(TxConnectionListener.java:210)
> 	at org.jboss.jca.core.connectionmanager.tx.TxConnectionManagerImpl.managedConnectionReconnected(TxConnectionManagerImpl.java:407)
> 	... 104 more
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira