[jbossts-issues] [JBoss JIRA] (JBTM-1645) Allow pull requests to configure some parameters in scripts/hudson/narayana.sh

[Paul Robinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769569#comment-12769569 ] 

Paul Robinson commented on JBTM-1645:
-------------------------------------

How about we do this:

Split the PR job into a multi config with the same split as Narayana:

MAIN
XTS
QA_JTA
QA_JTS_JACORB
QA_JTS_JDKORB

These will all be scheduled in a random order, which is annoying if you are willing to merge based on a sub-set of tests. It wastes resources, and causes you to wait longer as the tests you are uninterested in may be scheduled first.

The solution is to specify in the description which of the above groups you wish to skip. This is similar to what you mention above, but a bit more course-grained and fits in more neatly with the hudson multi-config approach.

You can get the PR description with the following command. There's probably a better approach, but this works:

curl -s https://api.github.com/repos/jbosstm/narayana/pulls/279 | grep \"body\":

I don't think it makes sense to allow MAIN to be skipped, and if you want to skip one lot of QA tests, you probably want to skip them all? So how about we just have these two options:

skipXTS
skipQA

We could add more fine-grained options if it proves useful.

I don't see the point in specifying who can do this. If a contributor skips some tests that need to pass, we simply tell them to update the description and re-test.
                
> Allow pull requests to configure some parameters in scripts/hudson/narayana.sh
> ------------------------------------------------------------------------------
>
>                 Key: JBTM-1645
>                 URL: https://issues.jboss.org/browse/JBTM-1645
>             Project: JBoss Transaction Manager
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Build System
>            Reporter: Tom Jenkinson
>            Assignee: Paul Robinson
>            Priority: Critical
>             Fix For: 5.0.0.M3
>
>
> If the pull description has something like this:
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=1 TXF_TESTS=1 XTS_TESTS=1 XTS_AS_TESTS=1 txbridge=1 QA_TESTS=1 [SUN_ORB=0] [JAC_ORB=1] [QA_TARGET=ci-jts-tests]
> We could use it in scripts/hudson/narayana.sh if we detect it is a pull build. We might need to white list users we apply this to.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira