[jbossts-issues] [JBoss JIRA] (JBTM-1645) Allow pull requests to configure some parameters in scripts/hudson/narayana.sh

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770156#comment-12770156 ] 

Tom Jenkinson commented on JBTM-1645:
-------------------------------------

That should be fine, I presume they wouldn't have to "comment_on_pull" as the variable can be checked before so the pull request comments won't include erroneous "Tests passed". Indeed, perhaps they could comment "XTS tests skipped as per request" if we wanted it to?
                
> Allow pull requests to configure some parameters in scripts/hudson/narayana.sh
> ------------------------------------------------------------------------------
>
>                 Key: JBTM-1645
>                 URL: https://issues.jboss.org/browse/JBTM-1645
>             Project: JBoss Transaction Manager
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Build System
>            Reporter: Tom Jenkinson
>            Assignee: Paul Robinson
>            Priority: Critical
>             Fix For: 5.0.0.M3
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> If the pull description has something like this:
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=1 TXF_TESTS=1 XTS_TESTS=1 XTS_AS_TESTS=1 txbridge=1 QA_TESTS=1 [SUN_ORB=0] [JAC_ORB=1] [QA_TARGET=ci-jts-tests]
> We could use it in scripts/hudson/narayana.sh if we detect it is a pull build. We might need to white list users we apply this to.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira