[jbossts-issues] [JBoss JIRA] (JBTM-1430) Restore commit method to AtomicAction

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746149#comment-12746149 ] 

Tom Jenkinson commented on JBTM-1430:
-------------------------------------

OK, the public API is sorted: https://github.com/jbosstm/narayana/commit/43e7bdd94cce6ec051587dcdc433139d79fb4646

There are number of internal package classes that have added methods purely for tests, I have looked at each one to see if I can change it to use a standard API easily. There are a significant number where this is feasible, however some cases would require moving the classes to other packages and changes to the state variables to allow them to be picked up as package scoped state. tbh I would prefer to just leave the internal code as deprecated so devs avoid using them in future and so we don't build up a test suite dependent on shortcuts into the code.
                
> Restore commit method to AtomicAction
> -------------------------------------
>
>                 Key: JBTM-1430
>                 URL: https://issues.jboss.org/browse/JBTM-1430
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Transaction Core
>    Affects Versions: 4.17.3
>            Reporter: Mark Little
>            Assignee: Tom Jenkinson
>
> At some point someone deprecated the commit method in AtomicAction and left the following comment:
> @deprecated Only used by tests
> This is wrong. Just because we don't use the commit method in the code does not mean it is invalid in the scope of the public API. The commit method without the boolean parameter is a helper method to simplify calling the other commit with true all of the time. This was added years ago based on feedback from the OTS Current implementation, which had (in C++) a default boolean=true parameter in its signature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira