[jbossts-issues] [JBoss JIRA] (JBTM-1712) perf problem in FileSystemStore.openAndLock

Tom Jenkinson (JIRA) jira-events at lists.jboss.org
Thu Jul 18 16:16:27 EDT 2013


     [ https://issues.jboss.org/browse/JBTM-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Jenkinson updated JBTM-1712:
--------------------------------

           Status: Resolved  (was: Pull Request Sent)
    Fix Version/s: 4.17.6
                       (was: 4.17.7)
       Resolution: Done

    
> perf problem in FileSystemStore.openAndLock
> -------------------------------------------
>
>                 Key: JBTM-1712
>                 URL: https://issues.jboss.org/browse/JBTM-1712
>             Project: JBoss Transaction Manager
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: Transaction Core
>    Affects Versions: 4.16.4, 5.0.0.M2
>            Reporter: Jonathan Halliday
>            Assignee: Mark Little
>             Fix For: 5.0.0.M3, 4.17.6
>
>
> if(!file.exits())
> {
>    if(createHierarchy(file))
> incorrectly calls the expensive (because synchronized) createHierarchy method in the common case where the file does not exist (because it's a uniq named new tx record) but the directory hierarchy does (because it's the create-once hashed dir tree).  This causes excessive contention on the FileSystemStore instance object monitor lock.  Should probably be something more like 
> if(!file.getParent().exists())
> {
>   if(createHierarchy(file))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbossts-issues mailing list