[jbossts-issues] [JBoss JIRA] (JBTM-2147) Transactions are leaked when XAResource misbehaves

[Koen Janssens (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12960321#comment-12960321 ] 

Koen Janssens commented on JBTM-2147:
-------------------------------------

The hornetq issue is already being fixed. I just want to make sure narayna is a bit more robust in case of a  misbehaving XA resource

If you want a Narayana log, i can give you one ;-)

ARJUNA012078: Abort called illegaly on atomic action 0:ffff40bab98c:1f71a485:5335ece7:3625a31)

This happens on the original thread, which  has a TX in 'aborting' state (since reaper tried to abort it and failed in the middle). After this warning, Naryana calls 
com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator#afterCompletion(int), which will end up calling javax.transaction.Synchronzier.afterComplete. But according to the JTA spec, that should only be done when the TX is 'finished'. HOwever, in case the Tx is in 'aborting' state, some resources can still be 'enlisted' and the TX should not be considered finished

. 



                
> Transactions are leaked when XAResource misbehaves
> --------------------------------------------------
>
>                 Key: JBTM-2147
>                 URL: https://issues.jboss.org/browse/JBTM-2147
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JTS
>    Affects Versions: 4.17.7
>         Environment: jboss EAP 6.1.1
>            Reporter: Koen Janssens
>            Assignee: Tom Jenkinson
>
> We have noticed that arjuna leaks transactions when something 'unexpected' happens during tx aborting. The transaction stays in 'aborting' state while it does notify TxLIsteners that the tx has ended. 
> This can be reproduced as follows: 
> * A TX is started and both a DB (last)resource and horntq (XA) resource get enlisted. The tx takes a long time and times out. 
> * Arjuna reaper thread notices the time out and starts a worker thread to cancel the TX. 
> * Before the worker thread can 'abort' the hornetq XA resource, the arjuna worker thread is interruped (txReaperCancelWaitPeriod expires) by arjuna
> * Since the worker thread is interruped, the hornetq XA resource throws an 'HornetQInterruptedException'
> * This unexpected exception causes arjuna to notify registered javax/transaction/Synchronization's (and return DB connection to the pool), without ending the Tx. 
> From then on, jboss logs are full of: 
> Trying to start a new transaction when old is not complete: Old: < formatId=131077, gtrid_length=29, bqual_length=36, tx_uid=0:ffff40bab98c:1f71a485:5335ece7:3625a31, node_name=1, branch_uid=0:ffff40bab98c:1f71a485:5335ece7:3625bbc, subordinatenodename=null, eis_name=java:/XAOracleDS >, New < formatId=131077, gtrid_length=29, bqual_length=36, tx_uid=0:ffff40bab98c:1f71a485:5335ece7:3641efc, node_name=1, branch_uid=0:ffff40bab98c:1f71a485:5335ece7:36420a1, subordinatenodename=null, eis_name=java:/XAOracleDS >, Flags 0
> Although the root cause is a misbehaving hornetq resource, I think arjuna should be a bit more resilient. 
> More background in https://access.redhat.com/support/cases/01061583/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira